Reinette Chatre 32f010deab x86/resctrl: Prevent possible overrun during bitmap operations ... While the DOC at the beginning of lib/bitmap.c explicitly states that "The number of valid bits in a given bitmap does _not_ need to be an exact multiple of BITS_PER_LONG.", some of the bitmap operations do indeed access BITS_PER_LONG portions of the provided bitmap no matter the size of the provided bitmap. For example, if find_first_bit() is provided with an 8 bit bitmap the operation will access BITS_PER_LONG bits from the provided bitmap. While the operation ensures that these extra bits do not affect the result, the memory is still accessed. The capacity bitmasks (CBMs) are typically stored in u32 since they can never exceed 32 bits. A few instances exist where a bitmap_* operation is performed on a CBM by simply pointing the bitmap operation to the stored u32 value. The consequence of this pattern is that some bitmap_* operations will access out-of-bounds memory when interacting with the provided CBM. This same issue has previously been addressed with commit 49e00eee00 ("x86/intel_rdt: Fix out-of-bounds memory access in CBM tests") but at that time not all instances of the issue were fixed. Fix this by using an unsigned long to store the capacity bitmask data that is passed to bitmap functions. Fixes: e651901187 ("x86/intel_rdt: Introduce "bit_usage" to display cache allocations details") Fixes: f4e80d67a5 ("x86/intel_rdt: Resctrl files reflect pseudo-locked information") Fixes: 95f0b77efa ("x86/intel_rdt: Initialize new resource group with sane defaults") Signed-off-by: Reinette Chatre <reinette.chatre@intel.com> Signed-off-by: Borislav Petkov <bp@suse.de> Cc: Fenghua Yu <fenghua.yu@intel.com> Cc: "H. Peter Anvin" <hpa@zytor.com> Cc: Ingo Molnar <mingo@redhat.com> Cc: stable <stable@vger.kernel.org> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Tony Luck <tony.luck@intel.com> Cc: x86-ml <x86@kernel.org> Link: https://lkml.kernel.org/r/58c9b6081fd9bf599af0dfc01a6fdd335768efef.1560975645.git.reinette.chatre@intel.com		2019-06-20 15:39:19 +02:00
..
core.c
ctrlmondata.c	x86/resctrl: Initialize a new resource group with default MBA values	2019-04-18 00:06:31 +02:00
internal.h	kernfs, sysfs, cgroup, intel_rdt: Support fs_context	2019-02-28 03:29:34 -05:00
Makefile	x86/resctrl: Avoid confusion over the new X86_RESCTRL config	2019-02-02 10:34:52 +01:00
monitor.c	x86/resctrl: Prevent NULL pointer dereference when local MBM is disabled	2019-06-12 10:31:50 +02:00
pseudo_lock_event.h
pseudo_lock.c	x86/resctrl: Remove duplicate MSR_MISC_FEATURE_CONTROL definition	2019-02-05 07:21:56 +01:00
rdtgroup.c	x86/resctrl: Prevent possible overrun during bitmap operations	2019-06-20 15:39:19 +02:00