Andres Freund c1c8013ec3 perf c2c: Fix return type for histogram sorting comparision functions ... Commit 722ddfde36 ("perf tools: Fix time sorting") changed - correctly so - hist_entry__sort to return int64. Unfortunately several of the builtin-c2c.c comparison routines only happened to work due the cast caused by the wrong return type. This causes meaningless ordering of both the cacheline list, and the cacheline details page. E.g a simple: perf c2c record -a sleep 3 perf c2c report will result in cacheline table like ================================================= Shared Data Cache Line Table ================================================= # # ------- Cacheline ---------- Total Tot - LLC Load Hitm - - Store Reference - - Load Dram - LLC Total - Core Load Hit - - LLC Load Hit - # Index Address Node PA cnt records Hitm Total Lcl Rmt Total L1Hit L1Miss Lcl Rmt Ld Miss Loads FB L1 L2 Llc Rmt # ..... .............. .... ...... ....... ...... ..... ..... ... .... ..... ...... ...... .... ...... ..... ..... ..... ... .... ....... 0 0x7f0d27ffba00 N/A 0 52 0.12% 13 6 7 12 12 0 0 7 14 40 4 16 0 0 0 1 0x7f0d27ff61c0 N/A 0 6353 14.04% 1475 801 674 779 779 0 0 718 1392 5574 1299 1967 0 115 0 2 0x7f0d26d3ec80 N/A 0 71 0.15% 16 4 12 13 13 0 0 12 24 58 1 20 0 9 0 3 0x7f0d26d3ec00 N/A 0 98 0.22% 23 17 6 19 19 0 0 6 12 79 0 40 0 10 0 i.e. with the list not being ordered by Total Hitm. Fixes: 722ddfde36 ("perf tools: Fix time sorting") Signed-off-by: Andres Freund <andres@anarazel.de> Tested-by: Michael Petlan <mpetlan@redhat.com> Acked-by: Jiri Olsa <jolsa@redhat.com> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com> Cc: Andi Kleen <ak@linux.intel.com> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: stable@vger.kernel.org # v3.16+ Link: http://lore.kernel.org/lkml/20200109043030.233746-1-andres@anarazel.de Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>		2020-01-14 13:29:21 -03:00
..
accounting
arch	tools arch x86: Sync asm/cpufeatures.h with the kernel sources	2019-12-02 15:20:05 -03:00
bpf	bpftool: Don't crash on missing jited insns or ksyms	2019-12-11 13:57:26 +01:00
build	perf/ui/gtk: Fix gtk2 build	2020-01-14 12:40:33 -03:00
cgroup
debugging
firewire
firmware
gpio	tools: gpio: Correctly add make dependencies for gpio_utils	2019-11-13 13:46:04 +01:00
hv	tools: hv: add vmbus testing tool	2019-11-21 20:10:44 -05:00
iio
include	tools lib: Fix builds when glibc contains strlcpy()	2020-01-06 11:46:10 -03:00
io_uring
kvm/kvm_stat
laptop
leds
lib	libperf: Setup initial evlist::all_cpus value	2020-01-14 12:02:19 -03:00
memory-model
nfsd
objtool	Merge branch 'perf-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2019-11-26 15:04:47 -08:00
pci
pcmcia
perf	perf c2c: Fix return type for histogram sorting comparision functions	2020-01-14 13:29:21 -03:00
power	platform-drivers-x86 for v5.5-1	2019-12-01 18:24:25 -08:00
scripts
spi
testing	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2019-12-22 09:54:33 -08:00
thermal/tmon
time
usb
virtio
vm
wmi
Makefile