Thomas Gleixner c0a9f4d396 can: c_can: Reduce register access ... commit 4ce78a838c (can: c_can: Speed up rx_poll function) hyped a performance improvement by reducing the access to the interrupt pending register from a dual 16 bit to a single 16 bit access. Wow! Thereby it crippled the driver to cast the 16 msg objects in stone, which is completly braindead as contemporary hardware has up to 128 message objects. Supporting larger object buffers is a major surgery, but it'd be definitely worth it especially as the driver does not support HW message filtering .... The logic of the "FIFO" implementation is to split the FIFO in half. For the lower half we read the buffers and clear the interrupt pending bit, but keep the newdat bit set, so the HW will queue above those buffers. When we read out the last low buffer then we reenable all the low half buffers by clearing the newdat bit. The upper half buffers clear the newdat and the interrupt pending bit right away as we know that the lower half bits are clear and give us a headstart against the hardware. Now the implementation is: transfer_message_object() read_object_and_put_into_skb(); if (obj < END_OF_LOW_BUF) clear_intpending(obj) else if (obj > END_OF_LOW_BUF) clear_intpending_and_newdat(obj) else if (obj == END_OF_LOW_BUF) clear_newdat_of_all_low_objects() The hardware allows to avoid most of the mess simply because we can tell the transfer_message_object() function to clear bits right away. So we can be clever and do: if (obj <= END_OF_LOW_BUF) ctrl = TRANSFER_MSG | CLEAR_INTPND; else ctrl = TRANSFER_MSG | CLEAR_INTPND | CLEAR_NEWDAT; transfer_message_object(ctrl) read_object_and_put_into_skb(); if (obj == END_OF_LOW_BUF) clear_newdat_of_all_low_objects() So we save a complete control operation on all message objects except the one which is the end of the low buffer. That's a few micro seconds per object. I'm not adding a boasting profile to that, simply because it's self explaining. Signed-off-by: Thomas Gleixner <tglx@linutronix.de> [mkl: adjusted subject and commit message] Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>		2014-04-01 11:55:01 +02:00
..
c_can_pci.c	can: c_can: remove unnecessary pci_set_drvdata()	2013-09-21 15:43:15 +02:00
c_can_platform.c	can: c_can: Fix hardware raminit function	2014-04-01 11:54:57 +02:00
c_can.c	can: c_can: Reduce register access	2014-04-01 11:55:01 +02:00
c_can.h	can: c_can: Provide protection in the xmit path	2014-04-01 11:55:00 +02:00
Kconfig	can: Kconfig: convert 'depends on CAN_DEV' into 'if CAN_DEV...endif' block	2013-01-26 16:58:58 +01:00
Makefile	c_can_pci: generic module for C_CAN/D_CAN on PCI	2012-06-19 21:22:28 +02:00