John Johansen c037bd6158 apparmor: remove no-op permission check in policy_unpack ... The patch 736ec752d9: "AppArmor: policy routines for loading and unpacking policy" from Jul 29, 2010, leads to the following static checker warning: security/apparmor/policy_unpack.c:410 verify_accept() warn: bitwise AND condition is false here security/apparmor/policy_unpack.c:413 verify_accept() warn: bitwise AND condition is false here security/apparmor/policy_unpack.c 392 #define DFA_VALID_PERM_MASK 0xffffffff 393 #define DFA_VALID_PERM2_MASK 0xffffffff 394 395 /** 396 * verify_accept - verify the accept tables of a dfa 397 * @dfa: dfa to verify accept tables of (NOT NULL) 398 * @flags: flags governing dfa 399 * 400 * Returns: 1 if valid accept tables else 0 if error 401 */ 402 static bool verify_accept(struct aa_dfa *dfa, int flags) 403 { 404 int i; 405 406 /* verify accept permissions */ 407 for (i = 0; i < dfa->tables[YYTD_ID_ACCEPT]->td_lolen; i++) { 408 int mode = ACCEPT_TABLE(dfa)[i]; 409 410 if (mode & ~DFA_VALID_PERM_MASK) 411 return 0; 412 413 if (ACCEPT_TABLE2(dfa)[i] & ~DFA_VALID_PERM2_MASK) 414 return 0; fixes: 736ec752d9 ("AppArmor: policy routines for loading and unpacking policy") Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: John Johansen <john.johansen@canonical.com>		2018-08-22 18:44:42 -07:00
..
apparmor	apparmor: remove no-op permission check in policy_unpack	2018-08-22 18:44:42 -07:00
integrity	Merge branch 'next-integrity' of git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security	2018-06-07 15:40:37 -07:00
keys	dh key: fix rounding up KDF output length	2018-06-26 09:43:05 -07:00
loadpin	get rid of pointless includes of fs_struct.h	2018-02-22 14:28:50 -05:00
selinux	selinux/stable-4.18 PR 20180629	2018-06-30 11:15:12 -07:00
smack	Smack: Mark inode instant in smack_task_to_inode	2018-06-23 10:45:56 +09:00
tomoyo	net: make getname() functions return length rather than use int* parameter	2018-02-12 14:15:04 -05:00
yama	pids: introduce find_get_task_by_vpid() helper	2018-02-06 18:32:46 -08:00
commoncap.c	capabilities: Allow privileged user in s_user_ns to set security.* xattrs	2018-05-24 12:03:31 -05:00
device_cgroup.c	docs: fix broken references with multiple hints	2018-06-15 18:10:01 -03:00
inode.c	securityfs: add the ability to support symlinks	2017-06-08 12:51:43 -07:00
Kconfig	Currently, hardened usercopy performs dynamic bounds checking on slab	2018-02-03 16:25:42 -08:00
lsm_audit.c	audit: use inline function to get audit context	2018-05-14 17:24:18 -04:00
Makefile	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
min_addr.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
security.c	security: add hook for socketpair()	2018-05-04 12:48:54 -07:00