Hugh Dickins 2e7842b887 [PATCH] fix umask when noACL kernel meets extN tuned for ACLs ... Fix insecure default behaviour reported by Tigran Aivazian: if an ext2 or ext3 or ext4 filesystem is tuned to mount with "acl", but mounted by a kernel built without ACL support, then umask was ignored when creating inodes - though root or user has umask 022, touch creates files as 0666, and mkdir creates directories as 0777. This appears to have worked right until 2.6.11, when a fix to the default mode on symlinks (always 0777) assumed VFS applies umask: which it does, unless the mount is marked for ACLs; but ext[234] set MS_POSIXACL in s_flags according to s_mount_opt set according to def_mount_opts. We could revert to the 2.6.10 ext[234]_init_acl (adding an S_ISLNK test); but other filesystems only set MS_POSIXACL when ACLs are configured. We could fix this at another level; but it seems most robust to avoid setting the s_mount_opt flag in the first place (at the expense of more ifdefs). Likewise don't set the XATTR_USER flag when built without XATTR support. Signed-off-by: Hugh Dickins <hugh@veritas.com> Cc: Tigran Aivazian <tigran@aivazian.fsnet.co.uk> Cc: <linux-ext4@vger.kernel.org> Cc: Andreas Gruenbacher <agruen@suse.de> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>		2007-02-11 10:51:34 -08:00
..
acl.c	[PATCH] fs: Removing useless casts	2006-09-27 08:26:10 -07:00
acl.h	[PATCH] remove <linux/xattr_acl.h>	2005-06-23 09:45:33 -07:00
balloc.c	[PATCH] EXT2: Remove superblock lock contention in ext2_statfs	2006-09-19 07:59:59 -07:00
dir.c	[PATCH] ext2: skip pages past number of blocks in ext2_find_entry	2007-02-11 10:51:28 -08:00
ext2.h	[PATCH] BLOCK: Move the Ext2 device ioctl compat stuff to the Ext2 driver [try #6]	2006-09-30 20:52:29 +02:00
file.c	[PATCH] Streamline generic_file_* interfaces and filemap cleanups	2006-10-01 00:39:28 -07:00
fsync.c	[PATCH] ext2: cleanup: put_page and comment fix	2006-06-25 10:01:25 -07:00
ialloc.c	[PATCH] inode-diet: Eliminate i_blksize from the inode structure	2006-09-27 08:26:18 -07:00
inode.c	[PATCH] inode-diet: Eliminate i_blksize from the inode structure	2006-09-27 08:26:18 -07:00
ioctl.c	[PATCH] ext2: change uses of f_{dentry, vfsmnt} to use f_path	2006-12-08 08:28:41 -08:00
Makefile	[PATCH] Make EXT2_DEBUG work again	2006-06-25 10:01:12 -07:00
namei.c	[PATCH] r/o bind mounts: unlink: monitor i_nlink	2006-10-01 00:39:30 -07:00
super.c	[PATCH] fix umask when noACL kernel meets extN tuned for ACLs	2007-02-11 10:51:34 -08:00
symlink.c	Fix nasty ncpfs symlink handling bug.	2005-08-19 18:02:56 -07:00
xattr_security.c	[PATCH] ext2: Enable atomic inode security labeling	2005-09-09 13:57:27 -07:00
xattr_trusted.c	[PATCH] capable/capability.h (fs/)	2006-01-11 18:42:13 -08:00
xattr_user.c	[PATCH] remove ext2 xattr permission checks	2006-01-10 08:01:30 -08:00
xattr.c	[PATCH] Remove superfluous lock_super() in extN xattr code	2006-12-07 08:39:32 -08:00
xattr.h	Remove obsolete #include <linux/config.h>	2006-06-30 19:25:36 +02:00
xip.c	[PATCH] fix xip sparse file handling in ext2	2005-07-27 16:25:53 -07:00
xip.h	[PATCH] xip: ext2: execute in place	2005-06-24 00:06:41 -07:00