Dave Jones bb0dcebef9 ipmi: Remove unnecessary pci_disable_device. ... We call cleanup_one_si from ipmi_pci_remove, which calls ->addr_source_cleanup, which gets set to point to ipmi_pci_cleanup, which does a pci_disable_device. On return from this, we do a second pci_disable_device, which results in the trace below. ipmi_si 0000:00:16.0: disabling already-disabled device Call Trace: [<ffffffff818ce54c>] dump_stack+0x45/0x57 [<ffffffff810525f7>] warn_slowpath_common+0x97/0xe0 [<ffffffff810526f6>] warn_slowpath_fmt+0x46/0x50 [<ffffffff81497ca1>] pci_disable_device+0xb1/0xc0 [<ffffffffa00851a5>] ipmi_pci_remove+0x25/0x30 [ipmi_si] [<ffffffff8149a696>] pci_device_remove+0x46/0xc0 [<ffffffff8156801f>] __device_release_driver+0x7f/0xf0 [<ffffffff81568978>] driver_detach+0xb8/0xc0 [<ffffffff81567e50>] bus_remove_driver+0x50/0xa0 [<ffffffff8156914e>] driver_unregister+0x2e/0x60 [<ffffffff8149a3e5>] pci_unregister_driver+0x25/0x90 [<ffffffffa0085804>] cleanup_ipmi_si+0xd4/0xf0 [ipmi_si] [<ffffffff810c727a>] SyS_delete_module+0x12a/0x200 [<ffffffff818d4d72>] system_call_fastpath+0x12/0x17 Signed-off-by: Dave Jones <dsj@fb.com>		2016-01-12 15:08:49 -06:00
..
agp	agp/uninorth: fix a memleak in create_gatt_table	2015-10-02 22:57:59 +10:00
hw_random	x86/cpufeature: Remove unused and seldomly used cpu_has_xx macros	2015-12-19 11:49:55 +01:00
ipmi	ipmi: Remove unnecessary pci_disable_device.	2016-01-12 15:08:49 -06:00
mwave	drivers/char: delete non-required instances of include <linux/init.h>	2014-02-07 15:10:19 -08:00
pcmcia	tty: Remove ASYNC_CLOSING checks in open()/hangup() methods	2015-10-17 21:11:29 -07:00
tpm	Merge tag 'tpmdd-next-20151110' of https://github.com/jsakkine/linux-tpmdd into for-linus	2015-11-12 20:38:04 +11:00
xilinx_hwicap	char:xilinx_hwicap:buffer_icap - change 1/0 to true/false for bool type variable in function buffer_icap_set_configuration().	2015-06-12 16:58:33 -07:00
xillybus	char: xillybus: Allow 64-bit DMA on PCIe interface	2015-08-05 12:27:09 -07:00
apm-emulation.c	apm-emulation: add hibernation APM events to support suspend2disk	2014-01-07 13:50:28 +01:00
applicom.c	applicom: dereferencing NULL on error path	2014-05-27 17:43:12 -07:00
applicom.h
bfin-otp.c
bsr.c	bsr: avoid format string leaking into device name	2014-07-09 16:59:15 -07:00
ds1302.c
ds1620.c
dsp56k.c	drivers/char/dsp56k.c: drop check for negativity of unsigned parameter	2014-07-17 18:38:37 -07:00
dtlk.c
efirtc.c	drivers/char: make efirtc.c driver explicitly non-modular	2015-09-20 19:32:35 -07:00
generic_nvram.c
genrtc.c
hangcheck-timer.c	hangcheck-timer: cleanup casting in hangcheck_init()	2014-11-07 11:24:01 -08:00
hpet.c	drivers/char: make hpet.c explicitly non-modular	2015-09-20 19:32:35 -07:00
Kconfig	drivers/char: Remove msm_smd_pkt driver	2015-05-24 12:24:35 -07:00
lp.c	char: Int overflow in lp_do_ioctl().	2013-12-18 16:39:54 -08:00
Makefile	hwmon: Rename i8k driver to dell-smm-hwmon and move it to hwmon tree	2015-05-24 12:48:12 -07:00
mbcs.c
mbcs.h
mem.c	switch drivers/char/mem.c to ->read_iter/->write_iter	2015-04-11 22:29:40 -04:00
misc.c	char: make misc_deregister a void function	2015-08-05 10:35:49 -07:00
mmtimer.c
mspec.c	char: Use vma_pages() to replace (vm_end - vm_start) >> PAGE_SHIFT	2013-05-21 10:07:54 -07:00
nsc_gpio.c
nvram.c	char/nvram: Use bitwise OR to obtain Atari video mode data	2015-08-05 13:30:16 -07:00
nwbutton.c	char: nwbutton: open-code interruptible_sleep_on	2014-01-08 15:29:52 -08:00
nwbutton.h
nwflash.c
pc8736x_gpio.c
ppdev.c
ps3flash.c	ps3flash: switch to generic_file_llseek_size()	2013-06-29 12:57:33 +04:00
random.c	random: Remove kernel blocking API	2015-06-10 19:14:04 +08:00
raw.c	writeback: separate out include/linux/backing-dev-defs.h	2015-06-02 08:33:34 -06:00
rtc.c	various char drivers: remove deprecated IRQF_DISABLED	2013-10-16 12:36:10 -07:00
scx200_gpio.c
snsc_event.c	various char drivers: remove deprecated IRQF_DISABLED	2013-10-16 12:36:10 -07:00
snsc.c	drivers/char: make SGI snsc.c driver explicitly non-modular	2015-09-20 19:32:35 -07:00
snsc.h
sonypi.c	char: drop owner assignment from platform_drivers	2014-10-20 16:20:19 +02:00
tb0219.c	char: drop owner assignment from platform_drivers	2014-10-20 16:20:19 +02:00
tile-srom.c	fs: move struct kiocb to fs.h	2015-03-25 20:28:11 -04:00
tlclk.c	tlclk: remove deprecated IRQF_DISABLED	2013-10-16 12:36:10 -07:00
toshiba.c	toshiba laptop: replace ioremap_cache with ioremap	2015-08-05 17:26:00 -07:00
ttyprintk.c	ttyprintk: Allow built as a module	2014-04-16 14:21:06 -07:00
uv_mmtimer.c
virtio_console.c	virtio_console: silence a static checker warning	2015-05-24 12:24:35 -07:00