linux_dsm_epyc7002/drivers/thunderbolt
Mika Westerberg 600c0849cf thunderbolt: Fix use-after-free in remove_unplugged_switch()
Paulian reported a crash that happens when a dock is unplugged during
hibernation:

[78436.228217] thunderbolt 0-1: device disconnected
[78436.228365] BUG: kernel NULL pointer dereference, address: 00000000000001e0
...
[78436.228397] RIP: 0010:icm_free_unplugged_children+0x109/0x1a0
...
[78436.228432] Call Trace:
[78436.228439]  icm_rescan_work+0x24/0x30
[78436.228444]  process_one_work+0x1a3/0x3a0
[78436.228449]  worker_thread+0x30/0x370
[78436.228454]  ? process_one_work+0x3a0/0x3a0
[78436.228457]  kthread+0x13d/0x160
[78436.228461]  ? kthread_park+0x90/0x90
[78436.228465]  ret_from_fork+0x1f/0x30

This happens because remove_unplugged_switch() calls tb_switch_remove()
that releases the memory pointed by sw so the following lines reference
to a memory that might be released already.

Fix this by saving pointer to the parent device before calling
tb_switch_remove().

Reported-by: Paulian Bogdan Marinca <paulian@marinca.net>
Fixes: 4f7c2e0d87 ("thunderbolt: Make sure device runtime resume completes before taking domain lock")
Cc: stable@vger.kernel.org
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2020-11-19 17:44:10 +03:00
..
acpi.c
cap.c
ctl.c
ctl.h
debugfs.c thunderbolt: Add uaccess dependency to debugfs interface 2020-11-05 13:32:46 +03:00
dma_port.c
dma_port.h
domain.c
eeprom.c
icm.c thunderbolt: Fix use-after-free in remove_unplugged_switch() 2020-11-19 17:44:10 +03:00
Kconfig
lc.c
Makefile
nhi_ops.c
nhi_regs.h
nhi.c thunderbolt: Add support for Intel Tiger Lake-H 2020-11-06 16:39:11 +03:00
nhi.h thunderbolt: Add support for Intel Tiger Lake-H 2020-11-06 16:39:11 +03:00
nvm.c
path.c
property.c
quirks.c
retimer.c
sb_regs.h
switch.c
tb_msgs.h
tb_regs.h
tb.c
tb.h thunderbolt: Add support for Intel Tiger Lake-H 2020-11-06 16:39:11 +03:00
test.c
tmu.c
tunnel.c
tunnel.h
usb4.c thunderbolt: Only configure USB4 wake for lane 0 adapters 2020-11-05 13:32:53 +03:00
xdomain.c