mirror of
https://github.com/AuxXxilium/linux_dsm_epyc7002.git
synced 2025-03-09 19:53:17 +07:00
a1930a9877
Clang warns:
drivers/isdn/hisax/hfc_pci.c:131:34: error: if statement has empty body
[-Werror,-Wempty-body]
if (Read_hfc(cs, HFCPCI_INT_S1));
^
drivers/isdn/hisax/hfc_pci.c:131:34: note: put the semicolon on a
separate line to silence this warning
In my attempt to hide the warnings because I thought they didn't serve
any purpose[1], Masahiro Yamada pointed out that {Read,Write}_hfc in
hci_pci.c should be using a standard register access method; otherwise,
the compiler will just remove the if statements.
For hfc_pci, use the versions of {Read,Write}_hfc found in
drivers/isdn/hardware/mISDN/hfc_pCI.h while converting pci_io to be
'void __iomem *' (and clean up ioremap) then remove the empty if
statements.
For hfc_sx, {Read,Write}_hfc are already use a proper register accessor
(inb, outb) so just remove the unnecessary if statements.
[1]: https://lore.kernel.org/lkml/20181016021454.11953-1-natechancellor@gmail.com/
Link: https://github.com/ClangBuiltLinux/linux/issues/66
Suggested-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
|
||
|---|---|---|
| .. | ||
| amd7930_fn.c | ||
| amd7930_fn.h | ||
| arcofi.c | ||
| arcofi.h | ||
| asuscom.c | ||
| avm_a1.c | ||
| avm_a1p.c | ||
| avm_pci.c | ||
| avma1_cs.c | ||
| bkm_a4t.c | ||
| bkm_a8.c | ||
| bkm_ax.h | ||
| callc.c | ||
| config.c | ||
| diva.c | ||
| elsa_cs.c | ||
| elsa_ser.c | ||
| elsa.c | ||
| enternow_pci.c | ||
| fsm.c | ||
| fsm.h | ||
| gazel.c | ||
| hfc4s8s_l1.c | ||
| hfc4s8s_l1.h | ||
| hfc_2bds0.c | ||
| hfc_2bds0.h | ||
| hfc_2bs0.c | ||
| hfc_2bs0.h | ||
| hfc_pci.c | ||
| hfc_pci.h | ||
| hfc_sx.c | ||
| hfc_sx.h | ||
| hfc_usb.c | ||
| hfc_usb.h | ||
| hfcscard.c | ||
| hisax_cfg.h | ||
| hisax_debug.h | ||
| hisax_fcpcipnp.c | ||
| hisax_fcpcipnp.h | ||
| hisax_if.h | ||
| hisax_isac.c | ||
| hisax_isac.h | ||
| hisax.h | ||
| hscx_irq.c | ||
| hscx.c | ||
| hscx.h | ||
| icc.c | ||
| icc.h | ||
| ipac.h | ||
| ipacx.c | ||
| ipacx.h | ||
| isac.c | ||
| isac.h | ||
| isar.c | ||
| isar.h | ||
| isdnl1.c | ||
| isdnl1.h | ||
| isdnl2.c | ||
| isdnl2.h | ||
| isdnl3.c | ||
| isdnl3.h | ||
| isurf.c | ||
| ix1_micro.c | ||
| jade_irq.c | ||
| jade.c | ||
| jade.h | ||
| Kconfig | ||
| l3_1tr6.c | ||
| l3_1tr6.h | ||
| l3dss1.c | ||
| l3dss1.h | ||
| l3ni1.c | ||
| l3ni1.h | ||
| lmgr.c | ||
| Makefile | ||
| mic.c | ||
| netjet.c | ||
| netjet.h | ||
| niccy.c | ||
| nj_s.c | ||
| nj_u.c | ||
| q931.c | ||
| s0box.c | ||
| saphir.c | ||
| sedlbauer_cs.c | ||
| sedlbauer.c | ||
| sportster.c | ||
| st5481_b.c | ||
| st5481_d.c | ||
| st5481_init.c | ||
| st5481_usb.c | ||
| st5481.h | ||
| tei.c | ||
| teleint.c | ||
| teles0.c | ||
| teles3.c | ||
| teles_cs.c | ||
| telespci.c | ||
| w6692.c | ||
| w6692.h | ||