mirror of
https://github.com/AuxXxilium/linux_dsm_epyc7002.git
synced 2024-12-28 11:18:45 +07:00
960de2cff4
When setting a control directly on a subdev node the VSP1 driver doesn't guarantee that the device is powered on. This leads to crashes when the control handlers writes to hardware registers. One easy way to fix this is to ensure that the device gets powered on when a subdev node is opened. However, this consumes power unnecessarily, as there's no need to power the device on when setting formats on the pipeline. Furthermore, control handler setup at entity init time suffers from the same problem as the device isn't powered on easier. Fix this by extend the entity base object to setup the control handler automatically when starting the stream. Entities must then skip writing to registers in the set control handler when not streaming, which can be tested with the new vsp1_entity_is_streaming() helper function. Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
103 lines
2.7 KiB
C
103 lines
2.7 KiB
C
/*
|
|
* vsp1_entity.h -- R-Car VSP1 Base Entity
|
|
*
|
|
* Copyright (C) 2013-2014 Renesas Electronics Corporation
|
|
*
|
|
* Contact: Laurent Pinchart (laurent.pinchart@ideasonboard.com)
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*/
|
|
#ifndef __VSP1_ENTITY_H__
|
|
#define __VSP1_ENTITY_H__
|
|
|
|
#include <linux/list.h>
|
|
#include <linux/mutex.h>
|
|
|
|
#include <media/v4l2-subdev.h>
|
|
|
|
struct vsp1_device;
|
|
struct vsp1_video;
|
|
|
|
enum vsp1_entity_type {
|
|
VSP1_ENTITY_BRU,
|
|
VSP1_ENTITY_HSI,
|
|
VSP1_ENTITY_HST,
|
|
VSP1_ENTITY_LIF,
|
|
VSP1_ENTITY_LUT,
|
|
VSP1_ENTITY_RPF,
|
|
VSP1_ENTITY_SRU,
|
|
VSP1_ENTITY_UDS,
|
|
VSP1_ENTITY_WPF,
|
|
};
|
|
|
|
/*
|
|
* struct vsp1_route - Entity routing configuration
|
|
* @type: Entity type this routing entry is associated with
|
|
* @index: Entity index this routing entry is associated with
|
|
* @reg: Output routing configuration register
|
|
* @inputs: Target node value for each input
|
|
*
|
|
* Each $vsp1_route entry describes routing configuration for the entity
|
|
* specified by the entry's @type and @index. @reg indicates the register that
|
|
* holds output routing configuration for the entity, and the @inputs array
|
|
* store the target node value for each input of the entity.
|
|
*/
|
|
struct vsp1_route {
|
|
enum vsp1_entity_type type;
|
|
unsigned int index;
|
|
unsigned int reg;
|
|
unsigned int inputs[4];
|
|
};
|
|
|
|
struct vsp1_entity {
|
|
struct vsp1_device *vsp1;
|
|
|
|
enum vsp1_entity_type type;
|
|
unsigned int index;
|
|
const struct vsp1_route *route;
|
|
|
|
struct list_head list_dev;
|
|
struct list_head list_pipe;
|
|
|
|
struct media_pad *pads;
|
|
unsigned int source_pad;
|
|
|
|
struct media_entity *sink;
|
|
unsigned int sink_pad;
|
|
|
|
struct v4l2_subdev subdev;
|
|
struct v4l2_mbus_framefmt *formats;
|
|
|
|
struct vsp1_video *video;
|
|
|
|
struct mutex lock; /* Protects the streaming field */
|
|
bool streaming;
|
|
};
|
|
|
|
static inline struct vsp1_entity *to_vsp1_entity(struct v4l2_subdev *subdev)
|
|
{
|
|
return container_of(subdev, struct vsp1_entity, subdev);
|
|
}
|
|
|
|
int vsp1_entity_init(struct vsp1_device *vsp1, struct vsp1_entity *entity,
|
|
unsigned int num_pads);
|
|
void vsp1_entity_destroy(struct vsp1_entity *entity);
|
|
|
|
extern const struct v4l2_subdev_internal_ops vsp1_subdev_internal_ops;
|
|
extern const struct media_entity_operations vsp1_media_ops;
|
|
|
|
struct v4l2_mbus_framefmt *
|
|
vsp1_entity_get_pad_format(struct vsp1_entity *entity,
|
|
struct v4l2_subdev_fh *fh,
|
|
unsigned int pad, u32 which);
|
|
void vsp1_entity_init_formats(struct v4l2_subdev *subdev,
|
|
struct v4l2_subdev_fh *fh);
|
|
|
|
bool vsp1_entity_is_streaming(struct vsp1_entity *entity);
|
|
int vsp1_entity_set_streaming(struct vsp1_entity *entity, bool streaming);
|
|
|
|
#endif /* __VSP1_ENTITY_H__ */
|