mirror of
https://github.com/AuxXxilium/linux_dsm_epyc7002.git
synced 2024-12-18 19:26:54 +07:00
7d7b25d05e
The SND_SOC_DAVINCI_MCASP driver can use either edma or sdma as
a back-end, and it takes the presence of the respective dma engine
drivers in the configuration as an indication to which ones should be
built. However, this is flawed in multiple ways:
- With CONFIG_TI_EDMA=m and CONFIG_SND_SOC_DAVINCI_MCASP=y,
is enabled as =m, and we get a link error:
sound/soc/ti/davinci-mcasp.o: In function `davinci_mcasp_probe':
davinci-mcasp.c:(.text+0x930): undefined reference to `edma_pcm_platform_register'
- When CONFIG_SND_SOC_DAVINCI_MCASP=m has already been selected by
another driver, the same link error appears even if CONFIG_TI_EDMA
is disabled
There are possibly other issues here, but it seems that the only reasonable
solution is to always build both SND_SOC_TI_EDMA_PCM and
SND_SOC_TI_SDMA_PCM as a dependency here. Both are fairly small and
do not have any other compile-time dependencies, so the cost is
very small, and makes the configuration stage much more consistent.
Fixes:
|
||
|---|---|---|
| .. | ||
| ams-delta.c | ||
| davinci-evm.c | ||
| davinci-i2s.c | ||
| davinci-i2s.h | ||
| davinci-mcasp.c | ||
| davinci-mcasp.h | ||
| davinci-vcif.c | ||
| edma-pcm.c | ||
| edma-pcm.h | ||
| Kconfig | ||
| Makefile | ||
| n810.c | ||
| omap3pandora.c | ||
| omap-abe-twl6040.c | ||
| omap-dmic.c | ||
| omap-dmic.h | ||
| omap-hdmi.c | ||
| omap-mcbsp-priv.h | ||
| omap-mcbsp-st.c | ||
| omap-mcbsp.c | ||
| omap-mcbsp.h | ||
| omap-mcpdm.c | ||
| omap-mcpdm.h | ||
| omap-twl4030.c | ||
| osk5912.c | ||
| rx51.c | ||
| sdma-pcm.c | ||
| sdma-pcm.h | ||