linux_dsm_epyc7002/drivers/net/ethernet/intel
Jacob Keller b3ccbbce1e i40e: fix i40e_ptp_adjtime when given a negative delta
Commit 0ac30ce433 ("i40e: fix up 32 bit timespec references",
2017-07-26) claims to be cleaning up references to 32-bit timespecs.

The actual contents of the commit make no sense, as it converts a call
to timespec64_add into timespec64_add_ns. This would seem ok, if (a) the
change was documented in the commit message, and (b) timespec64_add_ns
supported negative numbers.

timespec64_add_ns doesn't work with signed deltas, because the
implementation is based around iter_div_u64_rem. This change resulted in
a regression where i40e_ptp_adjtime would interpret small negative
adjustments as large positive additions, resulting in incorrect
behavior.

This commit doesn't appear to fix anything, is not well explained, and
introduces a bug, so lets just revert it.

Reverts: 0ac30ce433 ("i40e: fix up 32 bit timespec references", 2017-07-26)
Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
2019-03-26 15:14:04 -07:00
..
e1000 cross-tree: phase out dma_zalloc_coherent() 2019-01-08 07:58:37 -05:00
e1000e e1000e: Fix -Wformat-truncation warnings 2019-02-23 13:44:57 -08:00
fm10k fm10k: use struct_size() in kzalloc() 2019-02-08 22:57:28 -08:00
i40e i40e: fix i40e_ptp_adjtime when given a negative delta 2019-03-26 15:14:04 -07:00
iavf flow_offload: add flow_rule and flow_match structures and use them 2019-02-06 10:38:25 -08:00
ice ice: fix overlong string, update stats output 2019-02-25 08:56:02 -08:00
igb igb: use struct_size() helper 2019-02-08 23:03:48 -08:00
igbvf ethernet/intel: consolidate NAPI and NAPI exit 2018-11-21 10:35:23 -08:00
igc igc: Use struct_size() helper 2019-02-08 23:03:48 -08:00
ixgb cross-tree: phase out dma_zalloc_coherent() 2019-01-08 07:58:37 -05:00
ixgbe mm: replace all open encodings for NUMA_NO_NODE 2019-03-05 21:07:14 -08:00
ixgbevf xfrm: prefer secpath_set over secpath_dup 2018-12-19 11:21:38 -08:00
e100.c e100: Fix passing zero to 'PTR_ERR' warning in e100_load_ucode_wait 2018-12-20 11:54:27 -08:00
Kconfig ixgbe: fix Kconfig when driver is not a module 2019-01-04 14:02:16 -08:00
Makefile igc: Add skeletal frame for Intel(R) 2.5G Ethernet Controller support 2018-10-17 12:14:54 -07:00