linux_dsm_epyc7002/drivers/net/wireless/ath/wil6210
Gustavo A. R. Silva 104f3d95d8 wil6210: Replace zero-length array with flexible-array
The current codebase makes use of the zero-length array language
extension to the C90 standard, but the preferred mechanism to declare
variable-length types such as these ones is a flexible array member[1][2],
introduced in C99:

struct foo {
        int stuff;
        struct boo array[];
};

By making use of the mechanism above, we will get a compiler warning
in case the flexible array does not occur last in the structure, which
will help us prevent some kind of undefined behavior bugs from being
inadvertently introduced[3] to the codebase from now on.

Also, notice that, dynamic memory allocations won't be affected by
this change:

"Flexible array members have incomplete type, and so the sizeof operator
may not be applied. As a quirk of the original implementation of
zero-length arrays, sizeof evaluates to zero."[1]

sizeof(flexible-array-member) triggers a warning because flexible array
members have incomplete type[1]. There are some instances of code in
which the sizeof operator is being incorrectly/erroneously applied to
zero-length arrays and the result is zero. Such instances may be hiding
some bugs. So, this work (flexible-array member conversions) will also
help to get completely rid of those sorts of issues.

This issue was found with the help of Coccinelle.

[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit 7649773293 ("cxgb3/l2t: Fix undefined behaviour")

Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20200507151120.GA4469@embeddedor
2020-05-12 10:35:16 +03:00
..
boot_loader.h
cfg80211.c
debug.c
debugfs.c
ethtool.c
fw_inc.c
fw.c
fw.h
interrupt.c
Kconfig
main.c
Makefile
netdev.c
p2p.c
pcie_bus.c
pm.c
pmc.c
pmc.h
rx_reorder.c
trace.c
trace.h
txrx_edma.c
txrx_edma.h
txrx.c
txrx.h
wil6210.h
wil_crash_dump.c
wil_platform.c
wil_platform.h
wmi.c
wmi.h