Peilin Ye 3c4f850e84 xdp: Prevent kernel-infoleak in xsk_getsockopt() ... xsk_getsockopt() is copying uninitialized stack memory to userspace when 'extra_stats' is 'false'. Fix it. Doing '= {};' is sufficient since currently 'struct xdp_statistics' is defined as follows: struct xdp_statistics { __u64 rx_dropped; __u64 rx_invalid_descs; __u64 tx_invalid_descs; __u64 rx_ring_full; __u64 rx_fill_ring_empty_descs; __u64 tx_ring_empty_descs; }; When being copied to the userspace, 'stats' will not contain any uninitialized 'holes' between struct fields. Fixes: 8aa5a33578 ("xsk: Add new statistics") Suggested-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Peilin Ye <yepeilin.cs@gmail.com> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net> Acked-by: Björn Töpel <bjorn.topel@intel.com> Acked-by: Song Liu <songliubraving@fb.com> Acked-by: Arnd Bergmann <arnd@arndb.de> Link: https://lore.kernel.org/bpf/20200728053604.404631-1-yepeilin.cs@gmail.com		2020-07-28 12:50:15 +02:00
..
Kconfig	treewide: Add SPDX license identifier - Makefile/Kconfig	2019-05-21 10:50:46 +02:00
Makefile	xsk: Introduce AF_XDP buffer allocation API	2020-05-21 17:31:26 -07:00
xdp_umem.c	mmap locking API: use coccinelle to convert mmap_sem rwsem call sites	2020-06-09 09:39:14 -07:00
xdp_umem.h	xsk: Move driver interface to xdp_sock_drv.h	2020-05-21 17:31:26 -07:00
xsk_buff_pool.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next	2020-07-13 18:04:05 -07:00
xsk_diag.c	xsk: Add xdp statistics to xsk_diag	2020-07-13 15:32:56 -07:00
xsk_queue.c	xsk: Remove MEM_TYPE_ZERO_COPY and corresponding code	2020-05-21 17:31:27 -07:00
xsk_queue.h	xsk: Add new statistics	2020-07-13 15:32:56 -07:00
xsk.c	xdp: Prevent kernel-infoleak in xsk_getsockopt()	2020-07-28 12:50:15 +02:00
xsk.h	xsk: Move defines only used by AF_XDP internals to xsk.h	2020-05-21 17:31:26 -07:00
xskmap.c	bpf: Set map_btf_{name, id} for all map types	2020-06-22 22:22:58 +02:00