Enric Balletbo i Serra a8f62f1830 Revert "thermal: mediatek: fix register index error" ... This reverts commit eb9aecd90d The above patch is supposed to fix a register index error on mt2701. It is not clear if the problem solved is a hang or just an invalid value returned, my guess is the second. The patch introduces, though, a new hang on MT8173 device making them unusable. So, seems reasonable, revert the patch because introduces a worst issue. The reason I send a revert instead of trying to fix the issue for MT8173 is because the information needed to fix the issue is in the datasheet and is not public. So I am not really able to fix it. Fixes the following bug when CONFIG_MTK_THERMAL is set on MT8173 devices. [ 2.222488] Unable to handle kernel paging request at virtual address ffff8000125f5001 [ 2.230421] Mem abort info: [ 2.233207] ESR = 0x96000021 [ 2.236261] EC = 0x25: DABT (current EL), IL = 32 bits [ 2.241571] SET = 0, FnV = 0 [ 2.244623] EA = 0, S1PTW = 0 [ 2.247762] Data abort info: [ 2.250640] ISV = 0, ISS = 0x00000021 [ 2.254473] CM = 0, WnR = 0 [ 2.257544] swapper pgtable: 4k pages, 48-bit VAs, pgdp=0000000041850000 [ 2.264251] [ffff8000125f5001] pgd=000000013ffff003, pud=000000013fffe003, pmd=000000013fff9003, pte=006800001100b707 [ 2.274867] Internal error: Oops: 96000021 [#1] PREEMPT SMP [ 2.280432] Modules linked in: [ 2.283483] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 5.7.0-rc6+ #162 [ 2.289914] Hardware name: Google Elm (DT) [ 2.294003] pstate: 20000005 (nzCv daif -PAN -UAO) [ 2.298792] pc : mtk_read_temp+0xb8/0x1c8 [ 2.302793] lr : mtk_read_temp+0x7c/0x1c8 [ 2.306794] sp : ffff80001003b930 [ 2.310100] x29: ffff80001003b930 x28: 0000000000000000 [ 2.315404] x27: 0000000000000002 x26: ffff0000f9550b10 [ 2.320709] x25: ffff0000f9550a80 x24: 0000000000000090 [ 2.326014] x23: ffff80001003ba24 x22: 00000000610344c0 [ 2.331318] x21: 0000000000002710 x20: 00000000000001f4 [ 2.336622] x19: 0000000000030d40 x18: ffff800011742ec0 [ 2.341926] x17: 0000000000000001 x16: 0000000000000001 [ 2.347230] x15: ffffffffffffffff x14: ffffff0000000000 [ 2.352535] x13: ffffffffffffffff x12: 0000000000000028 [ 2.357839] x11: 0000000000000003 x10: ffff800011295ec8 [ 2.363143] x9 : 000000000000291b x8 : 0000000000000002 [ 2.368447] x7 : 00000000000000a8 x6 : 0000000000000004 [ 2.373751] x5 : 0000000000000000 x4 : ffff800011295cb0 [ 2.379055] x3 : 0000000000000002 x2 : ffff8000125f5001 [ 2.384359] x1 : 0000000000000001 x0 : ffff0000f9550a80 [ 2.389665] Call trace: [ 2.392105] mtk_read_temp+0xb8/0x1c8 [ 2.395760] of_thermal_get_temp+0x2c/0x40 [ 2.399849] thermal_zone_get_temp+0x78/0x160 [ 2.404198] thermal_zone_device_update.part.0+0x3c/0x1f8 [ 2.409589] thermal_zone_device_update+0x34/0x48 [ 2.414286] of_thermal_set_mode+0x58/0x88 [ 2.418375] thermal_zone_of_sensor_register+0x1a8/0x1d8 [ 2.423679] devm_thermal_zone_of_sensor_register+0x64/0xb0 [ 2.429242] mtk_thermal_probe+0x690/0x7d0 [ 2.433333] platform_drv_probe+0x5c/0xb0 [ 2.437335] really_probe+0xe4/0x448 [ 2.440901] driver_probe_device+0xe8/0x140 [ 2.445077] device_driver_attach+0x7c/0x88 [ 2.449252] __driver_attach+0xac/0x178 [ 2.453082] bus_for_each_dev+0x78/0xc8 [ 2.456909] driver_attach+0x2c/0x38 [ 2.460476] bus_add_driver+0x14c/0x230 [ 2.464304] driver_register+0x6c/0x128 [ 2.468131] __platform_driver_register+0x50/0x60 [ 2.472831] mtk_thermal_driver_init+0x24/0x30 [ 2.477268] do_one_initcall+0x50/0x298 [ 2.481098] kernel_init_freeable+0x1ec/0x264 [ 2.485450] kernel_init+0x1c/0x110 [ 2.488931] ret_from_fork+0x10/0x1c [ 2.492502] Code: f9401081 f9400402 b8a67821 8b010042 (b9400042) [ 2.498599] ---[ end trace e43e3105ed27dc99 ]--- [ 2.503367] Kernel panic - not syncing: Attempted to kill init! exitcode=0x0000000b [ 2.511020] SMP: stopping secondary CPUs [ 2.514941] Kernel Offset: disabled [ 2.518421] CPU features: 0x090002,25006005 [ 2.522595] Memory Limit: none [ 2.525644] ---[ end Kernel panic - not syncing: Attempted to kill init! exitcode=0x0000000b ]-- Cc: Michael Kao <michael.kao@mediatek.com> Fixes: eb9aecd90d ("thermal: mediatek: fix register index error") Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> Link: https://lore.kernel.org/r/20200707103412.1010823-1-enric.balletbo@collabora.com		2020-07-15 11:12:48 +02:00
..
accessibility	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
acpi	Merge branch 'acpi-sysfs'	2020-06-26 17:06:29 +02:00
amba	ARM: tegra: Replace zero-length array with flexible-array	2020-06-15 23:08:28 -05:00
android	binder: fix null deref of proc->context	2020-06-23 07:54:46 +02:00
ata	libata-5.8-2020-06-19	2020-06-19 13:09:40 -07:00
atm	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
auxdisplay	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
base	Power management fixes for 5.8-rc3	2020-06-26 12:32:11 -07:00
bcma
block	block-5.8-2020-06-19	2020-06-19 13:11:26 -07:00
bluetooth	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next	2020-06-03 16:27:18 -07:00
bus	Fixes for omaps for v5.8	2020-06-28 14:41:55 +02:00
cdrom	Merge branch 'work.sysctl' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2020-06-10 16:05:54 -07:00
char	Merge branch 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6	2020-06-21 10:01:03 -07:00
clk	clk: sifive: allocate sufficient memory for struct __prci_data	2020-06-25 15:04:13 -07:00
clocksource	clocksource/drivers/timer-riscv: Use per-CPU timer interrupt	2020-06-09 19:11:22 -07:00
connector	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
counter
cpufreq	cpufreq: intel_pstate: Add one more OOB control bit	2020-06-23 17:24:32 +02:00
cpuidle	cpuidle: Rearrange s2idle-specific idle state entry code	2020-06-25 13:52:53 +02:00
crypto	Merge branch 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6	2020-06-21 10:01:03 -07:00
dax	device-dax: add memory via add_memory_driver_managed()	2020-06-04 19:06:23 -07:00
dca
devfreq
dio	maccess: rename probe_kernel_{read,write} to copy_{from,to}_kernel_nofault	2020-06-17 10:57:41 -07:00
dma	dmaengine: tegra-apb: Replace zero-length array with flexible-array	2020-06-15 23:08:32 -05:00
dma-buf	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
edac	EDAC/amd64: Read back the scrub rate PCI register on F15h	2020-06-18 20:25:25 +02:00
eisa	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
extcon	extcon: arizona: Fix runtime PM imbalance on error	2020-05-29 17:36:02 +09:00
firewire	firewire: ohci: Replace zero-length array with flexible-array	2020-06-15 23:08:31 -05:00
firmware	ARM: SoC fixes for v5.8	2020-06-28 14:55:18 -07:00
fpga	FPGA Manager fixes for 5.8-rc1	2020-06-26 17:26:31 +02:00
fsi	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
gnss	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
gpio	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
gpu	Short summary of fixes pull (less than what git shortlog provides):	2020-06-26 13:49:17 +10:00
greybus	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
hid	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
hsi	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
hv	hyperv-next for 5.8	2020-06-03 15:00:05 -07:00
hwmon	Merge branch 'x86/entry' into ras/core	2020-06-11 15:17:57 +02:00
hwspinlock
hwtracing	stm class: Replace zero-length array with flexible-array	2020-06-15 23:08:32 -05:00
i2c	i2c: core: check returned size of emulated smbus block read	2020-06-26 10:18:35 +02:00
i3c
ide	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
idle
iio	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
infiniband	IB/hfi1: Add atomic triggered sleep/wakeup	2020-06-24 16:13:38 -03:00
input	maccess: rename probe_kernel_{read,write} to copy_{from,to}_kernel_nofault	2020-06-17 10:57:41 -07:00
interconnect	More power management updates for 5.8-rc1	2020-06-10 14:04:39 -07:00
iommu	iommu/vt-d: Fix misuse of iommu_domain_identity_map()	2020-06-23 10:08:32 +02:00
ipack	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
irqchip	clocksource/drivers/timer-riscv: Use per-CPU timer interrupt	2020-06-09 19:11:22 -07:00
isdn	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
leds	LEDs pull request for 5.8-rc1.	2020-06-04 11:03:45 -07:00
lightnvm	for-5.8/block-2020-06-01	2020-06-02 15:29:19 -07:00
macintosh	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
mailbox	mailbox: qcom: Add ipq6018 apcs compatible	2020-06-10 22:43:57 -05:00
mcb
md	- Quite a few DM zoned target fixes and a Zone append fix in DM core.	2020-06-27 08:57:16 -07:00
media	media: omap3isp: remove cacheflush.h	2020-06-26 00:27:37 -07:00
memory
memstick
message	scsi: mptscsih: Fix read sense data size	2020-06-24 00:23:17 -04:00
mfd	mfd: mt6360: Fix register driver NULL pointer by adding driver name	2020-06-16 09:32:43 +01:00
misc	habanalabs: increase h/w timer when checking idle	2020-06-24 12:35:23 +03:00
mmc	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
most
mtd	This pull request contains a single change for UBI:	2020-06-10 13:24:40 -07:00
mux
net	wil6210: account for napi_gro_receive never returning GRO_DROP	2020-06-25 16:16:21 -07:00
nfc	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
ntb	NTB: perf: Fix race condition when run with ntb_test	2020-06-05 20:02:09 -04:00
nubus
nvdimm	nvdimm/region: always show the 'align' attribute	2020-06-17 14:08:31 -07:00
nvme	nvme-multipath: fix bogus request queue reference put	2020-06-24 18:41:20 +02:00
nvmem
of	of: of_mdio: Correct loop scanning logic	2020-06-19 13:39:00 -07:00
opp	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
oprofile	oprofile: Replace zero-length array with flexible-array	2020-06-15 23:08:32 -05:00
parisc
parport	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
pci	Kbuild updates for v5.8 (2nd)	2020-06-13 13:29:16 -07:00
pcmcia	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
perf	arm64 merge window fixes for -rc1	2020-06-11 12:53:23 -07:00
phy	phy: samsung: Replace zero-length array with flexible-array	2020-06-15 23:08:32 -05:00
pinctrl	pinctrl: single: fix function name in documentation	2020-06-20 22:41:32 +02:00
platform	Kbuild updates for v5.8 (2nd)	2020-06-13 13:29:16 -07:00
pnp	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
power	power supply and reset changes for the v5.8 series	2020-06-10 11:28:35 -07:00
powercap	Kbuild updates for v5.8 (2nd)	2020-06-13 13:29:16 -07:00
pps	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
ps3
ptp	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
pwm	pwm: Add missing "CONFIG_" prefix	2020-06-04 19:09:28 +02:00
rapidio	rapidio: Replace zero-length array with flexible-array	2020-06-15 23:08:32 -05:00
ras
regulator	regulator: mt6358: Remove BROKEN dependency	2020-06-17 13:01:19 +01:00
remoteproc	remoteproc updates for v5.8	2020-06-08 13:01:08 -07:00
reset	Char/Misc driver patches for 5.8-rc1	2020-06-07 10:59:32 -07:00
rpmsg	remoteproc updates for v5.8	2020-06-08 13:01:08 -07:00
rtc	RTC for 5.8	2020-06-07 16:11:23 -07:00
s390	SCSI fixes on 20200627	2020-06-27 15:20:03 -07:00
sbus	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
scsi	scsi: lpfc: Avoid another null dereference in lpfc_sli4_hba_unset()	2020-06-23 23:56:52 -04:00
sfi	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
sh
siox
slimbus
soc	ARM: OMAP fixes for v5.8	2020-06-28 14:57:14 -07:00
soundwire
spi	spi: Fixes for v5.8	2020-06-22 09:49:59 -07:00
spmi
ssb
staging	Staging: rtl8723bs: prevent buffer overflow in update_sta_support_rate()	2020-06-16 21:25:38 +02:00
target	Kbuild updates for v5.8 (2nd)	2020-06-13 13:29:16 -07:00
tc
tee	mmap locking API: use coccinelle to convert mmap_sem rwsem call sites	2020-06-09 09:39:14 -07:00
thermal	Revert "thermal: mediatek: fix register index error"	2020-07-15 11:12:48 +02:00
thunderbolt	USB/PHY driver updates for 5.8-rc1	2020-06-07 09:42:16 -07:00
tty	kdb: Switch to use safer dbg_io_ops over console APIs	2020-06-26 15:40:16 +01:00
uio
usb	USB fixes for 5.8-rc3	2020-06-27 13:12:10 -07:00
vdpa	vdpa: fix typos in the comments for __vdpa_alloc_device()	2020-06-22 12:34:21 -04:00
vfio	vfio/pci: Fix SR-IOV VF handling with MMIO blocking	2020-06-25 11:04:23 -06:00
vhost	tools/virtio: Add --reset	2020-06-22 12:34:21 -04:00
video	Short summary of fixes pull (less than what git shortlog provides):	2020-06-26 13:49:17 +10:00
virt	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
virtio	virtio-mem: add memory via add_memory_driver_managed()	2020-06-22 12:34:21 -04:00
visorbus	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
vlynq
vme	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
w1	w1: Replace zero-length array with flexible-array	2020-06-15 23:08:32 -05:00
watchdog	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
xen	The X86 entry, exception and interrupt code rework	2020-06-13 10:05:47 -07:00
zorro	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
Kconfig
Makefile