mirror of
https://github.com/AuxXxilium/linux_dsm_epyc7002.git
synced 2024-12-23 18:25:51 +07:00
a679f58d05
When we return pages to the system, we ensure that they are marked as being in the CPU domain since any external access is uncontrolled and we must assume the worst. This means that we need to always flush the pages on acquisition if we need to use them on the GPU, and from the beginning have used set-domain. Set-domain is overkill for the purpose as it is a general synchronisation barrier, but our intent is to only flush the pages being swapped in. If we move that flush into the pages acquisition phase, we know then that when we have obj->mm.pages, they are coherent with the GPU and need only maintain that status without resorting to heavy handed use of set-domain. The principle knock-on effect for userspace is through mmap-gtt pagefaulting. Our uAPI has always implied that the GTT mmap was async (especially as when any pagefault occurs is unpredicatable to userspace) and so userspace had to apply explicit domain control itself (set-domain). However, swapping is transparent to the kernel, and so on first fault we need to acquire the pages and make them coherent for access through the GTT. Our use of set-domain here leaks into the uABI that the first pagefault was synchronous. This is unintentional and baring a few igt should be unoticed, nevertheless we bump the uABI version for mmap-gtt to reflect the change in behaviour. Another implication of the change is that gem_create() is presumed to create an object that is coherent with the CPU and is in the CPU write domain, so a set-domain(CPU) following a gem_create() would be a minor operation that merely checked whether we could allocate all pages for the object. On applying this change, a set-domain(CPU) causes a clflush as we acquire the pages. This will have a small impact on mesa as we move the clflush here on !llc from execbuf time to create, but that should have minimal performance impact as the same clflush exists but is now done early and because of the clflush issue, userspace recycles bo and so should resist allocating fresh objects. Internally, the presumption that objects are created in the CPU write-domain and remain so through writes to obj->mm.mapping is more prevalent than I expected; but easy enough to catch and apply a manual flush. For the future, we should push the page flush from the central set_pages() into the callers so that we can more finely control when it is applied, but for now doing it one location is easier to validate, at the cost of sometimes flushing when there is no need. Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Cc: Matthew Auld <matthew.william.auld@gmail.com> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com> Cc: Antonio Argenziano <antonio.argenziano@intel.com> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> Reviewed-by: Matthew Auld <matthew.william.auld@gmail.com> Link: https://patchwork.freedesktop.org/patch/msgid/20190321161908.8007-1-chris@chris-wilson.co.uk |
||
|---|---|---|
| .. | ||
| huge_gem_object.c | ||
| huge_gem_object.h | ||
| huge_pages.c | ||
| i915_active.c | ||
| i915_gem_coherency.c | ||
| i915_gem_context.c | ||
| i915_gem_dmabuf.c | ||
| i915_gem_evict.c | ||
| i915_gem_gtt.c | ||
| i915_gem_object.c | ||
| i915_gem.c | ||
| i915_live_selftests.h | ||
| i915_mock_selftests.h | ||
| i915_random.c | ||
| i915_random.h | ||
| i915_request.c | ||
| i915_selftest.c | ||
| i915_sw_fence.c | ||
| i915_syncmap.c | ||
| i915_timeline.c | ||
| i915_vma.c | ||
| igt_flush_test.c | ||
| igt_flush_test.h | ||
| igt_live_test.c | ||
| igt_live_test.h | ||
| igt_reset.c | ||
| igt_reset.h | ||
| igt_spinner.c | ||
| igt_spinner.h | ||
| igt_wedge_me.h | ||
| intel_engine_cs.c | ||
| intel_guc.c | ||
| intel_hangcheck.c | ||
| intel_lrc.c | ||
| intel_uncore.c | ||
| intel_workarounds.c | ||
| lib_sw_fence.c | ||
| lib_sw_fence.h | ||
| mock_context.c | ||
| mock_context.h | ||
| mock_dmabuf.c | ||
| mock_dmabuf.h | ||
| mock_drm.c | ||
| mock_drm.h | ||
| mock_engine.c | ||
| mock_engine.h | ||
| mock_gem_device.c | ||
| mock_gem_device.h | ||
| mock_gem_object.h | ||
| mock_gtt.c | ||
| mock_gtt.h | ||
| mock_request.c | ||
| mock_request.h | ||
| mock_timeline.c | ||
| mock_timeline.h | ||
| mock_uncore.c | ||
| mock_uncore.h | ||
| scatterlist.c | ||