mirror of
https://github.com/AuxXxilium/linux_dsm_epyc7002.git
synced 2025-01-15 17:07:07 +07:00
12dfa2f68a
When connecting to AP, mac80211 asks driver to enter and leave PS quickly,
but driver deinit doesn't wait for delayed work complete when entering PS,
then driver reinit procedure and delay work are running simultaneously.
This will cause unpredictable kernel oops or crash like
rtl8723be: error H2C cmd because of Fw download fail!!!
WARNING: CPU: 3 PID: 159 at drivers/net/wireless/realtek/rtlwifi/
rtl8723be/fw.c:227 rtl8723be_fill_h2c_cmd+0x182/0x510 [rtl8723be]
CPU: 3 PID: 159 Comm: kworker/3:2 Tainted: G O 4.16.13-2-ARCH #1
Hardware name: ASUSTeK COMPUTER INC. X556UF/X556UF, BIOS X556UF.406
10/21/2016
Workqueue: rtl8723be_pci rtl_c2hcmd_wq_callback [rtlwifi]
RIP: 0010:rtl8723be_fill_h2c_cmd+0x182/0x510 [rtl8723be]
RSP: 0018:ffffa6ab01e1bd70 EFLAGS: 00010282
RAX: 0000000000000000 RBX: ffffa26069071520 RCX: 0000000000000001
RDX: 0000000080000001 RSI: ffffffff8be70e9c RDI: 00000000ffffffff
RBP: 0000000000000000 R08: 0000000000000048 R09: 0000000000000348
R10: 0000000000000000 R11: 0000000000000001 R12: 0000000000000000
R13: ffffa26069071520 R14: 0000000000000000 R15: ffffa2607d205f70
FS: 0000000000000000(0000) GS:ffffa26081d80000(0000) knlGS:000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00000443b39d3000 CR3: 000000037700a005 CR4: 00000000003606e0
Call Trace:
? halbtc_send_bt_mp_operation.constprop.17+0xd5/0xe0 [btcoexist]
? ex_btc8723b1ant_bt_info_notify+0x3b8/0x820 [btcoexist]
? rtl_c2hcmd_launcher+0xab/0x110 [rtlwifi]
? process_one_work+0x1d1/0x3b0
? worker_thread+0x2b/0x3d0
? process_one_work+0x3b0/0x3b0
? kthread+0x112/0x130
? kthread_create_on_node+0x60/0x60
? ret_from_fork+0x35/0x40
Code: 00 76 b4 e9 e2 fe ff ff 4c 89 ee 4c 89 e7 e8 56 22 86 ca e9 5e ...
This patch ensures all delayed works done before entering PS to satisfy
our expectation, so use cancel_delayed_work_sync() instead. An exception
is delayed work ips_nic_off_wq because running task may be itself, so add
a parameter ips_wq to deinit function to handle this case.
This issue is reported and fixed in below threads:
https://github.com/lwfinger/rtlwifi_new/issues/367
https://github.com/lwfinger/rtlwifi_new/issues/366
Tested-by: Evgeny Kapun <abacabadabacaba@gmail.com> # 8723DE
Tested-by: Shivam Kakkar <shivam543@gmail.com> # 8723BE on 4.18-rc1
Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
Fixes: cceb0a5973 ("rtlwifi: Add work queue for c2h cmd.")
Cc: Stable <stable@vger.kernel.org> # 4.11+
Reviewed-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
184 lines
7.3 KiB
C
184 lines
7.3 KiB
C
/******************************************************************************
|
|
*
|
|
* Copyright(c) 2009-2012 Realtek Corporation.
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify it
|
|
* under the terms of version 2 of the GNU General Public License as
|
|
* published by the Free Software Foundation.
|
|
*
|
|
* This program is distributed in the hope that it will be useful, but WITHOUT
|
|
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
|
|
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
|
|
* more details.
|
|
*
|
|
* The full GNU General Public License is included in this distribution in the
|
|
* file called LICENSE.
|
|
*
|
|
* Contact Information:
|
|
* wlanfae <wlanfae@realtek.com>
|
|
* Realtek Corporation, No. 2, Innovation Road II, Hsinchu Science Park,
|
|
* Hsinchu 300, Taiwan.
|
|
*
|
|
* Larry Finger <Larry.Finger@lwfinger.net>
|
|
*
|
|
*****************************************************************************/
|
|
|
|
#ifndef __RTL_BASE_H__
|
|
#define __RTL_BASE_H__
|
|
|
|
enum ap_peer {
|
|
PEER_UNKNOWN = 0,
|
|
PEER_RTL = 1,
|
|
PEER_RTL_92SE = 2,
|
|
PEER_BROAD = 3,
|
|
PEER_RAL = 4,
|
|
PEER_ATH = 5,
|
|
PEER_CISCO = 6,
|
|
PEER_MARV = 7,
|
|
PEER_AIRGO = 9,
|
|
PEER_MAX = 10,
|
|
};
|
|
|
|
#define RTL_DUMMY_OFFSET 0
|
|
#define RTL_DUMMY_UNIT 8
|
|
#define RTL_TX_DUMMY_SIZE (RTL_DUMMY_OFFSET * RTL_DUMMY_UNIT)
|
|
#define RTL_TX_DESC_SIZE 32
|
|
#define RTL_TX_HEADER_SIZE (RTL_TX_DESC_SIZE + RTL_TX_DUMMY_SIZE)
|
|
|
|
#define MAX_BIT_RATE_40MHZ_MCS15 300 /* Mbps */
|
|
#define MAX_BIT_RATE_40MHZ_MCS7 150 /* Mbps */
|
|
|
|
#define MAX_BIT_RATE_SHORT_GI_2NSS_80MHZ_MCS9 867 /* Mbps */
|
|
#define MAX_BIT_RATE_SHORT_GI_2NSS_80MHZ_MCS7 650 /* Mbps */
|
|
#define MAX_BIT_RATE_LONG_GI_2NSS_80MHZ_MCS9 780 /* Mbps */
|
|
#define MAX_BIT_RATE_LONG_GI_2NSS_80MHZ_MCS7 585 /* Mbps */
|
|
|
|
#define MAX_BIT_RATE_SHORT_GI_1NSS_80MHZ_MCS9 434 /* Mbps */
|
|
#define MAX_BIT_RATE_SHORT_GI_1NSS_80MHZ_MCS7 325 /* Mbps */
|
|
#define MAX_BIT_RATE_LONG_GI_1NSS_80MHZ_MCS9 390 /* Mbps */
|
|
#define MAX_BIT_RATE_LONG_GI_1NSS_80MHZ_MCS7 293 /* Mbps */
|
|
|
|
#define FRAME_OFFSET_FRAME_CONTROL 0
|
|
#define FRAME_OFFSET_DURATION 2
|
|
#define FRAME_OFFSET_ADDRESS1 4
|
|
#define FRAME_OFFSET_ADDRESS2 10
|
|
#define FRAME_OFFSET_ADDRESS3 16
|
|
#define FRAME_OFFSET_SEQUENCE 22
|
|
#define FRAME_OFFSET_ADDRESS4 24
|
|
#define MAX_LISTEN_INTERVAL 10
|
|
#define MAX_RATE_TRIES 4
|
|
|
|
#define SET_80211_HDR_FRAME_CONTROL(_hdr, _val) \
|
|
WRITEEF2BYTE(_hdr, _val)
|
|
#define SET_80211_HDR_TYPE_AND_SUBTYPE(_hdr, _val) \
|
|
WRITEEF1BYTE(_hdr, _val)
|
|
#define SET_80211_HDR_PWR_MGNT(_hdr, _val) \
|
|
SET_BITS_TO_LE_2BYTE(_hdr, 12, 1, _val)
|
|
#define SET_80211_HDR_TO_DS(_hdr, _val) \
|
|
SET_BITS_TO_LE_2BYTE(_hdr, 8, 1, _val)
|
|
|
|
#define SET_80211_PS_POLL_AID(_hdr, _val) \
|
|
(*(u16 *)((u8 *)(_hdr) + 2) = _val)
|
|
#define SET_80211_PS_POLL_BSSID(_hdr, _val) \
|
|
ether_addr_copy(((u8 *)(_hdr)) + 4, (u8 *)(_val))
|
|
#define SET_80211_PS_POLL_TA(_hdr, _val) \
|
|
ether_addr_copy(((u8 *)(_hdr))+10, (u8 *)(_val))
|
|
|
|
#define SET_80211_HDR_DURATION(_hdr, _val) \
|
|
(*(u16 *)((u8 *)(_hdr) + FRAME_OFFSET_DURATION) = le16_to_cpu(_val))
|
|
#define SET_80211_HDR_ADDRESS1(_hdr, _val) \
|
|
CP_MACADDR((u8 *)(_hdr)+FRAME_OFFSET_ADDRESS1, (u8 *)(_val))
|
|
#define SET_80211_HDR_ADDRESS2(_hdr, _val) \
|
|
CP_MACADDR((u8 *)(_hdr)+FRAME_OFFSET_ADDRESS2, (u8 *)(_val))
|
|
#define SET_80211_HDR_ADDRESS3(_hdr, _val) \
|
|
CP_MACADDR((u8 *)(_hdr)+FRAME_OFFSET_ADDRESS3, (u8 *)(_val))
|
|
#define SET_80211_HDR_FRAGMENT_SEQUENCE(_hdr, _val) \
|
|
WRITEEF2BYTE((u8 *)(_hdr)+FRAME_OFFSET_SEQUENCE, _val)
|
|
|
|
#define SET_BEACON_PROBE_RSP_TIME_STAMP_LOW(__phdr, __val) \
|
|
WRITEEF4BYTE(((u8 *)(__phdr)) + 24, __val)
|
|
#define SET_BEACON_PROBE_RSP_TIME_STAMP_HIGH(__phdr, __val) \
|
|
WRITEEF4BYTE(((u8 *)(__phdr)) + 28, __val)
|
|
#define SET_BEACON_PROBE_RSP_BEACON_INTERVAL(__phdr, __val) \
|
|
WRITEEF2BYTE(((u8 *)(__phdr)) + 32, __val)
|
|
#define GET_BEACON_PROBE_RSP_CAPABILITY_INFO(__phdr) \
|
|
READEF2BYTE(((u8 *)(__phdr)) + 34)
|
|
#define SET_BEACON_PROBE_RSP_CAPABILITY_INFO(__phdr, __val) \
|
|
WRITEEF2BYTE(((u8 *)(__phdr)) + 34, __val)
|
|
#define MASK_BEACON_PROBE_RSP_CAPABILITY_INFO(__phdr, __val) \
|
|
SET_BEACON_PROBE_RSP_CAPABILITY_INFO(__phdr, \
|
|
(GET_BEACON_PROBE_RSP_CAPABILITY_INFO(__phdr) & (~(__val))))
|
|
|
|
#define SET_TX_DESC_SPE_RPT(__pdesc, __val) \
|
|
SET_BITS_TO_LE_4BYTE((__pdesc) + 8, 19, 1, __val)
|
|
#define SET_TX_DESC_SW_DEFINE(__pdesc, __val) \
|
|
SET_BITS_TO_LE_4BYTE((__pdesc) + 24, 0, 12, __val)
|
|
|
|
int rtl_init_core(struct ieee80211_hw *hw);
|
|
void rtl_deinit_core(struct ieee80211_hw *hw);
|
|
void rtl_init_rx_config(struct ieee80211_hw *hw);
|
|
void rtl_init_rfkill(struct ieee80211_hw *hw);
|
|
void rtl_deinit_rfkill(struct ieee80211_hw *hw);
|
|
|
|
void rtl_watch_dog_timer_callback(struct timer_list *t);
|
|
void rtl_deinit_deferred_work(struct ieee80211_hw *hw, bool ips_wq);
|
|
|
|
bool rtl_action_proc(struct ieee80211_hw *hw, struct sk_buff *skb, u8 is_tx);
|
|
int rtlwifi_rate_mapping(struct ieee80211_hw *hw, bool isht,
|
|
bool isvht, u8 desc_rate);
|
|
bool rtl_tx_mgmt_proc(struct ieee80211_hw *hw, struct sk_buff *skb);
|
|
u8 rtl_is_special_data(struct ieee80211_hw *hw, struct sk_buff *skb, u8 is_tx,
|
|
bool is_enc);
|
|
|
|
void rtl_tx_ackqueue(struct ieee80211_hw *hw, struct sk_buff *skb);
|
|
bool rtl_is_tx_report_skb(struct ieee80211_hw *hw, struct sk_buff *skb);
|
|
void rtl_set_tx_report(struct rtl_tcb_desc *ptcb_desc, u8 *pdesc,
|
|
struct ieee80211_hw *hw, struct rtlwifi_tx_info *info);
|
|
void rtl_tx_report_handler(struct ieee80211_hw *hw, u8 *tmp_buf,
|
|
u8 c2h_cmd_len);
|
|
bool rtl_check_tx_report_acked(struct ieee80211_hw *hw);
|
|
void rtl_wait_tx_report_acked(struct ieee80211_hw *hw, u32 wait_ms);
|
|
u32 rtl_get_hal_edca_param(struct ieee80211_hw *hw,
|
|
struct ieee80211_vif *vif,
|
|
enum wireless_mode wirelessmode,
|
|
struct ieee80211_tx_queue_params *param);
|
|
|
|
void rtl_beacon_statistic(struct ieee80211_hw *hw, struct sk_buff *skb);
|
|
void rtl_collect_scan_list(struct ieee80211_hw *hw, struct sk_buff *skb);
|
|
void rtl_scan_list_expire(struct ieee80211_hw *hw);
|
|
int rtl_tx_agg_start(struct ieee80211_hw *hw, struct ieee80211_vif *vif,
|
|
struct ieee80211_sta *sta, u16 tid, u16 *ssn);
|
|
int rtl_tx_agg_stop(struct ieee80211_hw *hw, struct ieee80211_vif *vif,
|
|
struct ieee80211_sta *sta, u16 tid);
|
|
int rtl_tx_agg_oper(struct ieee80211_hw *hw,
|
|
struct ieee80211_sta *sta, u16 tid);
|
|
int rtl_rx_agg_start(struct ieee80211_hw *hw,
|
|
struct ieee80211_sta *sta, u16 tid);
|
|
int rtl_rx_agg_stop(struct ieee80211_hw *hw,
|
|
struct ieee80211_sta *sta, u16 tid);
|
|
void rtl_rx_ampdu_apply(struct rtl_priv *rtlpriv);
|
|
void rtl_watchdog_wq_callback(void *data);
|
|
void rtl_fwevt_wq_callback(void *data);
|
|
void rtl_c2hcmd_wq_callback(void *data);
|
|
void rtl_c2hcmd_launcher(struct ieee80211_hw *hw, int exec);
|
|
void rtl_c2hcmd_enqueue(struct ieee80211_hw *hw, struct sk_buff *skb);
|
|
|
|
u8 rtl_mrate_idx_to_arfr_id(struct ieee80211_hw *hw, u8 rate_index,
|
|
enum wireless_mode wirelessmode);
|
|
void rtl_get_tcb_desc(struct ieee80211_hw *hw,
|
|
struct ieee80211_tx_info *info,
|
|
struct ieee80211_sta *sta,
|
|
struct sk_buff *skb, struct rtl_tcb_desc *tcb_desc);
|
|
|
|
int rtl_send_smps_action(struct ieee80211_hw *hw,
|
|
struct ieee80211_sta *sta,
|
|
enum ieee80211_smps_mode smps);
|
|
u8 *rtl_find_ie(u8 *data, unsigned int len, u8 ie);
|
|
void rtl_recognize_peer(struct ieee80211_hw *hw, u8 *data, unsigned int len);
|
|
u8 rtl_tid_to_ac(u8 tid);
|
|
void rtl_easy_concurrent_retrytimer_callback(struct timer_list *t);
|
|
extern struct rtl_global_var rtl_global_var;
|
|
void rtl_phy_scan_operation_backup(struct ieee80211_hw *hw, u8 operation);
|
|
|
|
#endif
|