mirror of
https://github.com/AuxXxilium/linux_dsm_epyc7002.git
synced 2024-12-27 20:16:05 +07:00
789659f430
Missed breadcrumb detection is defunct due to the tight coupling with dma_fence signaling and the myriad ways we may signal fences from everywhere but from an interrupt, i.e. we frequently signal a fence before we even see its interrupt. This means that even if we miss an interrupt for a fence, it still is signaled before our breadcrumb hangcheck fires, so simplify the breadcrumb hangchecking by moving it into the GPU hangcheck and forgo fake interrupts. Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20190129205230.19056-3-chris@chris-wilson.co.uk
348 lines
9.4 KiB
C
348 lines
9.4 KiB
C
/*
|
|
* Copyright © 2015 Intel Corporation
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person obtaining a
|
|
* copy of this software and associated documentation files (the "Software"),
|
|
* to deal in the Software without restriction, including without limitation
|
|
* the rights to use, copy, modify, merge, publish, distribute, sublicense,
|
|
* and/or sell copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following conditions:
|
|
*
|
|
* The above copyright notice and this permission notice (including the next
|
|
* paragraph) shall be included in all copies or substantial portions of the
|
|
* Software.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
|
|
* IN THE SOFTWARE.
|
|
*
|
|
*/
|
|
|
|
#include <linux/kthread.h>
|
|
#include <uapi/linux/sched/types.h>
|
|
|
|
#include "i915_drv.h"
|
|
|
|
#define task_asleep(tsk) ((tsk)->state & TASK_NORMAL && !(tsk)->on_rq)
|
|
|
|
static void irq_enable(struct intel_engine_cs *engine)
|
|
{
|
|
if (!engine->irq_enable)
|
|
return;
|
|
|
|
/* Caller disables interrupts */
|
|
spin_lock(&engine->i915->irq_lock);
|
|
engine->irq_enable(engine);
|
|
spin_unlock(&engine->i915->irq_lock);
|
|
}
|
|
|
|
static void irq_disable(struct intel_engine_cs *engine)
|
|
{
|
|
if (!engine->irq_disable)
|
|
return;
|
|
|
|
/* Caller disables interrupts */
|
|
spin_lock(&engine->i915->irq_lock);
|
|
engine->irq_disable(engine);
|
|
spin_unlock(&engine->i915->irq_lock);
|
|
}
|
|
|
|
static void __intel_breadcrumbs_disarm_irq(struct intel_breadcrumbs *b)
|
|
{
|
|
lockdep_assert_held(&b->irq_lock);
|
|
|
|
GEM_BUG_ON(!b->irq_enabled);
|
|
if (!--b->irq_enabled)
|
|
irq_disable(container_of(b,
|
|
struct intel_engine_cs,
|
|
breadcrumbs));
|
|
|
|
b->irq_armed = false;
|
|
}
|
|
|
|
void intel_engine_disarm_breadcrumbs(struct intel_engine_cs *engine)
|
|
{
|
|
struct intel_breadcrumbs *b = &engine->breadcrumbs;
|
|
|
|
if (!b->irq_armed)
|
|
return;
|
|
|
|
spin_lock_irq(&b->irq_lock);
|
|
if (b->irq_armed)
|
|
__intel_breadcrumbs_disarm_irq(b);
|
|
spin_unlock_irq(&b->irq_lock);
|
|
}
|
|
|
|
static inline bool __request_completed(const struct i915_request *rq)
|
|
{
|
|
return i915_seqno_passed(__hwsp_seqno(rq), rq->fence.seqno);
|
|
}
|
|
|
|
bool intel_engine_breadcrumbs_irq(struct intel_engine_cs *engine)
|
|
{
|
|
struct intel_breadcrumbs *b = &engine->breadcrumbs;
|
|
struct intel_context *ce, *cn;
|
|
struct list_head *pos, *next;
|
|
LIST_HEAD(signal);
|
|
|
|
spin_lock(&b->irq_lock);
|
|
|
|
if (b->irq_armed && list_empty(&b->signalers))
|
|
__intel_breadcrumbs_disarm_irq(b);
|
|
|
|
list_for_each_entry_safe(ce, cn, &b->signalers, signal_link) {
|
|
GEM_BUG_ON(list_empty(&ce->signals));
|
|
|
|
list_for_each_safe(pos, next, &ce->signals) {
|
|
struct i915_request *rq =
|
|
list_entry(pos, typeof(*rq), signal_link);
|
|
|
|
if (!__request_completed(rq))
|
|
break;
|
|
|
|
GEM_BUG_ON(!test_bit(I915_FENCE_FLAG_SIGNAL,
|
|
&rq->fence.flags));
|
|
clear_bit(I915_FENCE_FLAG_SIGNAL, &rq->fence.flags);
|
|
|
|
/*
|
|
* We may race with direct invocation of
|
|
* dma_fence_signal(), e.g. i915_request_retire(),
|
|
* in which case we can skip processing it ourselves.
|
|
*/
|
|
if (test_bit(DMA_FENCE_FLAG_SIGNALED_BIT,
|
|
&rq->fence.flags))
|
|
continue;
|
|
|
|
/*
|
|
* Queue for execution after dropping the signaling
|
|
* spinlock as the callback chain may end up adding
|
|
* more signalers to the same context or engine.
|
|
*/
|
|
i915_request_get(rq);
|
|
list_add_tail(&rq->signal_link, &signal);
|
|
}
|
|
|
|
/*
|
|
* We process the list deletion in bulk, only using a list_add
|
|
* (not list_move) above but keeping the status of
|
|
* rq->signal_link known with the I915_FENCE_FLAG_SIGNAL bit.
|
|
*/
|
|
if (!list_is_first(pos, &ce->signals)) {
|
|
/* Advance the list to the first incomplete request */
|
|
__list_del_many(&ce->signals, pos);
|
|
if (&ce->signals == pos) /* now empty */
|
|
list_del_init(&ce->signal_link);
|
|
}
|
|
}
|
|
|
|
spin_unlock(&b->irq_lock);
|
|
|
|
list_for_each_safe(pos, next, &signal) {
|
|
struct i915_request *rq =
|
|
list_entry(pos, typeof(*rq), signal_link);
|
|
|
|
dma_fence_signal(&rq->fence);
|
|
i915_request_put(rq);
|
|
}
|
|
|
|
return !list_empty(&signal);
|
|
}
|
|
|
|
bool intel_engine_signal_breadcrumbs(struct intel_engine_cs *engine)
|
|
{
|
|
bool result;
|
|
|
|
local_irq_disable();
|
|
result = intel_engine_breadcrumbs_irq(engine);
|
|
local_irq_enable();
|
|
|
|
return result;
|
|
}
|
|
|
|
static void signal_irq_work(struct irq_work *work)
|
|
{
|
|
struct intel_engine_cs *engine =
|
|
container_of(work, typeof(*engine), breadcrumbs.irq_work);
|
|
|
|
intel_engine_breadcrumbs_irq(engine);
|
|
}
|
|
|
|
void intel_engine_pin_breadcrumbs_irq(struct intel_engine_cs *engine)
|
|
{
|
|
struct intel_breadcrumbs *b = &engine->breadcrumbs;
|
|
|
|
spin_lock_irq(&b->irq_lock);
|
|
if (!b->irq_enabled++)
|
|
irq_enable(engine);
|
|
GEM_BUG_ON(!b->irq_enabled); /* no overflow! */
|
|
spin_unlock_irq(&b->irq_lock);
|
|
}
|
|
|
|
void intel_engine_unpin_breadcrumbs_irq(struct intel_engine_cs *engine)
|
|
{
|
|
struct intel_breadcrumbs *b = &engine->breadcrumbs;
|
|
|
|
spin_lock_irq(&b->irq_lock);
|
|
GEM_BUG_ON(!b->irq_enabled); /* no underflow! */
|
|
if (!--b->irq_enabled)
|
|
irq_disable(engine);
|
|
spin_unlock_irq(&b->irq_lock);
|
|
}
|
|
|
|
static void __intel_breadcrumbs_arm_irq(struct intel_breadcrumbs *b)
|
|
{
|
|
struct intel_engine_cs *engine =
|
|
container_of(b, struct intel_engine_cs, breadcrumbs);
|
|
|
|
lockdep_assert_held(&b->irq_lock);
|
|
if (b->irq_armed)
|
|
return;
|
|
|
|
/*
|
|
* The breadcrumb irq will be disarmed on the interrupt after the
|
|
* waiters are signaled. This gives us a single interrupt window in
|
|
* which we can add a new waiter and avoid the cost of re-enabling
|
|
* the irq.
|
|
*/
|
|
b->irq_armed = true;
|
|
|
|
/*
|
|
* Since we are waiting on a request, the GPU should be busy
|
|
* and should have its own rpm reference. This is tracked
|
|
* by i915->gt.awake, we can forgo holding our own wakref
|
|
* for the interrupt as before i915->gt.awake is released (when
|
|
* the driver is idle) we disarm the breadcrumbs.
|
|
*/
|
|
|
|
if (!b->irq_enabled++)
|
|
irq_enable(engine);
|
|
}
|
|
|
|
void intel_engine_init_breadcrumbs(struct intel_engine_cs *engine)
|
|
{
|
|
struct intel_breadcrumbs *b = &engine->breadcrumbs;
|
|
|
|
spin_lock_init(&b->irq_lock);
|
|
INIT_LIST_HEAD(&b->signalers);
|
|
|
|
init_irq_work(&b->irq_work, signal_irq_work);
|
|
}
|
|
|
|
void intel_engine_reset_breadcrumbs(struct intel_engine_cs *engine)
|
|
{
|
|
struct intel_breadcrumbs *b = &engine->breadcrumbs;
|
|
unsigned long flags;
|
|
|
|
spin_lock_irqsave(&b->irq_lock, flags);
|
|
|
|
if (b->irq_enabled)
|
|
irq_enable(engine);
|
|
else
|
|
irq_disable(engine);
|
|
|
|
spin_unlock_irqrestore(&b->irq_lock, flags);
|
|
}
|
|
|
|
void intel_engine_fini_breadcrumbs(struct intel_engine_cs *engine)
|
|
{
|
|
}
|
|
|
|
bool i915_request_enable_breadcrumb(struct i915_request *rq)
|
|
{
|
|
struct intel_breadcrumbs *b = &rq->engine->breadcrumbs;
|
|
|
|
GEM_BUG_ON(test_bit(I915_FENCE_FLAG_SIGNAL, &rq->fence.flags));
|
|
|
|
if (!test_bit(I915_FENCE_FLAG_ACTIVE, &rq->fence.flags))
|
|
return true;
|
|
|
|
spin_lock(&b->irq_lock);
|
|
if (test_bit(I915_FENCE_FLAG_ACTIVE, &rq->fence.flags) &&
|
|
!__request_completed(rq)) {
|
|
struct intel_context *ce = rq->hw_context;
|
|
struct list_head *pos;
|
|
|
|
__intel_breadcrumbs_arm_irq(b);
|
|
|
|
/*
|
|
* We keep the seqno in retirement order, so we can break
|
|
* inside intel_engine_breadcrumbs_irq as soon as we've passed
|
|
* the last completed request (or seen a request that hasn't
|
|
* event started). We could iterate the timeline->requests list,
|
|
* but keeping a separate signalers_list has the advantage of
|
|
* hopefully being much smaller than the full list and so
|
|
* provides faster iteration and detection when there are no
|
|
* more interrupts required for this context.
|
|
*
|
|
* We typically expect to add new signalers in order, so we
|
|
* start looking for our insertion point from the tail of
|
|
* the list.
|
|
*/
|
|
list_for_each_prev(pos, &ce->signals) {
|
|
struct i915_request *it =
|
|
list_entry(pos, typeof(*it), signal_link);
|
|
|
|
if (i915_seqno_passed(rq->fence.seqno, it->fence.seqno))
|
|
break;
|
|
}
|
|
list_add(&rq->signal_link, pos);
|
|
if (pos == &ce->signals) /* catch transitions from empty list */
|
|
list_move_tail(&ce->signal_link, &b->signalers);
|
|
|
|
set_bit(I915_FENCE_FLAG_SIGNAL, &rq->fence.flags);
|
|
}
|
|
spin_unlock(&b->irq_lock);
|
|
|
|
return !__request_completed(rq);
|
|
}
|
|
|
|
void i915_request_cancel_breadcrumb(struct i915_request *rq)
|
|
{
|
|
struct intel_breadcrumbs *b = &rq->engine->breadcrumbs;
|
|
|
|
if (!test_bit(I915_FENCE_FLAG_SIGNAL, &rq->fence.flags))
|
|
return;
|
|
|
|
spin_lock(&b->irq_lock);
|
|
if (test_bit(I915_FENCE_FLAG_SIGNAL, &rq->fence.flags)) {
|
|
struct intel_context *ce = rq->hw_context;
|
|
|
|
list_del(&rq->signal_link);
|
|
if (list_empty(&ce->signals))
|
|
list_del_init(&ce->signal_link);
|
|
|
|
clear_bit(I915_FENCE_FLAG_SIGNAL, &rq->fence.flags);
|
|
}
|
|
spin_unlock(&b->irq_lock);
|
|
}
|
|
|
|
void intel_engine_print_breadcrumbs(struct intel_engine_cs *engine,
|
|
struct drm_printer *p)
|
|
{
|
|
struct intel_breadcrumbs *b = &engine->breadcrumbs;
|
|
struct intel_context *ce;
|
|
struct i915_request *rq;
|
|
|
|
if (list_empty(&b->signalers))
|
|
return;
|
|
|
|
drm_printf(p, "Signals:\n");
|
|
|
|
spin_lock_irq(&b->irq_lock);
|
|
list_for_each_entry(ce, &b->signalers, signal_link) {
|
|
list_for_each_entry(rq, &ce->signals, signal_link) {
|
|
drm_printf(p, "\t[%llx:%llx%s] @ %dms\n",
|
|
rq->fence.context, rq->fence.seqno,
|
|
i915_request_completed(rq) ? "!" :
|
|
i915_request_started(rq) ? "*" :
|
|
"",
|
|
jiffies_to_msecs(jiffies - rq->emitted_jiffies));
|
|
}
|
|
}
|
|
spin_unlock_irq(&b->irq_lock);
|
|
}
|