Linus Torvalds 8b11ec1b5f mm: do not initialize TLB stack vma's with vma_init() ... Commit 2c4541e24c ("mm: use vma_init() to initialize VMAs on stack and data segments") tried to initialize various left-over ad-hoc vma's "properly", but actually made things worse for the temporary vma's used for TLB flushing. vma_init() doesn't actually initialize all of the vma, just a few fields, so doing something like - struct vm_area_struct vma = { .vm_mm = tlb->mm, }; + struct vm_area_struct vma; + + vma_init(&vma, tlb->mm); was actually very bad: instead of having a nicely initialized vma with every field but "vm_mm" zeroed, you'd have an entirely uninitialized vma with only a couple of fields initialized. And they weren't even fields that the code in question mostly cared about. The flush_tlb_range() function takes a "struct vma" rather than a "struct mm_struct", because a few architectures actually care about what kind of range it is - being able to only do an ITLB flush if it's a range that doesn't have data accesses enabled, for example. And all the normal users already have the vma for doing the range invalidation. But a few people want to call flush_tlb_range() with a range they just made up, so they also end up using a made-up vma. x86 just has a special "flush_tlb_mm_range()" function for this, but other architectures (arm and ia64) do the "use fake vma" thing instead, and thus got caught up in the vma_init() changes. At the same time, the TLB flushing code really doesn't care about most other fields in the vma, so vma_init() is just unnecessary and pointless. This fixes things by having an explicit "this is just an initializer for the TLB flush" initializer macro, which is used by the arm/arm64/ia64 people who mis-use this interface with just a dummy vma. Fixes: 2c4541e24c ("mm: use vma_init() to initialize VMAs on stack and data segments") Cc: Dmitry Vyukov <dvyukov@google.com> Cc: Oleg Nesterov <oleg@redhat.com> Cc: Andrea Arcangeli <aarcange@redhat.com> Cc: Kirill Shutemov <kirill.shutemov@linux.intel.com> Cc: Andrew Morton <akpm@linux-foundation.org> Cc: John Stultz <john.stultz@linaro.org> Cc: Hugh Dickins <hughd@google.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>		2018-08-01 13:43:38 -07:00
..
acpi	ACPI / processor: Finish making acpi_processor_ppc_has_changed() void	2018-06-20 10:50:40 +02:00
asm-generic	mm: allow arch to supply p??_free_tlb functions	2018-07-14 11:11:09 -07:00
clocksource
crypto	Revert changes to convert to ->poll_mask() and aio IOCB_CMD_POLL	2018-06-28 10:40:47 -07:00
drm	drm for v4.18-rc1	2018-06-06 08:16:33 -07:00
dt-bindings	dt-bindings: clock: imx6ul: Do not change the clock definition order	2018-06-29 11:40:20 -07:00
keys	docs: Fix some broken references	2018-06-15 18:10:01 -03:00
kvm
linux	mm: do not initialize TLB stack vma's with vma_init()	2018-08-01 13:43:38 -07:00
math-emu
media
memory
misc
net	Merge git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf	2018-07-24 09:56:50 -07:00
pcmcia
ras
rdma	4.18-rc	2018-06-21 07:22:30 +09:00
scsi	SCSI misc on 20180610	2018-06-10 13:01:12 -07:00
soc	ARM: SoC: late updates	2018-06-11 18:19:45 -07:00
sound	sound updates for 4.18	2018-06-06 09:08:38 -07:00
target
trace	NFS client updates for Linux 4.18	2018-06-12 10:09:03 -07:00
uapi	Merge branch 'perf-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2018-07-30 11:45:30 -07:00
video	fbdev changes for v4.18:	2018-06-17 05:00:24 +09:00
xen	xen: fixes for 4.18-rc2	2018-06-23 20:44:11 +08:00