mirror of
https://github.com/AuxXxilium/linux_dsm_epyc7002.git
synced 2024-12-25 10:18:34 +07:00
d2ed0a7755
Make sure to deregister and free any fixed-link phy registered during probe on probe errors and on driver unbind by adding a new glue helper function. Drop the of-node reference taken in the same path also on late probe errors (and not just on driver unbind) by moving the put from stmmac_dvr_remove() to the new helper. Fixes:277323814e("stmmac: add fixed-link device-tree support") Fixes:4613b279be("ethernet: stmicro: stmmac: add missing of_node_put after calling of_parse_phandle") Signed-off-by: Johan Hovold <johan@kernel.org> Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com> Signed-off-by: David S. Miller <davem@davemloft.net>
98 lines
2.5 KiB
C
98 lines
2.5 KiB
C
/*
|
|
* DWMAC glue for NXP LPC18xx/LPC43xx Ethernet
|
|
*
|
|
* Copyright (C) 2015 Joachim Eastwood <manabian@gmail.com>
|
|
*
|
|
* This file is licensed under the terms of the GNU General Public
|
|
* License version 2. This program is licensed "as is" without any
|
|
* warranty of any kind, whether express or implied.
|
|
*/
|
|
|
|
#include <linux/mfd/syscon.h>
|
|
#include <linux/module.h>
|
|
#include <linux/of.h>
|
|
#include <linux/of_net.h>
|
|
#include <linux/phy.h>
|
|
#include <linux/platform_device.h>
|
|
#include <linux/regmap.h>
|
|
#include <linux/stmmac.h>
|
|
|
|
#include "stmmac_platform.h"
|
|
|
|
/* Register defines for CREG syscon */
|
|
#define LPC18XX_CREG_CREG6 0x12c
|
|
# define LPC18XX_CREG_CREG6_ETHMODE_MASK 0x7
|
|
# define LPC18XX_CREG_CREG6_ETHMODE_MII 0x0
|
|
# define LPC18XX_CREG_CREG6_ETHMODE_RMII 0x4
|
|
|
|
static int lpc18xx_dwmac_probe(struct platform_device *pdev)
|
|
{
|
|
struct plat_stmmacenet_data *plat_dat;
|
|
struct stmmac_resources stmmac_res;
|
|
struct regmap *reg;
|
|
u8 ethmode;
|
|
int ret;
|
|
|
|
ret = stmmac_get_platform_resources(pdev, &stmmac_res);
|
|
if (ret)
|
|
return ret;
|
|
|
|
plat_dat = stmmac_probe_config_dt(pdev, &stmmac_res.mac);
|
|
if (IS_ERR(plat_dat))
|
|
return PTR_ERR(plat_dat);
|
|
|
|
plat_dat->has_gmac = true;
|
|
|
|
reg = syscon_regmap_lookup_by_compatible("nxp,lpc1850-creg");
|
|
if (IS_ERR(reg)) {
|
|
dev_err(&pdev->dev, "syscon lookup failed\n");
|
|
ret = PTR_ERR(reg);
|
|
goto err_remove_config_dt;
|
|
}
|
|
|
|
if (plat_dat->interface == PHY_INTERFACE_MODE_MII) {
|
|
ethmode = LPC18XX_CREG_CREG6_ETHMODE_MII;
|
|
} else if (plat_dat->interface == PHY_INTERFACE_MODE_RMII) {
|
|
ethmode = LPC18XX_CREG_CREG6_ETHMODE_RMII;
|
|
} else {
|
|
dev_err(&pdev->dev, "Only MII and RMII mode supported\n");
|
|
ret = -EINVAL;
|
|
goto err_remove_config_dt;
|
|
}
|
|
|
|
regmap_update_bits(reg, LPC18XX_CREG_CREG6,
|
|
LPC18XX_CREG_CREG6_ETHMODE_MASK, ethmode);
|
|
|
|
ret = stmmac_dvr_probe(&pdev->dev, plat_dat, &stmmac_res);
|
|
if (ret)
|
|
goto err_remove_config_dt;
|
|
|
|
return 0;
|
|
|
|
err_remove_config_dt:
|
|
stmmac_remove_config_dt(pdev, plat_dat);
|
|
|
|
return ret;
|
|
}
|
|
|
|
static const struct of_device_id lpc18xx_dwmac_match[] = {
|
|
{ .compatible = "nxp,lpc1850-dwmac" },
|
|
{ }
|
|
};
|
|
MODULE_DEVICE_TABLE(of, lpc18xx_dwmac_match);
|
|
|
|
static struct platform_driver lpc18xx_dwmac_driver = {
|
|
.probe = lpc18xx_dwmac_probe,
|
|
.remove = stmmac_pltfr_remove,
|
|
.driver = {
|
|
.name = "lpc18xx-dwmac",
|
|
.pm = &stmmac_pltfr_pm_ops,
|
|
.of_match_table = lpc18xx_dwmac_match,
|
|
},
|
|
};
|
|
module_platform_driver(lpc18xx_dwmac_driver);
|
|
|
|
MODULE_AUTHOR("Joachim Eastwood <manabian@gmail.com>");
|
|
MODULE_DESCRIPTION("DWMAC glue for LPC18xx/43xx Ethernet");
|
|
MODULE_LICENSE("GPL v2");
|