Jan Kara a3bb2d5587 ext4: Don't clear SGID when inheriting ACLs ... When new directory 'DIR1' is created in a directory 'DIR0' with SGID bit set, DIR1 is expected to have SGID bit set (and owning group equal to the owning group of 'DIR0'). However when 'DIR0' also has some default ACLs that 'DIR1' inherits, setting these ACLs will result in SGID bit on 'DIR1' to get cleared if user is not member of the owning group. Fix the problem by moving posix_acl_update_mode() out of __ext4_set_acl() into ext4_set_acl(). That way the function will not be called when inheriting ACLs which is what we want as it prevents SGID bit clearing and the mode has been properly set by posix_acl_create() anyway. Fixes: 073931017b CC: stable@vger.kernel.org Signed-off-by: Theodore Ts'o <tytso@mit.edu> Signed-off-by: Jan Kara <jack@suse.cz> Reviewed-by: Andreas Gruenbacher <agruenba@redhat.com>		2017-07-30 23:33:01 -04:00
..
acl.c	ext4: Don't clear SGID when inheriting ACLs	2017-07-30 23:33:01 -04:00
acl.h	ext2/3/4: use generic posix ACL infrastructure	2014-01-25 23:58:19 -05:00
balloc.c	The major change this cycle is deleting ext4's copy of the file system	2016-07-26 18:35:55 -07:00
bitmap.c	ext4: remove unused header files	2015-04-02 23:47:42 -04:00
block_validity.c	ext4: add missing KERN_CONT to a few more debugging uses	2016-10-15 09:57:31 -04:00
dir.c	ext4: remove unused variable	2016-09-30 02:14:56 -04:00
ext4_extents.h	ext4: fix misspellings in comments.	2016-03-09 23:49:05 -05:00
ext4_jbd2.c	ext4: add shutdown bit and check for it	2017-02-05 01:28:48 -05:00
ext4_jbd2.h	ext4: improve journal credit handling in set xattr paths	2017-06-21 22:28:40 -04:00
ext4.h	ext4: remove unused metadata accounting variables	2017-07-30 22:30:11 -04:00
extents_status.c	scripts/spelling.txt: add "comsume(r)" pattern and fix typo instances	2017-02-27 18:43:47 -08:00
extents_status.h	ext4: move procfs registration code to fs/ext4/sysfs.c	2015-09-23 12:46:17 -04:00
extents.c	ext4: call journal revoke when freeing ea_inode blocks	2017-06-21 21:36:51 -04:00
file.c	The first major feature for ext4 this merge window is the largedir	2017-07-09 09:31:22 -07:00
fsmap.c	ext4: fix off-by-one fsmap error on 1k block filesystems	2017-06-23 00:58:57 -04:00
fsmap.h	ext4: support GETFSMAP ioctls	2017-04-30 00:36:53 -04:00
fsync.c	ext4: use errseq_t based error handling for reporting data writeback errors	2017-07-06 07:02:30 -04:00
hash.c	ext4: move halfmd4 into hash.c directly	2017-02-02 11:52:14 -05:00
ialloc.c	ext4: fix __ext4_new_inode() journal credits calculation	2017-07-06 00:01:59 -04:00
indirect.c	ext4: call journal revoke when freeing ea_inode blocks	2017-06-21 21:36:51 -04:00
inline.c	ext4: xattr-in-inode support	2017-06-21 21:10:32 -04:00
inode.c	ext4: correct comment references to ext4_ext_direct_IO()	2017-07-30 22:26:40 -04:00
ioctl.c	quota: add get_inode_usage callback to transfer multi-inode charges	2017-06-22 11:46:48 -04:00
Kconfig	dax: fix build warnings with FS_DAX and !FS_IOMAP	2017-01-24 16:26:14 -08:00
Makefile	ext4: support GETFSMAP ioctls	2017-04-30 00:36:53 -04:00
mballoc.c	ext4: fix spelling mistake: "prellocated" -> "preallocated"	2017-07-06 15:28:45 -04:00
mballoc.h	ext4: send parallel discards on commit completions	2017-06-22 23:54:33 -04:00
migrate.c	ext4: do not set posix acls on xattr inodes	2017-06-21 21:21:39 -04:00
mmp.c	block,fs: use REQ_* flags directly	2016-11-01 09:43:26 -06:00
move_extent.c	ext4: add ext4_is_quota_file()	2017-06-22 11:31:25 -04:00
namei.c	ext4: return EFSBADCRC if a bad checksum error is found in ext4_find_entry()	2017-06-23 00:47:05 -04:00
page-io.c	ext4: add support for passing in write hints for buffered writes	2017-06-27 12:05:44 -06:00
readpage.c	block: switch bios to blk_status_t	2017-06-09 09:27:32 -06:00
resize.c	ext4: rename s_resize_flags to s_ext4_flags	2017-02-05 01:27:48 -05:00
super.c	ext4: remove unused metadata accounting variables	2017-07-30 22:30:11 -04:00
symlink.c	ext4: Add statx support	2017-04-03 01:05:58 -04:00
sysfs.c	ext4: check return value of kstrtoull correctly in reserved_clusters_store	2017-06-23 01:08:22 -04:00
truncate.h	ext4: fix races between page faults and hole punching	2015-12-07 14:28:03 -05:00
xattr_security.c	switch xattr_handler->set() to passing dentry and inode separately	2016-05-27 15:39:43 -04:00
xattr_trusted.c	switch xattr_handler->set() to passing dentry and inode separately	2016-05-27 15:39:43 -04:00
xattr_user.c	switch xattr_handler->set() to passing dentry and inode separately	2016-05-27 15:39:43 -04:00
xattr.c	ext4: fix __ext4_new_inode() journal credits calculation	2017-07-06 00:01:59 -04:00
xattr.h	ext4: fix __ext4_new_inode() journal credits calculation	2017-07-06 00:01:59 -04:00