John Hurley 59eb87cb52 net: sched: prevent duplicate flower rules from tcf_proto destroy race ... When a new filter is added to cls_api, the function tcf_chain_tp_insert_unique() looks up the protocol/priority/chain to determine if the tcf_proto is duplicated in the chain's hashtable. It then creates a new entry or continues with an existing one. In cls_flower, this allows the function fl_ht_insert_unque to determine if a filter is a duplicate and reject appropriately, meaning that the duplicate will not be passed to drivers via the offload hooks. However, when a tcf_proto is destroyed it is removed from its chain before a hardware remove hook is hit. This can lead to a race whereby the driver has not received the remove message but duplicate flows can be accepted. This, in turn, can lead to the offload driver receiving incorrect duplicate flows and out of order add/delete messages. Prevent duplicates by utilising an approach suggested by Vlad Buslov. A hash table per block stores each unique chain/protocol/prio being destroyed. This entry is only removed when the full destroy (and hardware offload) has completed. If a new flow is being added with the same identiers as a tc_proto being detroyed, then the add request is replayed until the destroy is complete. Fixes: 8b64678e0a ("net: sched: refactor tp insert/delete for concurrent execution") Signed-off-by: John Hurley <john.hurley@netronome.com> Signed-off-by: Vlad Buslov <vladbu@mellanox.com> Reviewed-by: Simon Horman <simon.horman@netronome.com> Reported-by: Louis Peens <louis.peens@netronome.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2019-11-05 17:47:26 -08:00
..
act_api.c	net: avoid potential infinite loop in tc_ctl_action()	2019-10-15 20:20:22 -07:00
act_bpf.c	net_sched: fix a NULL pointer deref in ipt action	2019-08-27 15:05:58 -07:00
act_connmark.c	net_sched: fix a NULL pointer deref in ipt action	2019-08-27 15:05:58 -07:00
act_csum.c	net_sched: fix a NULL pointer deref in ipt action	2019-08-27 15:05:58 -07:00
act_ct.c	netfilter: update include directives.	2019-09-13 12:33:06 +02:00
act_ctinfo.c	net_sched: fix a NULL pointer deref in ipt action	2019-08-27 15:05:58 -07:00
act_gact.c	net_sched: fix a NULL pointer deref in ipt action	2019-08-27 15:05:58 -07:00
act_ife.c	net_sched: fix a NULL pointer deref in ipt action	2019-08-27 15:05:58 -07:00
act_ipt.c	net_sched: fix a NULL pointer deref in ipt action	2019-08-27 15:05:58 -07:00
act_meta_mark.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
act_meta_skbprio.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
act_meta_skbtcindex.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
act_mirred.c	act_mirred: Fix mirred_init_module error handling	2019-10-09 19:19:35 -07:00
act_mpls.c	net/sched: fix corrupted L2 header with MPLS 'push' and 'pop' actions	2019-10-15 17:14:48 -07:00
act_nat.c	net_sched: fix a NULL pointer deref in ipt action	2019-08-27 15:05:58 -07:00
act_pedit.c	net_sched: fix a NULL pointer deref in ipt action	2019-08-27 15:05:58 -07:00
act_police.c	net_sched: act_police: add 2 new attributes to support police 64bit rate and peakrate	2019-09-06 15:02:16 +02:00
act_sample.c	net/sched: act_sample: don't push mac header on ip6gre ingress	2019-09-20 17:01:59 -07:00
act_simple.c	net_sched: fix a NULL pointer deref in ipt action	2019-08-27 15:05:58 -07:00
act_skbedit.c	net_sched: fix a NULL pointer deref in ipt action	2019-08-27 15:05:58 -07:00
act_skbmod.c	net_sched: fix a NULL pointer deref in ipt action	2019-08-27 15:05:58 -07:00
act_tunnel_key.c	net_sched: fix a NULL pointer deref in ipt action	2019-08-27 15:05:58 -07:00
act_vlan.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2019-09-02 11:20:17 -07:00
cls_api.c	net: sched: prevent duplicate flower rules from tcf_proto destroy race	2019-11-05 17:47:26 -08:00
cls_basic.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
cls_bpf.c	net: cls_bpf: fix NULL deref on offload filter removal	2019-11-01 15:16:01 -07:00
cls_cgroup.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
cls_flow.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
cls_flower.c	net: sched: flower: don't take rtnl lock for cls hw offloads API	2019-08-26 14:17:43 -07:00
cls_fw.c	net: sched: remove NET_CLS_IND config option	2019-06-15 14:06:13 -07:00
cls_matchall.c	net: sched: cls_matchall: cleanup flow_action before deallocating	2019-08-30 15:12:05 -07:00
cls_route.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
cls_rsvp6.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
cls_rsvp.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
cls_rsvp.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
cls_tcindex.c	treewide: Add SPDX license identifier for more missed files	2019-05-21 10:50:45 +02:00
cls_u32.c	net: sched: refactor block offloads counter usage	2019-08-26 14:17:43 -07:00
em_canid.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 11	2019-05-21 11:28:45 +02:00
em_cmp.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
em_ipset.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
em_ipt.c	net: sched: em_ipt: add support for addrtype matching	2019-06-29 11:15:12 -07:00
em_meta.c	tcp: annotate sk->sk_wmem_queued lockless reads	2019-10-13 10:13:08 -07:00
em_nbyte.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
em_text.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
em_u32.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
ematch.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
Kconfig	net/sched: Set default of CONFIG_NET_TC_SKB_EXT to N	2019-09-27 20:08:28 +02:00
Makefile	net/sched: Introduce action ct	2019-07-09 12:11:59 -07:00
sch_api.c	net_sched: fix backward compatibility for TCA_KIND	2019-10-08 16:21:58 -07:00
sch_atm.c	treewide: Add SPDX license identifier for more missed files	2019-05-21 10:50:45 +02:00
sch_blackhole.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
sch_cake.c	netlink: make validation more configurable for future strictness	2019-04-27 17:07:21 -04:00
sch_cbq.c	sch_cbq: validate TCA_CBQ_WRROPT to avoid crash	2019-09-30 11:07:46 -07:00
sch_cbs.c	net: sched: cbs: Avoid division by zero when calculating the port rate	2019-10-01 09:51:39 -07:00
sch_choke.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
sch_codel.c	net: sched: Fix a possible null-pointer dereference in dequeue_func()	2019-07-29 09:46:58 -07:00
sch_drr.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
sch_dsmark.c	sch_dsmark: fix potential NULL deref in dsmark_init()	2019-10-04 18:28:30 -07:00
sch_etf.c	sched: etf: Fix ordering of packets with same txtime	2019-10-15 20:32:04 -07:00
sch_fifo.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
sch_fq_codel.c	fq_codel: remove set but not used variables 'prev_ecn_mark' and 'prev_drop_count'	2019-08-08 22:32:19 -07:00
sch_fq.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
sch_generic.c	net: sch_generic: Use pfifo_fast as fallback scheduler for CAN hardware	2019-10-25 16:14:05 -07:00
sch_gred.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
sch_hfsc.c	netlink: make validation more configurable for future strictness	2019-04-27 17:07:21 -04:00
sch_hhf.c	net/flow_dissector: switch to siphash	2019-10-23 20:13:22 -07:00
sch_htb.c	net: sched: sch_htb: don't call qdisc_put() while holding tree lock	2019-09-27 12:13:55 +02:00
sch_ingress.c	net: flow_offload: rename TCF_BLOCK_BINDER_TYPE_* to FLOW_BLOCK_BINDER_TYPE_*	2019-07-09 14:38:50 -07:00
sch_mq.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
sch_mqprio.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
sch_multiq.c	net: sched: multiq: don't call qdisc_put() while holding tree lock	2019-09-27 12:13:55 +02:00
sch_netem.c	net: netem: correct the parent's backlog when corrupted packet was dropped	2019-10-19 12:12:36 -07:00
sch_pie.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 235	2019-06-19 17:09:07 +02:00
sch_plug.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
sch_prio.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
sch_qfq.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
sch_red.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
sch_sfb.c	net/flow_dissector: switch to siphash	2019-10-23 20:13:22 -07:00
sch_sfq.c	net/flow_dissector: switch to siphash	2019-10-23 20:13:22 -07:00
sch_skbprio.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
sch_taprio.c	taprio: fix panic while hw offload sched list swap	2019-11-05 13:58:14 -08:00
sch_tbf.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
sch_teql.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00