linux_dsm_epyc7002/tools/testing
David Ahern 34fe5a1cf9 ipv6: fib6_select_path can not use out path for nexthop objects
Brian reported a crash in IPv6 code when using rpfilter with a setup
running FRR and external nexthop objects. The root cause of the crash
is fib6_select_path setting fib6_nh in the result to NULL because of
an improper check for nexthop objects.

More specifically, rpfilter invokes ip6_route_lookup with flowi6_oif
set causing fib6_select_path to be called with have_oif_match set.
fib6_select_path has early check on have_oif_match and jumps to the
out label which presumes a builtin fib6_nh. This path is invalid for
nexthop objects; for external nexthops fib6_select_path needs to just
return if the fib6_nh has already been set in the result otherwise it
returns after the call to nexthop_path_fib6_result. Update the check
on have_oif_match to not bail on external nexthops.

Update selftests for this problem.

Fixes: f88d8ea67f ("ipv6: Plumb support for nexthop object in a fib6_info")
Reported-by: Brian Rak <brak@choopa.com>
Signed-off-by: David Ahern <dsahern@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
2020-07-06 13:24:16 -07:00
..
fault-injection
ktest ktest: Fix typos in ktest.pl 2020-03-09 16:15:27 -04:00
kunit kunit: Fix TabError, remove defconfig code and handle when there is no kunitconfig 2020-06-01 14:14:07 -06:00
nvdimm tools/testing/nvdimm: Replace zero-length array with flexible-array 2020-06-15 23:08:32 -05:00
radix-tree SPDX patches for 5.7-rc1. 2020-04-03 13:12:26 -07:00
scatterlist
selftests ipv6: fib6_select_path can not use out path for nexthop objects 2020-07-06 13:24:16 -07:00
vsock SPDX patches for 5.7-rc1. 2020-04-03 13:12:26 -07:00