linux_dsm_epyc7002/drivers/net/ethernet/intel/e1000e
Benjamin Poirier 0a8047ac68 e1000e: Fix msi-x interrupt automask
Since the introduction of 82574 support in e1000e, the driver has worked
on the assumption that msi-x interrupt generation is automatically
disabled after each irq. As it turns out, this is not the case.
Currently, rx interrupts can fire multiple times before and during napi
processing. This can be a problem for users because frames that arrive
in a certain window (after adapter->clean_rx() but before
napi_complete_done() has cleared NAPI_STATE_SCHED) generate an interrupt
which does not lead to napi_schedule(). These frames sit in the rx queue
until another frame arrives (a tcp retransmit for example).

While the EIAC and CTRL_EXT registers are properly configured for irq
automask, the modification of IAM in e1000_configure_msix() is what
prevents automask from working as intended.

This patch removes that erroneous write and fixes interrupt rearming for
tx interrupts. It also clears IAME from CTRL_EXT. This is not strictly
necessary for operation of the driver but it is to avoid disruption from
potential programs that access the registers directly, like `ethregs -c`.

Reported-by: Frank Steiner <steiner-reg@bio.ifi.lmu.de>
Signed-off-by: Benjamin Poirier <bpoirier@suse.com>
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
2015-12-14 20:19:47 -08:00
..
80003es2lan.c e1000e: Bump the version to 3.2.5 2015-06-03 04:13:39 -07:00
80003es2lan.h e1000e: Bump the version to 3.2.5 2015-06-03 04:13:39 -07:00
82571.c e1000e: Bump the version to 3.2.5 2015-06-03 04:13:39 -07:00
82571.h e1000e: Bump the version to 3.2.5 2015-06-03 04:13:39 -07:00
defines.h e1000e: Do not write lsc to ics in msi-x mode 2015-12-14 20:09:18 -08:00
e1000.h e1000e: Switch e1000e_up to void, drop code checking for error result 2015-12-14 09:47:05 -08:00
ethtool.c drivers/net: get rid of unnecessary initializations in .get_drvinfo() 2015-10-16 00:24:10 -07:00
hw.h e1000e: initial support for i219-LM (3) 2015-12-12 23:55:56 -08:00
ich8lan.c e1000e: initial support for i219-LM (3) 2015-12-12 23:55:56 -08:00
ich8lan.h e1000e: Cosmetic changes 2015-08-05 16:53:47 -07:00
mac.c e1000e: Bump the version to 3.2.5 2015-06-03 04:13:39 -07:00
mac.h e1000e: Bump the version to 3.2.5 2015-06-03 04:13:39 -07:00
Makefile e1000e: Cleanup - Update GPL header and Copyright 2014-03-07 21:55:27 -08:00
manage.c e1000e: Bump the version to 3.2.5 2015-06-03 04:13:39 -07:00
manage.h e1000e: Bump the version to 3.2.5 2015-06-03 04:13:39 -07:00
netdev.c e1000e: Fix msi-x interrupt automask 2015-12-14 20:19:47 -08:00
nvm.c e1000e: Bump the version to 3.2.5 2015-06-03 04:13:39 -07:00
nvm.h e1000e: Bump the version to 3.2.5 2015-06-03 04:13:39 -07:00
param.c e1000e: Bump the version to 3.2.5 2015-06-03 04:13:39 -07:00
phy.c e1000e: Bump the version to 3.2.5 2015-06-03 04:13:39 -07:00
phy.h e1000e: Bump the version to 3.2.5 2015-06-03 04:13:39 -07:00
ptp.c e1000e: Bump the version to 3.2.5 2015-06-03 04:13:39 -07:00
regs.h e1000e: Cosmetic changes 2015-08-05 16:53:47 -07:00