David Howells 9f35a33b8d KEYS: Fix a NULL pointer deref in the user-defined key type ... Fix a NULL pointer deref in the user-defined key type whereby updating a negative key into a fully instantiated key will cause an oops to occur when the code attempts to free the non-existent old payload. This results in an oops that looks something like the following: BUG: unable to handle kernel NULL pointer dereference at 0000000000000008 IP: [<ffffffff81085fa1>] __call_rcu+0x11/0x13e PGD 3391d067 PUD 3894a067 PMD 0 Oops: 0002 [#1] SMP CPU 1 Pid: 4354, comm: keyctl Not tainted 3.1.0-fsdevel+ #1140 /DG965RY RIP: 0010:[<ffffffff81085fa1>] [<ffffffff81085fa1>] __call_rcu+0x11/0x13e RSP: 0018:ffff88003d591df8 EFLAGS: 00010246 RAX: 0000000000000000 RBX: 0000000000000000 RCX: 000000000000006e RDX: ffffffff8161d0c0 RSI: 0000000000000000 RDI: 0000000000000000 RBP: ffff88003d591e18 R08: 0000000000000000 R09: ffffffff8152fa6c R10: 0000000000000000 R11: 0000000000000300 R12: ffff88003b8f9538 R13: ffffffff8161d0c0 R14: ffff88003b8f9d50 R15: ffff88003c69f908 FS: 00007f97eb18c720(0000) GS:ffff88003bd00000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 0000000000000008 CR3: 000000003d47a000 CR4: 00000000000006e0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400 Process keyctl (pid: 4354, threadinfo ffff88003d590000, task ffff88003c78a040) Stack: ffff88003e0ffde0 ffff88003b8f9538 0000000000000001 ffff88003b8f9d50 ffff88003d591e28 ffffffff810860f0 ffff88003d591e68 ffffffff8117bfea ffff88003d591e68 ffffffff00000000 ffff88003e0ffde1 ffff88003e0ffde0 Call Trace: [<ffffffff810860f0>] call_rcu_sched+0x10/0x12 [<ffffffff8117bfea>] user_update+0x8d/0xa2 [<ffffffff8117723a>] key_create_or_update+0x236/0x270 [<ffffffff811789b1>] sys_add_key+0x123/0x17e [<ffffffff813b84bb>] system_call_fastpath+0x16/0x1b Signed-off-by: David Howells <dhowells@redhat.com> Acked-by: Jeff Layton <jlayton@redhat.com> Acked-by: Neil Horman <nhorman@redhat.com> Acked-by: Steve Dickson <steved@redhat.com> Acked-by: James Morris <jmorris@namei.org> Cc: stable@kernel.org Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>		2011-11-15 22:32:38 -02:00
..
encrypted-keys	security: follow rename pack_hex_byte() to hex_byte_pack()	2011-10-31 17:30:56 -07:00
compat.c	Cross Memory Attach	2011-10-31 17:30:44 -07:00
gc.c	KEYS: Correctly destroy key payloads when their keytype is removed	2011-08-23 09:57:37 +10:00
internal.h	KEYS: Correctly destroy key payloads when their keytype is removed	2011-08-23 09:57:37 +10:00
key.c	KEYS: Correctly destroy key payloads when their keytype is removed	2011-08-23 09:57:37 +10:00
keyctl.c	Cross Memory Attach	2011-10-31 17:30:44 -07:00
keyring.c	KEYS: __key_link() should use the RCU deref wrapper for keyring payloads	2011-08-23 09:57:34 +10:00
Makefile	encrypted-keys: create encrypted-keys directory	2011-09-14 15:22:26 -04:00
permission.c	KEYS: Fix up comments in key management code	2011-01-21 14:59:30 -08:00
proc.c	KEYS: Improve /proc/keys	2011-03-17 11:59:32 +11:00
process_keys.c	KEYS: keyctl_get_keyring_ID() should create a session keyring if create flag set	2011-08-23 09:57:34 +10:00
request_key_auth.c	KEYS: Don't return EAGAIN to keyctl_assume_authority()	2011-06-14 15:03:29 +10:00
request_key.c	KEYS: Fix error handling in construct_key_and_link()	2011-06-21 18:31:45 -07:00
sysctl.c	sysctl: Drop & in front of every proc_handler.	2009-11-18 08:37:40 -08:00
trusted.c	security: follow rename pack_hex_byte() to hex_byte_pack()	2011-10-31 17:30:56 -07:00
trusted.h	trusted-keys: rename trusted_defined files to trusted	2011-01-24 10:14:22 +11:00
user_defined.c	KEYS: Fix a NULL pointer deref in the user-defined key type	2011-11-15 22:32:38 -02:00