mirror of
https://github.com/AuxXxilium/linux_dsm_epyc7002.git
synced 2024-12-28 11:18:45 +07:00
9dc775e7f5
This fixes a race of the form:
CPU0 CPU1
mlx5_ib_invalidate_range() mlx5_ib_invalidate_range()
// This one actually makes npages == 0
ib_umem_odp_unmap_dma_pages()
if (npages == 0 && !dying)
// This one does nothing
ib_umem_odp_unmap_dma_pages()
if (npages == 0 && !dying)
dying = 1;
dying = 1;
schedule_work(&umem_odp->work);
// Double schedule of the same work
schedule_work(&umem_odp->work); // BOOM
npages and dying must be read and written under the umem_mutex lock.
Since whenever ib_umem_odp_unmap_dma_pages() is called mlx5 must also call
mlx5_ib_update_xlt, and both need to be done in the same locking region,
hoist the lock out of unmap.
This avoids an expensive double critical section in
mlx5_ib_invalidate_range().
Fixes:
|
||
|---|---|---|
| .. | ||
| ah.c | ||
| cmd.c | ||
| cmd.h | ||
| cong.c | ||
| cq.c | ||
| devx.c | ||
| doorbell.c | ||
| flow.c | ||
| gsi.c | ||
| ib_rep.c | ||
| ib_rep.h | ||
| ib_virt.c | ||
| Kconfig | ||
| mad.c | ||
| main.c | ||
| Makefile | ||
| mem.c | ||
| mlx5_ib.h | ||
| mr.c | ||
| odp.c | ||
| qp.c | ||
| srq_cmd.c | ||
| srq.c | ||
| srq.h | ||