Takashi Iwai 113ce08109 ALSA: pcm: Don't suspend stream in unrecoverable PCM state ... Currently PCM core sets each opened stream forcibly to SUSPENDED state via snd_pcm_suspend_all() call, and the user-space is responsible for re-triggering the resume manually either via snd_pcm_resume() or prepare call. The scheme works fine usually, but there are corner cases where the stream can't be resumed by that call: the streams still in OPEN state before finishing hw_params. When they are suspended, user-space cannot perform resume or prepare because they haven't been set up yet. The only possible recovery is to re-open the device, which isn't nice at all. Similarly, when a stream is in DISCONNECTED state, it makes no sense to change it to SUSPENDED state. Ditto for in SETUP state; which you can re-prepare directly. So, this patch addresses these issues by filtering the PCM streams to be suspended by checking the PCM state. When a stream is in either OPEN, SETUP or DISCONNECTED as well as already SUSPENDED, the suspend action is skipped. To be noted, this problem was originally reported for the PCM runtime PM on HD-audio. And, the runtime PM problem itself was already addressed (although not intended) by the code refactoring commits 3d21ef0b49 ("ALSA: pcm: Suspend streams globally via device type PM ops") and 17bc4815de ("ALSA: pci: Remove superfluous snd_pcm_suspend*() calls"). These commits eliminated the snd_pcm_suspend*() calls from the runtime PM suspend callback code path, hence the racy OPEN state won't appear while runtime PM. (FWIW, the race window is between snd_pcm_open_substream() and the first power up in azx_pcm_open().) Although the runtime PM issue was already "fixed", the same problem is still present for the system PM, hence this patch is still needed. And for stable trees, this patch alone should suffice for fixing the runtime PM problem, too. Reported-and-tested-by: Jon Hunter <jonathanh@nvidia.com> Cc: <stable@vger.kernel.org> Signed-off-by: Takashi Iwai <tiwai@suse.de>		2019-03-25 16:36:30 +01:00
..
oss	ALSA: pcm: Fix possible OOB access in PCM oss plugins	2019-03-22 16:27:03 +01:00
seq	ALSA: seq: oss: Fix Spectre v1 vulnerability	2019-03-21 13:23:51 +01:00
compress_offload.c	ALSA: compress: Remove superfluous snd_info_register() calls	2019-02-06 18:11:54 +01:00
control_compat.c
control.c	ALSA: control: Consolidate helpers for adding and replacing ctl elements	2018-11-24 20:04:10 +01:00
ctljack.c
device.c
hrtimer.c
hwdep_compat.c
hwdep.c
info_oss.c
info.c	ALSA: info: Move card id proc creation into info.c	2019-02-06 18:11:58 +01:00
init.c	ALSA: info: Move card id proc creation into info.c	2019-02-06 18:11:58 +01:00
isadma.c
jack.c
Kconfig	docs: Fix some broken references	2018-06-15 18:10:01 -03:00
Makefile
memalloc.c	ALSA: core: Don't allow NULL device for memory allocation	2019-02-05 11:05:26 +01:00
memory.c
misc.c
pcm_compat.c
pcm_dmaengine.c
pcm_drm_eld.c
pcm_iec958.c
pcm_lib.c	ALSA: pcm: Comment why read blocks when PCM is not running	2019-02-13 08:01:05 +01:00
pcm_local.h	ALSA: pcm: Unify snd_pcm_group initialization	2019-01-21 16:39:35 +01:00
pcm_memory.c	ALSA: pcm: Define snd_pcm_lib_preallocate_*() as returning void	2019-02-08 14:24:12 +01:00
pcm_misc.c
pcm_native.c	ALSA: pcm: Don't suspend stream in unrecoverable PCM state	2019-03-25 16:36:30 +01:00
pcm_param_trace.h
pcm_timer.c
pcm_trace.h
pcm.c	ALSA: pcm: Remove superfluous snd_info_register() calls	2019-02-06 18:11:54 +01:00
rawmidi_compat.c
rawmidi.c	ALSA: rawmidi: Fix potential Spectre v1 vulnerability	2019-03-21 13:21:15 +01:00
seq_device.c
sgbuf.c	ALSA: memalloc: Add non-cached buffer type	2018-08-28 13:56:47 +02:00
sound_oss.c
sound.c
timer_compat.c
timer.c	ALSA: timer: catch invalid timer object creation	2018-07-22 10:42:41 +02:00
vmaster.c