Dave Chinner 9b9fc2b760 xfs: log ticket reservation underestimates the number of iclogs ... When allocation a ticket for a transaction, the ticket is initialised with the worst case log space usage based on the number of bytes the transaction may consume. Part of this calculation is the number of log headers required for the iclog space used up by the transaction. This calculation makes an undocumented assumption that if the transaction uses the log header space reservation on an iclog, then it consumes either the entire iclog or it completes. That is - the transaction that is first in an iclog is the transaction that the log header reservation is accounted to. If the transaction is larger than the iclog, then it will use the entire iclog itself. Document this assumption. Further, the current calculation uses the rule that we can fit iclog_size bytes of transaction data into an iclog. This is in correct - the amount of space available in an iclog for transaction data is the size of the iclog minus the space used for log record headers. This means that the calculation is out by 512 bytes per 32k of log space the transaction can consume. This is rarely an issue because maximally sized transactions are extremely uncommon, and for 4k block size filesystems maximal transaction reservations are about 400kb. Hence the error in this case is less than the size of an iclog, so that makes it even harder to hit. However, anyone using larger directory blocks (16k directory blocks push the maximum transaction size to approx. 900k on a 4k block size filesystem) or larger block size (e.g. 64k blocks push transactions to the 3-4MB size) could see the error grow to more than an iclog and at this point the transaction is guaranteed to get a reservation underrun and shutdown the filesystem. Fix this by adjusting the calculation to calculate the correct number of iclogs required and account for them all up front. Signed-off-by: Dave Chinner <dchinner@redhat.com> Reviewed-by: Christoph Hellwig <hch@lst.de>		2010-05-19 09:58:09 -05:00
..
linux-2.6	xfs: Add inode pin counts to traces	2010-05-19 09:58:08 -05:00
quota	xfs: remove stale parameter from ->iop_unpin method	2010-05-19 09:58:08 -05:00
support	xfs: event tracing support	2009-12-14 23:08:16 -06:00
Kconfig	xfs: use generic Posix ACL code	2009-06-10 17:07:47 +02:00
Makefile	xfs: merge xfs_lrw.c into xfs_file.c	2010-03-01 16:34:18 -06:00
xfs_acl.h	xfs: convert attr to use unsigned names	2010-01-20 10:47:48 +11:00
xfs_ag.h	xfs: add a shrinker to background inode reclaim	2010-04-29 16:22:13 -05:00
xfs_alloc_btree.c	xfs: Don't directly reference m_perag in allocation code	2010-01-15 15:33:12 -06:00
xfs_alloc_btree.h	[XFS] Always use struct xfs_btree_block instead of short / longform	2008-10-30 17:14:34 +11:00
xfs_alloc.c	xfs: cleanup up xfs_log_force calling conventions	2010-01-21 13:44:49 -06:00
xfs_alloc.h	xfs: event tracing support	2009-12-14 23:08:16 -06:00
xfs_arch.h	xfs: use generic Posix ACL code	2009-06-10 17:07:47 +02:00
xfs_attr_leaf.c	xfs: remove duplicate buffer flags	2010-01-21 13:44:36 -06:00
xfs_attr_leaf.h	[XFS] Remove macro-to-function indirections in attr code	2009-01-09 15:46:44 +11:00
xfs_attr_sf.h	xfs: convert attr to use unsigned names	2010-01-20 10:47:48 +11:00
xfs_attr.c	xfs: remove duplicate buffer flags	2010-01-21 13:44:36 -06:00
xfs_attr.h	xfs: convert attr to use unsigned names	2010-01-20 10:47:48 +11:00
xfs_bit.c	[XFS] Use the generic bitops rather than implementing them ourselves.	2008-08-13 15:41:12 +10:00
xfs_bit.h	[XFS] Remove macro-to-function indirections in the mask code	2009-01-09 15:53:54 +11:00
xfs_bmap_btree.c	xfs: make several more functions static	2010-01-15 15:31:38 -06:00
xfs_bmap_btree.h	xfs: make several more functions static	2010-01-15 15:31:38 -06:00
xfs_bmap.c	xfs: fix reservation release commit flag in xfs_bmap_add_attrfork()	2010-05-19 09:58:08 -05:00
xfs_bmap.h	xfs: event tracing support	2009-12-14 23:08:16 -06:00
xfs_btree_trace.c	[XFS] make btree tracing generic	2008-10-30 16:58:50 +11:00
xfs_btree_trace.h	xfs: event tracing support	2009-12-14 23:08:16 -06:00
xfs_btree.c	xfs: remove duplicate buffer flags	2010-01-21 13:44:36 -06:00
xfs_btree.h	xfs: add more statics & drop some unused functions	2009-08-31 14:46:20 -05:00
xfs_buf_item.c	xfs: remove stale parameter from ->iop_unpin method	2010-05-19 09:58:08 -05:00
xfs_buf_item.h	xfs: event tracing support	2009-12-14 23:08:16 -06:00
xfs_da_btree.c	xfs: convert dirnameops to unsigned char names	2010-01-20 10:47:17 +11:00
xfs_da_btree.h	xfs: convert dirnameops to unsigned char names	2010-01-20 10:47:17 +11:00
xfs_dfrag.c	xfs: more swap extent fixes for dynamic fork offsets	2010-04-26 12:38:51 -05:00
xfs_dfrag.h	xfs: clean up inconsistent variable naming in xfs_swap_extent	2010-01-15 15:31:23 -06:00
xfs_dinode.h	xfs: remove m_litino	2009-03-29 09:51:14 +02:00
xfs_dir2_block.c	xfs: clean up sign warnings in dir2 code	2010-01-20 10:48:05 +11:00
xfs_dir2_block.h
xfs_dir2_data.c	[XFS] Name operation vector for hash and compare	2008-07-28 16:58:36 +10:00
xfs_dir2_data.h	xfs: fix various typos	2009-03-29 09:55:42 +02:00
xfs_dir2_leaf.c	xfs: clean up sign warnings in dir2 code	2010-01-20 10:48:05 +11:00
xfs_dir2_leaf.h
xfs_dir2_node.c	xfs: make several more functions static	2010-01-15 15:31:38 -06:00
xfs_dir2_node.h	xfs: make several more functions static	2010-01-15 15:31:38 -06:00
xfs_dir2_sf.c	xfs: clean up sign warnings in dir2 code	2010-01-20 10:48:05 +11:00
xfs_dir2_sf.h	[XFS] kill xfs_dinode_core_t	2008-12-01 11:37:35 +11:00
xfs_dir2.c	xfs: clean up sign warnings in dir2 code	2010-01-20 10:48:05 +11:00
xfs_dir2.h	xfs: make xfs_dir_cilookup_result use unsigned char	2010-01-20 10:47:25 +11:00
xfs_dmapi.h	removed unused #include <linux/version.h>'s	2008-08-23 12:14:12 -07:00
xfs_dmops.c	[XFS] kill struct xfs_mount_args	2008-10-30 17:53:24 +11:00
xfs_error.c	[XFS] avoid memory allocations in xfs_fs_vcmn_err	2008-12-22 18:02:01 +11:00
xfs_error.h	[XFS] avoid memory allocations in xfs_fs_vcmn_err	2008-12-22 18:02:01 +11:00
xfs_extfree_item.c	xfs: remove stale parameter from ->iop_unpin method	2010-05-19 09:58:08 -05:00
xfs_extfree_item.h	[XFS] remove always-true #ifndef HAVE_FORMAT32 tests	2009-01-22 14:07:31 +11:00
xfs_filestream.c	xfs: Kill filestreams cache flush	2010-01-15 15:34:22 -06:00
xfs_filestream.h	xfs: Kill filestreams cache flush	2010-01-15 15:34:22 -06:00
xfs_fs.h	xfs: return inode fork offset in bulkstat for fsr	2010-03-05 11:02:07 -06:00
xfs_fsops.c	xfs: Replace per-ag array with a radix tree	2010-01-15 15:33:52 -06:00
xfs_fsops.h	filesystem freeze: add error handling of write_super_lockfs/unlockfs	2009-01-09 16:54:42 -08:00
xfs_ialloc_btree.c	xfs: fix various typos	2009-03-29 09:55:42 +02:00
xfs_ialloc_btree.h	xfs: remove superflous inobt macros	2009-02-09 08:37:14 +01:00
xfs_ialloc.c	xfs: remove duplicate buffer flags	2010-01-21 13:44:36 -06:00
xfs_ialloc.h	xfs: rationalize xfs_inobt_lookup*	2009-09-01 12:45:39 -05:00
xfs_iget.c	xfs: fix locking for inode cache radix tree tag updates	2010-03-01 19:14:36 -06:00
xfs_inode_item.c	xfs: remove stale parameter from ->iop_unpin method	2010-05-19 09:58:08 -05:00
xfs_inode_item.h	xfs: Don't issue buffer IO direct from AIL push V2	2010-02-02 10:13:42 +11:00
xfs_inode.c	xfs: Add inode pin counts to traces	2010-05-19 09:58:08 -05:00
xfs_inode.h	xfs: remove xfs_ipin/xfs_iunpin	2010-03-01 16:35:56 -06:00
xfs_inum.h	xfs: remove XFS_INO64_OFFSET	2009-08-31 14:46:22 -05:00
xfs_iomap.c	xfs: event tracing support	2009-12-14 23:08:16 -06:00
xfs_iomap.h	xfs: event tracing support	2009-12-14 23:08:16 -06:00
xfs_itable.c	xfs: return inode fork offset in bulkstat for fsr	2010-03-05 11:02:07 -06:00
xfs_itable.h	xfs: add more statics & drop some unused functions	2009-08-31 14:46:20 -05:00
xfs_log_priv.h	xfs: make several more functions static	2010-01-15 15:31:38 -06:00
xfs_log_recover.c	xfs: cleanup up xfs_log_force calling conventions	2010-01-21 13:44:49 -06:00
xfs_log_recover.h	xfs: Use list_heads for log recovery item lists	2010-01-15 15:31:51 -06:00
xfs_log.c	xfs: log ticket reservation underestimates the number of iclogs	2010-05-19 09:58:09 -05:00
xfs_log.h	xfs: factor log item initialisation	2010-05-19 09:58:07 -05:00
xfs_mount.c	xfs: Increase the default size of the reserved blocks pool	2010-03-05 11:01:59 -06:00
xfs_mount.h	xfs: add a shrinker to background inode reclaim	2010-04-29 16:22:13 -05:00
xfs_mru_cache.c	xfs: Kill filestreams cache flush	2010-01-15 15:34:22 -06:00
xfs_mru_cache.h	xfs: Kill filestreams cache flush	2010-01-15 15:34:22 -06:00
xfs_quota.h	xfs: kill the unused XFS_QMOPT_* flush flags V2	2010-02-04 09:48:58 +11:00
xfs_refcache.h
xfs_rename.c	xfs: event tracing support	2009-12-14 23:08:16 -06:00
xfs_rtalloc.c	xfs: fix missing error check in xfs_rtfree_range	2010-01-15 13:46:19 -06:00
xfs_rtalloc.h	xfs: fix various typos	2009-03-29 09:55:42 +02:00
xfs_rw.c	xfs: only clear the suid bit once in xfs_write	2010-02-12 13:43:57 -06:00
xfs_rw.h	xfs: only clear the suid bit once in xfs_write	2010-02-12 13:43:57 -06:00
xfs_sb.h	[XFS] Remove the rest of the macro-to-function indirections.	2009-01-19 14:45:55 +11:00
xfs_trans_ail.c	xfs: Don't issue buffer IO direct from AIL push V2	2010-02-02 10:13:42 +11:00
xfs_trans_buf.c	xfs: remove stale parameter from ->iop_unpin method	2010-05-19 09:58:08 -05:00
xfs_trans_extfree.c
xfs_trans_inode.c	xfs: simplify xfs_trans_iget	2009-09-01 12:46:16 -05:00
xfs_trans_item.c	xfs: fix various typos	2009-03-29 09:55:42 +02:00
xfs_trans_priv.h	[XFS] Finish removing the mount pointer from the AIL API	2008-10-30 17:39:58 +11:00
xfs_trans_space.h	xfs: remove superflous inobt macros	2009-02-09 08:37:14 +01:00
xfs_trans.c	xfs: Clean up xfs_trans_committed code after factoring	2010-05-19 09:58:09 -05:00
xfs_trans.h	xfs: remove stale parameter from ->iop_unpin method	2010-05-19 09:58:08 -05:00
xfs_types.h	xfs: directory names are unsigned	2010-01-20 10:44:58 +11:00
xfs_utils.c	xfs: kill xfs_qmops	2009-06-08 15:33:32 +02:00
xfs_utils.h	[XFS] implement IHOLD/IRELE directly	2008-08-13 16:13:45 +10:00
xfs_vnodeops.c	xfs: remove wrapper for the fsync file operation	2010-03-01 16:34:38 -06:00
xfs_vnodeops.h	xfs: kill xfs_lrw.h	2010-03-01 16:35:44 -06:00
xfs.h	xfs: event tracing support	2009-12-14 23:08:16 -06:00