Victor Kamensky 9b20065351 perf symbols: Take into account symfs setting when reading file build ID ... After commit 5baecbcd9c ("perf symbols: we can now read separate debug-info files based on a build ID") and when --symfs option is used perf failed to pick up symbols for file with the same name between host and sysroot specified by --symfs option. One can see message like this: bin/bash with build id 26f0062cb6950d4d1ab0fd9c43eae8b10ca42062 not found, continuing without symbols It happens because code added by 5baecbcd9c opens files directly by dso->long_name without symbol_conf.symfs consideration, which as result picks one from the host. It reads its build ID and later even code finds another proper file in directory pointed by --symfs perf ignores it because build id mismatches. Fix is to use __symbol__join_symfs to adjust file name according to --symfs setting. If no --symfs passed the operation would noop and picks the same host file as before. Also note in latter tree after 5baecbcd9c commit additional check for '!dso->has_build_id' was added, so to observe error condition 'perf record' should run with --no-buildid, so perf.data itself would not have build id for target binary in buildid perf section and 'perf report' will pass '!dso->has_build_id' condition. Or target binary should not have build id, but the same binary on host has build id, again '!dso->has_build_id' will pass in this case and incorrect build id could be read if --symfs is used. Signed-off-by: Victor Kamensky <kamensky@cisco.com> Cc: Adrian Hunter <adrian.hunter@intel.com> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com> Cc: Chris Phlipot <cphlipot0@gmail.com> Cc: Dima Kogan <dima@secretsauce.net> Cc: He Kuang <hekuang@huawei.com> Cc: Kan Liang <kan.liang@intel.com> Cc: Masami Hiramatsu <mhiramat@kernel.org> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Wang Nan <wangnan0@huawei.com> Cc: xe-linux-external@cisco.com Fixes: 5baecbcd9c ("perf symbols: we can now read separate debug-info files based on a build ID") Link: http://lkml.kernel.org/r/1486424908-17094-1-git-send-email-kamensky@cisco.com Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>		2017-02-08 09:28:55 -03:00
..
accounting
arch	tools headers: Sync {tools/,}arch/powerpc/include/uapi/asm/kvm.h, {tools/,}arch/x86/include/asm/cpufeatures.h and {tools/,}arch/arm/include/uapi/asm/kvm.h	2017-01-30 16:01:20 -03:00
build	tools build: Add tools tree support for 'make -s'	2017-01-26 16:29:00 -03:00
cgroup
firewire
gpio	Merge branch 'kbuild' of git://git.kernel.org/pub/scm/linux/kernel/git/mmarek/kbuild	2016-12-17 16:24:13 -08:00
hv
iio
include	Merge branch 'perf-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2016-12-23 16:49:12 -08:00
kvm/kvm_stat
laptop
leds
lguest
lib	perf sdt: Show proper hint when event not yet in place via 'perf probe'	2017-02-08 09:28:54 -03:00
net
nfsd
objtool	objtool: Fix IRET's opcode	2017-01-19 08:39:44 +01:00
pcmcia
perf	perf symbols: Take into account symfs setting when reading file build ID	2017-02-08 09:28:55 -03:00
power	Merge branch 'turbostat' of git://git.kernel.org/pub/scm/linux/kernel/git/lenb/linux	2016-12-25 14:01:28 -08:00
scripts	tools build: Add tools tree support for 'make -s'	2017-01-26 16:29:00 -03:00
spi
testing	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2017-01-27 12:54:16 -08:00
thermal/tmon
time
usb
virtio	tools/virtio/ringtest: tweaks for s390	2017-01-19 23:46:32 +02:00
vm
Makefile