mirror of
https://github.com/AuxXxilium/linux_dsm_epyc7002.git
synced 2024-12-28 11:18:45 +07:00
37e1244a79
The current codebase makes use of the zero-length array language
extension to the C90 standard, but the preferred mechanism to declare
variable-length types such as these ones is a flexible array member[1][2],
introduced in C99:
struct foo {
int stuff;
struct boo array[];
};
By making use of the mechanism above, we will get a compiler warning
in case the flexible array does not occur last in the structure, which
will help us prevent some kind of undefined behavior bugs from being
inadvertently introduced[3] to the codebase from now on.
Also, notice that, dynamic memory allocations won't be affected by
this change:
"Flexible array members have incomplete type, and so the sizeof operator
may not be applied. As a quirk of the original implementation of
zero-length arrays, sizeof evaluates to zero."[1]
This issue was found with the help of Coccinelle.
[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit
|
||
---|---|---|
.. | ||
lmc | ||
.gitignore | ||
c101.c | ||
cosa.c | ||
cosa.h | ||
dlci.c | ||
farsync.c | ||
farsync.h | ||
fsl_ucc_hdlc.c | ||
fsl_ucc_hdlc.h | ||
hd64570.c | ||
hd64570.h | ||
hd64572.c | ||
hd64572.h | ||
hdlc_cisco.c | ||
hdlc_fr.c | ||
hdlc_ppp.c | ||
hdlc_raw_eth.c | ||
hdlc_raw.c | ||
hdlc_x25.c | ||
hdlc.c | ||
hostess_sv11.c | ||
ixp4xx_hss.c | ||
Kconfig | ||
lapbether.c | ||
Makefile | ||
n2.c | ||
pc300too.c | ||
pci200syn.c | ||
sbni.c | ||
sbni.h | ||
sdla.c | ||
sealevel.c | ||
slic_ds26522.c | ||
slic_ds26522.h | ||
wanxl.c | ||
wanxl.h | ||
wanxlfw.inc_shipped | ||
wanxlfw.S | ||
x25_asy.c | ||
x25_asy.h | ||
z85230.c | ||
z85230.h |