Maxim Levitsky 9883764ad0 SVM: nSVM: correctly restore GIF on vmexit from nesting after migration ... Currently code in svm_set_nested_state copies the current vmcb control area to L1 control area (hsave->control), under assumption that it mostly reflects the defaults that kvm choose, and later qemu overrides these defaults with L2 state using standard KVM interfaces, like KVM_SET_REGS. However nested GIF (which is AMD specific thing) is by default is true, and it is copied to hsave area as such. This alone is not a big deal since on VMexit, GIF is always set to false, regardless of what it was on VM entry. However in nested_svm_vmexit we were first were setting GIF to false, but then we overwrite the control fields with value from the hsave area. (including the nested GIF field itself if GIF virtualization is enabled). Now on normal vm entry this is not a problem, since GIF is usually false prior to normal vm entry, and this is the value that copied to hsave, and then restored, but this is not always the case when the nested state is loaded as explained above. To fix this issue, move svm_set_gif after we restore the L1 control state in nested_svm_vmexit, so that even with wrong GIF in the saved L1 control area, we still clear GIF as the spec says. Signed-off-by: Maxim Levitsky <mlevitsk@redhat.com> Message-Id: <20200827162720.278690-2-mlevitsk@redhat.com> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>		2020-09-12 12:19:06 -04:00
..
avic.c	KVM: SVM: Add vmcb_ prefix to mark_*() functions	2020-07-08 16:21:48 -04:00
nested.c	SVM: nSVM: correctly restore GIF on vmexit from nesting after migration	2020-09-12 12:19:06 -04:00
pmu.c	KVM: x86/pmu: Tweak kvm_pmu_get_msr to pass 'struct msr_data' in	2020-06-01 04:26:08 -04:00
sev.c	KVM: SVM: Periodically schedule when unregistering regions on destroy	2020-09-11 13:24:15 -04:00
svm.c	KVM: SVM: avoid emulation with stale next_rip	2020-09-12 02:19:23 -04:00
svm.h	KVM: nSVM: prepare to handle errors from enter_svm_guest_mode()	2020-07-10 12:55:13 -04:00
vmenter.S	x86/kvm/svm: Move guest enter/exit into .noinstr.text	2020-07-09 07:08:41 -04:00