mirror of
https://github.com/AuxXxilium/linux_dsm_epyc7002.git
synced 2024-12-28 11:18:45 +07:00
65dc2f1a44
The current codebase makes use of the zero-length array language
extension to the C90 standard, but the preferred mechanism to declare
variable-length types such as these ones is a flexible array member[1][2],
introduced in C99:
struct foo {
int stuff;
struct boo array[];
};
By making use of the mechanism above, we will get a compiler warning
in case the flexible array does not occur last in the structure, which
will help us prevent some kind of undefined behavior bugs from being
inadvertently introduced[3] to the codebase from now on.
Also, notice that, dynamic memory allocations won't be affected by
this change:
"Flexible array members have incomplete type, and so the sizeof operator
may not be applied. As a quirk of the original implementation of
zero-length arrays, sizeof evaluates to zero."[1]
This issue was found with the help of Coccinelle.
[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit 7649773293 ("cxgb3/l2t: Fix undefined behaviour")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
71 lines
2.5 KiB
C
71 lines
2.5 KiB
C
/*
|
|
* This file is part of the Chelsio T4 Ethernet driver for Linux.
|
|
*
|
|
* Copyright (c) 2003-2014 Chelsio Communications, Inc. All rights reserved.
|
|
*
|
|
* This software is available to you under a choice of one of two
|
|
* licenses. You may choose to be licensed under the terms of the GNU
|
|
* General Public License (GPL) Version 2, available from the file
|
|
* COPYING in the main directory of this source tree, or the
|
|
* OpenIB.org BSD license below:
|
|
*
|
|
* Redistribution and use in source and binary forms, with or
|
|
* without modification, are permitted provided that the following
|
|
* conditions are met:
|
|
*
|
|
* - Redistributions of source code must retain the above
|
|
* copyright notice, this list of conditions and the following
|
|
* disclaimer.
|
|
*
|
|
* - Redistributions in binary form must reproduce the above
|
|
* copyright notice, this list of conditions and the following
|
|
* disclaimer in the documentation and/or other materials
|
|
* provided with the distribution.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
|
|
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
|
|
* MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
|
|
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS
|
|
* BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN
|
|
* ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
|
|
* CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
|
|
* SOFTWARE.
|
|
*/
|
|
|
|
#ifndef __CXGB4_DEBUGFS_H
|
|
#define __CXGB4_DEBUGFS_H
|
|
|
|
#include <linux/export.h>
|
|
|
|
struct t4_debugfs_entry {
|
|
const char *name;
|
|
const struct file_operations *ops;
|
|
umode_t mode;
|
|
unsigned char data;
|
|
};
|
|
|
|
struct seq_tab {
|
|
int (*show)(struct seq_file *seq, void *v, int idx);
|
|
unsigned int rows; /* # of entries */
|
|
unsigned char width; /* size in bytes of each entry */
|
|
unsigned char skip_first; /* whether the first line is a header */
|
|
char data[]; /* the table data */
|
|
};
|
|
|
|
static inline unsigned int hex2val(char c)
|
|
{
|
|
return isdigit(c) ? c - '0' : tolower(c) - 'a' + 10;
|
|
}
|
|
|
|
struct seq_tab *seq_open_tab(struct file *f, unsigned int rows,
|
|
unsigned int width, unsigned int have_header,
|
|
int (*show)(struct seq_file *seq, void *v, int i));
|
|
|
|
int t4_setup_debugfs(struct adapter *adap);
|
|
void add_debugfs_files(struct adapter *adap,
|
|
struct t4_debugfs_entry *files,
|
|
unsigned int nfiles);
|
|
int mem_open(struct inode *inode, struct file *file);
|
|
|
|
#endif
|