mirror of
https://github.com/AuxXxilium/linux_dsm_epyc7002.git
synced 2024-11-30 12:46:40 +07:00
912ad92220
The bug occurred to me when a UML left an empty ~/.uml/Sarge-norm folder - when trying to reuse not_dead_yet() failed one of its check. The comment says that's ok and means that we can take the directory, but while normally not_dead_yet() removes it and returns 0 (i.e. go on, use this), on failure it returns 0 but forgets to remove it. The fix is to remove it anytime we're going to return 0. But since "not_dead_yet" didn't make the interface so clear, causing this bug, and I couldn't find a convenient name for the mix of things it did, I split it into two parts: is_umdir_used() - returns a boolean, contains all checks of not_dead_yet() umdir_take_if_dead - tries to remove the dir unless it's used - returns whether it removed it, that is we now own it. With this changes the control flow is IMHO a bit clearer and needs less comment for control flow. Signed-off-by: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it> Cc: Jeff Dike <jdike@addtoit.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org> |
||
|---|---|---|
| .. | ||
| drivers | ||
| include | ||
| skas | ||
| sys-i386 | ||
| sys-x86_64 | ||
| aio.c | ||
| elf_aux.c | ||
| file.c | ||
| helper.c | ||
| irq.c | ||
| main.c | ||
| Makefile | ||
| mem.c | ||
| process.c | ||
| sigio.c | ||
| signal.c | ||
| start_up.c | ||
| time.c | ||
| tls.c | ||
| trap.c | ||
| tt.c | ||
| tty_log.c | ||
| tty.c | ||
| uaccess.c | ||
| umid.c | ||
| user_syms.c | ||
| util.c | ||