mirror of
https://github.com/AuxXxilium/linux_dsm_epyc7002.git
synced 2024-12-21 00:20:08 +07:00
91291d9ad9
Joonyoung Shim reported an interesting problem on his ARM octa-core Odoroid-XU3 platform. During system suspend, dev_pm_opp_put_regulator() was failing for a struct device for which dev_pm_opp_set_regulator() is called earlier. This happened because an earlier call to dev_pm_opp_of_cpumask_remove_table() function (from cpufreq-dt.c file) removed all the entries from opp_table->dev_list apart from the last CPU device in the cpumask of CPUs sharing the OPP. But both dev_pm_opp_set_regulator() and dev_pm_opp_put_regulator() routines get CPU device for the first CPU in the cpumask. And so the OPP core failed to find the OPP table for the struct device. This patch attempts to fix this problem by returning a pointer to the opp_table from dev_pm_opp_set_regulator() and using that as the parameter to dev_pm_opp_put_regulator(). This ensures that the dev_pm_opp_put_regulator() doesn't fail to find the opp table. Note that similar design problem also exists with other dev_pm_opp_put_*() APIs, but those aren't used currently by anyone and so we don't need to update them for now. Cc: 4.4+ <stable@vger.kernel.org> # 4.4+ Reported-by: Joonyoung Shim <jy0922.shim@samsung.com> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> [ Viresh: Wrote commit log and tested on exynos 5250 ] Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
238 lines
6.1 KiB
C
238 lines
6.1 KiB
C
/*
|
|
* Generic OPP Interface
|
|
*
|
|
* Copyright (C) 2009-2010 Texas Instruments Incorporated.
|
|
* Nishanth Menon
|
|
* Romit Dasgupta
|
|
* Kevin Hilman
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License version 2 as
|
|
* published by the Free Software Foundation.
|
|
*/
|
|
|
|
#ifndef __LINUX_OPP_H__
|
|
#define __LINUX_OPP_H__
|
|
|
|
#include <linux/err.h>
|
|
#include <linux/notifier.h>
|
|
|
|
struct dev_pm_opp;
|
|
struct device;
|
|
struct opp_table;
|
|
|
|
enum dev_pm_opp_event {
|
|
OPP_EVENT_ADD, OPP_EVENT_REMOVE, OPP_EVENT_ENABLE, OPP_EVENT_DISABLE,
|
|
};
|
|
|
|
#if defined(CONFIG_PM_OPP)
|
|
|
|
unsigned long dev_pm_opp_get_voltage(struct dev_pm_opp *opp);
|
|
|
|
unsigned long dev_pm_opp_get_freq(struct dev_pm_opp *opp);
|
|
|
|
bool dev_pm_opp_is_turbo(struct dev_pm_opp *opp);
|
|
|
|
int dev_pm_opp_get_opp_count(struct device *dev);
|
|
unsigned long dev_pm_opp_get_max_clock_latency(struct device *dev);
|
|
unsigned long dev_pm_opp_get_max_volt_latency(struct device *dev);
|
|
unsigned long dev_pm_opp_get_max_transition_latency(struct device *dev);
|
|
struct dev_pm_opp *dev_pm_opp_get_suspend_opp(struct device *dev);
|
|
|
|
struct dev_pm_opp *dev_pm_opp_find_freq_exact(struct device *dev,
|
|
unsigned long freq,
|
|
bool available);
|
|
|
|
struct dev_pm_opp *dev_pm_opp_find_freq_floor(struct device *dev,
|
|
unsigned long *freq);
|
|
|
|
struct dev_pm_opp *dev_pm_opp_find_freq_ceil(struct device *dev,
|
|
unsigned long *freq);
|
|
|
|
int dev_pm_opp_add(struct device *dev, unsigned long freq,
|
|
unsigned long u_volt);
|
|
void dev_pm_opp_remove(struct device *dev, unsigned long freq);
|
|
|
|
int dev_pm_opp_enable(struct device *dev, unsigned long freq);
|
|
|
|
int dev_pm_opp_disable(struct device *dev, unsigned long freq);
|
|
|
|
struct srcu_notifier_head *dev_pm_opp_get_notifier(struct device *dev);
|
|
int dev_pm_opp_set_supported_hw(struct device *dev, const u32 *versions,
|
|
unsigned int count);
|
|
void dev_pm_opp_put_supported_hw(struct device *dev);
|
|
int dev_pm_opp_set_prop_name(struct device *dev, const char *name);
|
|
void dev_pm_opp_put_prop_name(struct device *dev);
|
|
struct opp_table *dev_pm_opp_set_regulator(struct device *dev, const char *name);
|
|
void dev_pm_opp_put_regulator(struct opp_table *opp_table);
|
|
int dev_pm_opp_set_rate(struct device *dev, unsigned long target_freq);
|
|
int dev_pm_opp_set_sharing_cpus(struct device *cpu_dev, const struct cpumask *cpumask);
|
|
int dev_pm_opp_get_sharing_cpus(struct device *cpu_dev, struct cpumask *cpumask);
|
|
void dev_pm_opp_remove_table(struct device *dev);
|
|
void dev_pm_opp_cpumask_remove_table(const struct cpumask *cpumask);
|
|
#else
|
|
static inline unsigned long dev_pm_opp_get_voltage(struct dev_pm_opp *opp)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
static inline unsigned long dev_pm_opp_get_freq(struct dev_pm_opp *opp)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
static inline bool dev_pm_opp_is_turbo(struct dev_pm_opp *opp)
|
|
{
|
|
return false;
|
|
}
|
|
|
|
static inline int dev_pm_opp_get_opp_count(struct device *dev)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
static inline unsigned long dev_pm_opp_get_max_clock_latency(struct device *dev)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
static inline unsigned long dev_pm_opp_get_max_volt_latency(struct device *dev)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
static inline unsigned long dev_pm_opp_get_max_transition_latency(struct device *dev)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
static inline struct dev_pm_opp *dev_pm_opp_get_suspend_opp(struct device *dev)
|
|
{
|
|
return NULL;
|
|
}
|
|
|
|
static inline struct dev_pm_opp *dev_pm_opp_find_freq_exact(struct device *dev,
|
|
unsigned long freq, bool available)
|
|
{
|
|
return ERR_PTR(-ENOTSUPP);
|
|
}
|
|
|
|
static inline struct dev_pm_opp *dev_pm_opp_find_freq_floor(struct device *dev,
|
|
unsigned long *freq)
|
|
{
|
|
return ERR_PTR(-ENOTSUPP);
|
|
}
|
|
|
|
static inline struct dev_pm_opp *dev_pm_opp_find_freq_ceil(struct device *dev,
|
|
unsigned long *freq)
|
|
{
|
|
return ERR_PTR(-ENOTSUPP);
|
|
}
|
|
|
|
static inline int dev_pm_opp_add(struct device *dev, unsigned long freq,
|
|
unsigned long u_volt)
|
|
{
|
|
return -ENOTSUPP;
|
|
}
|
|
|
|
static inline void dev_pm_opp_remove(struct device *dev, unsigned long freq)
|
|
{
|
|
}
|
|
|
|
static inline int dev_pm_opp_enable(struct device *dev, unsigned long freq)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
static inline int dev_pm_opp_disable(struct device *dev, unsigned long freq)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
static inline struct srcu_notifier_head *dev_pm_opp_get_notifier(
|
|
struct device *dev)
|
|
{
|
|
return ERR_PTR(-ENOTSUPP);
|
|
}
|
|
|
|
static inline int dev_pm_opp_set_supported_hw(struct device *dev,
|
|
const u32 *versions,
|
|
unsigned int count)
|
|
{
|
|
return -ENOTSUPP;
|
|
}
|
|
|
|
static inline void dev_pm_opp_put_supported_hw(struct device *dev) {}
|
|
|
|
static inline int dev_pm_opp_set_prop_name(struct device *dev, const char *name)
|
|
{
|
|
return -ENOTSUPP;
|
|
}
|
|
|
|
static inline void dev_pm_opp_put_prop_name(struct device *dev) {}
|
|
|
|
static inline struct opp_table *dev_pm_opp_set_regulator(struct device *dev, const char *name)
|
|
{
|
|
return ERR_PTR(-ENOTSUPP);
|
|
}
|
|
|
|
static inline void dev_pm_opp_put_regulator(struct opp_table *opp_table) {}
|
|
|
|
static inline int dev_pm_opp_set_rate(struct device *dev, unsigned long target_freq)
|
|
{
|
|
return -ENOTSUPP;
|
|
}
|
|
|
|
static inline int dev_pm_opp_set_sharing_cpus(struct device *cpu_dev, const struct cpumask *cpumask)
|
|
{
|
|
return -ENOTSUPP;
|
|
}
|
|
|
|
static inline int dev_pm_opp_get_sharing_cpus(struct device *cpu_dev, struct cpumask *cpumask)
|
|
{
|
|
return -EINVAL;
|
|
}
|
|
|
|
static inline void dev_pm_opp_remove_table(struct device *dev)
|
|
{
|
|
}
|
|
|
|
static inline void dev_pm_opp_cpumask_remove_table(const struct cpumask *cpumask)
|
|
{
|
|
}
|
|
|
|
#endif /* CONFIG_PM_OPP */
|
|
|
|
#if defined(CONFIG_PM_OPP) && defined(CONFIG_OF)
|
|
int dev_pm_opp_of_add_table(struct device *dev);
|
|
void dev_pm_opp_of_remove_table(struct device *dev);
|
|
int dev_pm_opp_of_cpumask_add_table(const struct cpumask *cpumask);
|
|
void dev_pm_opp_of_cpumask_remove_table(const struct cpumask *cpumask);
|
|
int dev_pm_opp_of_get_sharing_cpus(struct device *cpu_dev, struct cpumask *cpumask);
|
|
#else
|
|
static inline int dev_pm_opp_of_add_table(struct device *dev)
|
|
{
|
|
return -ENOTSUPP;
|
|
}
|
|
|
|
static inline void dev_pm_opp_of_remove_table(struct device *dev)
|
|
{
|
|
}
|
|
|
|
static inline int dev_pm_opp_of_cpumask_add_table(const struct cpumask *cpumask)
|
|
{
|
|
return -ENOTSUPP;
|
|
}
|
|
|
|
static inline void dev_pm_opp_of_cpumask_remove_table(const struct cpumask *cpumask)
|
|
{
|
|
}
|
|
|
|
static inline int dev_pm_opp_of_get_sharing_cpus(struct device *cpu_dev, struct cpumask *cpumask)
|
|
{
|
|
return -ENOTSUPP;
|
|
}
|
|
#endif
|
|
|
|
#endif /* __LINUX_OPP_H__ */
|