Po-Hsu Lin 8ea899803b selftests: xfrm: fix test return value override issue in xfrm_policy.sh ... [ Upstream commit f6e9ceb7a7fc321a31a9dde93a99b7b4b016a3b3 ] When running this xfrm_policy.sh test script, even with some cases marked as FAIL, the overall test result will still be PASS: $ sudo ./xfrm_policy.sh PASS: policy before exception matches FAIL: expected ping to .254 to fail (exceptions) PASS: direct policy matches (exceptions) PASS: policy matches (exceptions) FAIL: expected ping to .254 to fail (exceptions and block policies) PASS: direct policy matches (exceptions and block policies) PASS: policy matches (exceptions and block policies) FAIL: expected ping to .254 to fail (exceptions and block policies after hresh changes) PASS: direct policy matches (exceptions and block policies after hresh changes) PASS: policy matches (exceptions and block policies after hresh changes) FAIL: expected ping to .254 to fail (exceptions and block policies after hthresh change in ns3) PASS: direct policy matches (exceptions and block policies after hthresh change in ns3) PASS: policy matches (exceptions and block policies after hthresh change in ns3) FAIL: expected ping to .254 to fail (exceptions and block policies after htresh change to normal) PASS: direct policy matches (exceptions and block policies after htresh change to normal) PASS: policy matches (exceptions and block policies after htresh change to normal) PASS: policies with repeated htresh change $ echo $? 0 This is because the $lret in check_xfrm() is not a local variable. Therefore when a test failed in check_exceptions(), the non-zero $lret will later get reset to 0 when the next test calls check_xfrm(). With this fix, the final return value will be 1. Make it easier for testers to spot this failure. Fixes: 39aa6928d4 ("xfrm: policy: fix netlink/pf_key policy lookups") Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com> Acked-by: Florian Westphal <fw@strlen.de> Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com> Signed-off-by: Sasha Levin <sashal@kernel.org>		2021-02-03 23:28:45 +01:00
..
fault-injection
ktest	ktest.pl: Fix the logic for truncating the size of the log file for email	2020-12-21 13:30:06 +01:00
kunit	kunit: tool: fix extra trailing \n in raw + parsed test output	2020-11-10 13:44:35 -07:00
nvdimm	device-dax: add dis-contiguous resource support	2020-10-13 18:38:28 -07:00
radix-tree	ida: Free allocated bitmap in error path	2020-10-07 09:11:33 -04:00
scatterlist	tools/testing/scatterlist: Fix test to compile and run	2020-11-17 20:02:20 -04:00
selftests	selftests: xfrm: fix test return value override issue in xfrm_policy.sh	2021-02-03 23:28:45 +01:00
vsock	SPDX patches for 5.7-rc1.	2020-04-03 13:12:26 -07:00