mirror of
https://github.com/AuxXxilium/linux_dsm_epyc7002.git
synced 2024-12-06 20:06:41 +07:00
3c35337576
group and project quota hints are currently stored on the user dquot. If we are attaching quotas to the inode, then the group and project dquots are stored as hints on the user dquot to save having to look them up again later. The thing is, the hints are not used for that inode for the rest of the life of the inode - the dquots are attached directly to the inode itself - so the only time the hints are used is when an inode first has dquots attached. When the hints on the user dquot don't match the dquots being attache dto the inode, they are then removed and replaced with the new hints. If a user is concurrently modifying files in different group and/or project contexts, then this leads to thrashing of the hints attached to user dquot. If user quotas are not enabled, then hints are never even used. So, if the hints are used to avoid the cost of the lookup, is the cost of the lookup significant enough to justify the hint infrstructure? Maybe it was once, when there was a global quota manager shared between all XFS filesystems and was hash table based. However, lookups are now much simpler, requiring only a single lock and radix tree lookup local to the filesystem and no hash or LRU manipulations to be made. Hence the cost of lookup is much lower than when hints were implemented. Turns out that benchmarks show that, too, with thir being no differnce in performance when doing file creation workloads as a single user with user, group and project quotas enabled - the hints do not make the code go any faster. In fact, removing the hints shows a 2-3% reduction in the time it takes to create 50 million inodes.... So, let's just get rid of the hints and the complexity around them. Signed-off-by: Dave Chinner <dchinner@redhat.com> Reviewed-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Dave Chinner <david@fromorbit.com>
174 lines
5.2 KiB
C
174 lines
5.2 KiB
C
/*
|
|
* Copyright (c) 2000-2005 Silicon Graphics, Inc.
|
|
* All Rights Reserved.
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public License as
|
|
* published by the Free Software Foundation.
|
|
*
|
|
* This program is distributed in the hope that it would be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, write the Free Software Foundation,
|
|
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
|
|
*/
|
|
#ifndef __XFS_DQUOT_H__
|
|
#define __XFS_DQUOT_H__
|
|
|
|
/*
|
|
* Dquots are structures that hold quota information about a user or a group,
|
|
* much like inodes are for files. In fact, dquots share many characteristics
|
|
* with inodes. However, dquots can also be a centralized resource, relative
|
|
* to a collection of inodes. In this respect, dquots share some characteristics
|
|
* of the superblock.
|
|
* XFS dquots exploit both those in its algorithms. They make every attempt
|
|
* to not be a bottleneck when quotas are on and have minimal impact, if any,
|
|
* when quotas are off.
|
|
*/
|
|
|
|
struct xfs_mount;
|
|
struct xfs_trans;
|
|
|
|
enum {
|
|
XFS_QLOWSP_1_PCNT = 0,
|
|
XFS_QLOWSP_3_PCNT,
|
|
XFS_QLOWSP_5_PCNT,
|
|
XFS_QLOWSP_MAX
|
|
};
|
|
|
|
/*
|
|
* The incore dquot structure
|
|
*/
|
|
typedef struct xfs_dquot {
|
|
uint dq_flags; /* various flags (XFS_DQ_*) */
|
|
struct list_head q_lru; /* global free list of dquots */
|
|
struct xfs_mount*q_mount; /* filesystem this relates to */
|
|
struct xfs_trans*q_transp; /* trans this belongs to currently */
|
|
uint q_nrefs; /* # active refs from inodes */
|
|
xfs_daddr_t q_blkno; /* blkno of dquot buffer */
|
|
int q_bufoffset; /* off of dq in buffer (# dquots) */
|
|
xfs_fileoff_t q_fileoffset; /* offset in quotas file */
|
|
|
|
xfs_disk_dquot_t q_core; /* actual usage & quotas */
|
|
xfs_dq_logitem_t q_logitem; /* dquot log item */
|
|
xfs_qcnt_t q_res_bcount; /* total regular nblks used+reserved */
|
|
xfs_qcnt_t q_res_icount; /* total inos allocd+reserved */
|
|
xfs_qcnt_t q_res_rtbcount;/* total realtime blks used+reserved */
|
|
xfs_qcnt_t q_prealloc_lo_wmark;/* prealloc throttle wmark */
|
|
xfs_qcnt_t q_prealloc_hi_wmark;/* prealloc disabled wmark */
|
|
int64_t q_low_space[XFS_QLOWSP_MAX];
|
|
struct mutex q_qlock; /* quota lock */
|
|
struct completion q_flush; /* flush completion queue */
|
|
atomic_t q_pincount; /* dquot pin count */
|
|
wait_queue_head_t q_pinwait; /* dquot pinning wait queue */
|
|
} xfs_dquot_t;
|
|
|
|
/*
|
|
* Lock hierarchy for q_qlock:
|
|
* XFS_QLOCK_NORMAL is the implicit default,
|
|
* XFS_QLOCK_NESTED is the dquot with the higher id in xfs_dqlock2
|
|
*/
|
|
enum {
|
|
XFS_QLOCK_NORMAL = 0,
|
|
XFS_QLOCK_NESTED,
|
|
};
|
|
|
|
/*
|
|
* Manage the q_flush completion queue embedded in the dquot. This completion
|
|
* queue synchronizes processes attempting to flush the in-core dquot back to
|
|
* disk.
|
|
*/
|
|
static inline void xfs_dqflock(xfs_dquot_t *dqp)
|
|
{
|
|
wait_for_completion(&dqp->q_flush);
|
|
}
|
|
|
|
static inline int xfs_dqflock_nowait(xfs_dquot_t *dqp)
|
|
{
|
|
return try_wait_for_completion(&dqp->q_flush);
|
|
}
|
|
|
|
static inline void xfs_dqfunlock(xfs_dquot_t *dqp)
|
|
{
|
|
complete(&dqp->q_flush);
|
|
}
|
|
|
|
static inline int xfs_dqlock_nowait(struct xfs_dquot *dqp)
|
|
{
|
|
return mutex_trylock(&dqp->q_qlock);
|
|
}
|
|
|
|
static inline void xfs_dqlock(struct xfs_dquot *dqp)
|
|
{
|
|
mutex_lock(&dqp->q_qlock);
|
|
}
|
|
|
|
static inline void xfs_dqunlock(struct xfs_dquot *dqp)
|
|
{
|
|
mutex_unlock(&dqp->q_qlock);
|
|
}
|
|
|
|
static inline int xfs_this_quota_on(struct xfs_mount *mp, int type)
|
|
{
|
|
switch (type & XFS_DQ_ALLTYPES) {
|
|
case XFS_DQ_USER:
|
|
return XFS_IS_UQUOTA_ON(mp);
|
|
case XFS_DQ_GROUP:
|
|
return XFS_IS_GQUOTA_ON(mp);
|
|
case XFS_DQ_PROJ:
|
|
return XFS_IS_PQUOTA_ON(mp);
|
|
default:
|
|
return 0;
|
|
}
|
|
}
|
|
|
|
static inline xfs_dquot_t *xfs_inode_dquot(struct xfs_inode *ip, int type)
|
|
{
|
|
switch (type & XFS_DQ_ALLTYPES) {
|
|
case XFS_DQ_USER:
|
|
return ip->i_udquot;
|
|
case XFS_DQ_GROUP:
|
|
return ip->i_gdquot;
|
|
case XFS_DQ_PROJ:
|
|
return ip->i_pdquot;
|
|
default:
|
|
return NULL;
|
|
}
|
|
}
|
|
|
|
#define XFS_DQ_IS_LOCKED(dqp) (mutex_is_locked(&((dqp)->q_qlock)))
|
|
#define XFS_DQ_IS_DIRTY(dqp) ((dqp)->dq_flags & XFS_DQ_DIRTY)
|
|
#define XFS_QM_ISUDQ(dqp) ((dqp)->dq_flags & XFS_DQ_USER)
|
|
#define XFS_QM_ISPDQ(dqp) ((dqp)->dq_flags & XFS_DQ_PROJ)
|
|
#define XFS_QM_ISGDQ(dqp) ((dqp)->dq_flags & XFS_DQ_GROUP)
|
|
|
|
extern int xfs_qm_dqread(struct xfs_mount *, xfs_dqid_t, uint,
|
|
uint, struct xfs_dquot **);
|
|
extern void xfs_qm_dqdestroy(xfs_dquot_t *);
|
|
extern int xfs_qm_dqflush(struct xfs_dquot *, struct xfs_buf **);
|
|
extern void xfs_qm_dqunpin_wait(xfs_dquot_t *);
|
|
extern void xfs_qm_adjust_dqtimers(xfs_mount_t *,
|
|
xfs_disk_dquot_t *);
|
|
extern void xfs_qm_adjust_dqlimits(struct xfs_mount *,
|
|
struct xfs_dquot *);
|
|
extern int xfs_qm_dqget(xfs_mount_t *, xfs_inode_t *,
|
|
xfs_dqid_t, uint, uint, xfs_dquot_t **);
|
|
extern void xfs_qm_dqput(xfs_dquot_t *);
|
|
|
|
extern void xfs_dqlock2(struct xfs_dquot *, struct xfs_dquot *);
|
|
|
|
extern void xfs_dquot_set_prealloc_limits(struct xfs_dquot *);
|
|
|
|
static inline struct xfs_dquot *xfs_qm_dqhold(struct xfs_dquot *dqp)
|
|
{
|
|
xfs_dqlock(dqp);
|
|
dqp->q_nrefs++;
|
|
xfs_dqunlock(dqp);
|
|
return dqp;
|
|
}
|
|
|
|
#endif /* __XFS_DQUOT_H__ */
|