Darrick J. Wong 2fe4f92834 xfs: refactor "does this fork map blocks" predicate ... Replace the open-coded checks for whether or not an inode fork maps blocks with a macro that will implant the code for us. This helps us declutter the bmap code a bit. Note that I had to use a macro instead of a static inline function because of C header dependency problems between xfs_inode.h and xfs_inode_fork.h. Conversion was performed with the following Coccinelle script: @@ expression ip, w; @@ - XFS_IFORK_FORMAT(ip, w) == XFS_DINODE_FMT_EXTENTS || XFS_IFORK_FORMAT(ip, w) == XFS_DINODE_FMT_BTREE + xfs_ifork_has_extents(ip, w) @@ expression ip, w; @@ - XFS_IFORK_FORMAT(ip, w) != XFS_DINODE_FMT_EXTENTS && XFS_IFORK_FORMAT(ip, w) != XFS_DINODE_FMT_BTREE + !xfs_ifork_has_extents(ip, w) @@ expression ip, w; @@ - XFS_IFORK_FORMAT(ip, w) == XFS_DINODE_FMT_BTREE || XFS_IFORK_FORMAT(ip, w) == XFS_DINODE_FMT_EXTENTS + xfs_ifork_has_extents(ip, w) @@ expression ip, w; @@ - XFS_IFORK_FORMAT(ip, w) != XFS_DINODE_FMT_BTREE && XFS_IFORK_FORMAT(ip, w) != XFS_DINODE_FMT_EXTENTS + !xfs_ifork_has_extents(ip, w) @@ expression ip, w; @@ - (xfs_ifork_has_extents(ip, w)) + xfs_ifork_has_extents(ip, w) @@ expression ip, w; @@ - (!xfs_ifork_has_extents(ip, w)) + !xfs_ifork_has_extents(ip, w) Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com> Reviewed-by: Christoph Hellwig <hch@lst.de>		2019-11-10 10:22:51 -08:00
..
xfs_ag_resv.c	xfs: fix missing header includes	2019-11-07 13:00:53 -08:00
xfs_ag_resv.h	xfs: pass transaction lock while setting up agresv on cyclic metadata	2018-07-29 22:37:08 -07:00
xfs_ag.c	xfs: remove unused flags arg from xfs_get_aghdr_buf()	2019-10-06 15:39:05 -07:00
xfs_ag.h	xfs: add a new ioctl to describe allocation group geometry	2019-04-14 18:15:57 -07:00
xfs_alloc_btree.c	xfs: track active state of allocation btree cursors	2019-10-21 09:04:58 -07:00
xfs_alloc_btree.h	xfs: convert to SPDX license tags	2018-06-06 14:17:53 -07:00
xfs_alloc.c	xfs: clean up weird while loop in xfs_alloc_ag_vextent_near	2019-11-10 10:21:58 -08:00
xfs_alloc.h	xfs: cleanup use of the XFS_ALLOC_ flags	2019-11-03 10:22:31 -08:00
xfs_attr_leaf.c	xfs: Correct comment tyops -> typos	2019-11-10 10:21:57 -08:00
xfs_attr_leaf.h	xfs: namecheck attribute names before listing them	2019-10-29 09:50:11 -07:00
xfs_attr_remote.c	xfs: fix missing header includes	2019-11-07 13:00:53 -08:00
xfs_attr_remote.h	xfs: convert to SPDX license tags	2018-06-06 14:17:53 -07:00
xfs_attr_sf.h	xfs: convert to SPDX license tags	2018-06-06 14:17:53 -07:00
xfs_attr.c	xfs: allocate xattr buffer on demand	2019-08-30 22:43:57 -07:00
xfs_attr.h	xfs: allocate xattr buffer on demand	2019-08-30 22:43:57 -07:00
xfs_bit.c	xfs: fix missing header includes	2019-11-07 13:00:53 -08:00
xfs_bit.h	xfs: convert to SPDX license tags	2018-06-06 14:17:53 -07:00
xfs_bmap_btree.c	xfs: fix sign handling problem in xfs_bmbt_diff_two_keys	2019-08-28 08:31:01 -07:00
xfs_bmap_btree.h	xfs: convert to SPDX license tags	2018-06-06 14:17:53 -07:00
xfs_bmap.c	xfs: refactor "does this fork map blocks" predicate	2019-11-10 10:22:51 -08:00
xfs_bmap.h	xfs: use a struct iomap in xfs_writepage_ctx	2019-10-21 08:51:59 -07:00
xfs_btree.c	xfs: always log corruption errors	2019-11-04 13:55:54 -08:00
xfs_btree.h	xfs: refactor xfs_iread_extents to use xfs_btree_visit_blocks	2019-10-29 09:50:12 -07:00
xfs_cksum.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
xfs_da_btree.c	xfs: decrease indenting problems in xfs_dabuf_map	2019-11-05 08:28:27 -08:00
xfs_da_btree.h	xfs: allocate xattr buffer on demand	2019-08-30 22:43:57 -07:00
xfs_da_format.c	xfs: remove unused header files	2019-06-28 19:30:43 -07:00
xfs_da_format.h	xfs: Correct comment tyops -> typos	2019-11-10 10:21:57 -08:00
xfs_defer.c	fs: xfs: Remove KM_NOSLEEP and KM_SLEEP.	2019-08-26 12:06:22 -07:00
xfs_defer.h	xfs: streamline defer op type handling	2018-12-12 08:47:16 -08:00
xfs_dir2_block.c	xfs: relax shortform directory size checks	2019-11-04 13:54:58 -08:00
xfs_dir2_data.c	xfs: remove unused header files	2019-06-28 19:30:43 -07:00
xfs_dir2_leaf.c	xfs: always log corruption errors	2019-11-04 13:55:54 -08:00
xfs_dir2_node.c	xfs: always log corruption errors	2019-11-04 13:55:54 -08:00
xfs_dir2_priv.h	xfs: convert to SPDX license tags	2018-06-06 14:17:53 -07:00
xfs_dir2_sf.c	xfs: relax shortform directory size checks	2019-11-04 13:54:58 -08:00
xfs_dir2.c	xfs: always log corruption errors	2019-11-04 13:55:54 -08:00
xfs_dir2.h	xfs: check directory name validity	2019-02-11 16:06:40 -08:00
xfs_dquot_buf.c	xfs: remove unused header files	2019-06-28 19:30:43 -07:00
xfs_errortag.h	xfs: cache unlinked pointers in an rhashtable	2019-02-11 16:07:01 -08:00
xfs_format.h	xfs: move xfs_ino_geometry to xfs_shared.h	2019-06-28 19:25:35 -07:00
xfs_fs.h	xfs: Correct comment tyops -> typos	2019-11-10 10:21:57 -08:00
xfs_health.h	xfs: introduce new v5 bulkstat structure	2019-07-03 20:36:26 -07:00
xfs_ialloc_btree.c	xfs: create simplified inode walk function	2019-07-02 09:40:05 -07:00
xfs_ialloc_btree.h	xfs: create simplified inode walk function	2019-07-02 09:40:05 -07:00
xfs_ialloc.c	xfs: fix maxicount division by zero error	2019-08-28 08:31:01 -07:00
xfs_ialloc.h	xfs: refactor inode geometry setup routines	2019-06-12 08:37:40 -07:00
xfs_iext_tree.c	xfs: fix inode fork extent count overflow	2019-10-21 09:04:58 -07:00
xfs_inode_buf.c	xfs: remove unused header files	2019-06-28 19:30:43 -07:00
xfs_inode_buf.h	xfs: convert to SPDX license tags	2018-06-06 14:17:53 -07:00
xfs_inode_fork.c	xfs: always log corruption errors	2019-11-04 13:55:54 -08:00
xfs_inode_fork.h	xfs: refactor "does this fork map blocks" predicate	2019-11-10 10:22:51 -08:00
xfs_log_format.h	xfs: Correct comment tyops -> typos	2019-11-10 10:21:57 -08:00
xfs_log_recover.h	xfs: convert to SPDX license tags	2018-06-06 14:17:53 -07:00
xfs_log_rlimit.c	xfs: remove unused header files	2019-06-28 19:30:43 -07:00
xfs_quota_defs.h	xfs: change some error-less functions to void types	2019-05-01 20:26:30 -07:00
xfs_refcount_btree.c	xfs: remove unused header files	2019-06-28 19:30:43 -07:00
xfs_refcount_btree.h	xfs: pass transaction lock while setting up agresv on cyclic metadata	2018-07-29 22:37:08 -07:00
xfs_refcount.c	xfs: always log corruption errors	2019-11-04 13:55:54 -08:00
xfs_refcount.h	xfs: remove unnecessary int returns from deferred refcount functions	2019-08-28 08:31:02 -07:00
xfs_rmap_btree.c	xfs: remove unused header files	2019-06-28 19:30:43 -07:00
xfs_rmap_btree.h	xfs: pass transaction lock while setting up agresv on cyclic metadata	2018-07-29 22:37:08 -07:00
xfs_rmap.c	xfs: remove all *_ITER_CONTINUE values	2019-08-30 22:43:56 -07:00
xfs_rmap.h	xfs: reinitialize rm_flags when unpacking an offset into an rmap irec	2019-08-28 08:31:02 -07:00
xfs_rtbitmap.c	xfs: always log corruption errors	2019-11-04 13:55:54 -08:00
xfs_sb.c	xfs: fix missing header includes	2019-11-07 13:00:53 -08:00
xfs_sb.h	xfs: change some error-less functions to void types	2019-05-01 20:26:30 -07:00
xfs_shared.h	xfs: remove all *_ITER_CONTINUE values	2019-08-30 22:43:56 -07:00
xfs_symlink_remote.c	xfs: remove unused header files	2019-06-28 19:30:43 -07:00
xfs_trans_inode.c	xfs: sync up xfs_trans_inode with userspace	2019-07-15 08:10:34 -07:00
xfs_trans_resv.c	xfs: remove unused header files	2019-06-28 19:30:43 -07:00
xfs_trans_resv.h	xfs: convert to SPDX license tags	2018-06-06 14:17:53 -07:00
xfs_trans_space.h	xfs: separate inode geometry	2019-06-12 08:37:40 -07:00
xfs_types.c	xfs: remove unused header files	2019-06-28 19:30:43 -07:00
xfs_types.h	xfs: add kmem allocation trace points	2019-08-26 17:43:14 -07:00