Andrey Ryabinin 9b75a867cc mm: mempool: kasan: don't poot mempool objects in quarantine ... Currently we may put reserved by mempool elements into quarantine via kasan_kfree(). This is totally wrong since quarantine may really free these objects. So when mempool will try to use such element, use-after-free will happen. Or mempool may decide that it no longer need that element and double-free it. So don't put object into quarantine in kasan_kfree(), just poison it. Rename kasan_kfree() to kasan_poison_kfree() to respect that. Also, we shouldn't use kasan_slab_alloc()/kasan_krealloc() in kasan_unpoison_element() because those functions may update allocation stacktrace. This would be wrong for the most of the remove_element call sites. (The only call site where we may want to update alloc stacktrace is in mempool_alloc(). Kmemleak solves this by calling kmemleak_update_trace(), so we could make something like that too. But this is out of scope of this patch). Fixes: 55834c5909 ("mm: kasan: initial memory quarantine implementation") Link: http://lkml.kernel.org/r/575977C3.1010905@virtuozzo.com Signed-off-by: Andrey Ryabinin <aryabinin@virtuozzo.com> Reported-by: Kuthonuzo Luruo <kuthonuzo.luruo@hpe.com> Acked-by: Alexander Potapenko <glider@google.com> Cc: Dmitriy Vyukov <dvyukov@google.com> Cc: Kostya Serebryany <kcc@google.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>		2016-06-24 17:23:52 -07:00
..
kasan_init.c	x86/kasan, mm: Introduce generic kasan_populate_zero_shadow()	2015-08-22 14:54:55 +02:00
kasan.c	mm: mempool: kasan: don't poot mempool objects in quarantine	2016-06-24 17:23:52 -07:00
kasan.h	mm: kasan: remove unused 'reserved' field from struct kasan_alloc_meta	2016-05-26 15:35:44 -07:00
Makefile	mm: kasan: initial memory quarantine implementation	2016-05-20 17:58:30 -07:00
quarantine.c	mm: kasan: initial memory quarantine implementation	2016-05-20 17:58:30 -07:00
report.c	mm: kasan: initial memory quarantine implementation	2016-05-20 17:58:30 -07:00