Ignat Korchagin 8727884b7f dm crypt: do not wait for backlogged crypto request completion in softirq ... commit 8abec36d1274bbd5ae8f36f3658b9abb3db56c31 upstream. Commit 39d42fa96b ("dm crypt: add flags to optionally bypass kcryptd workqueues") made it possible for some code paths in dm-crypt to be executed in softirq context, when the underlying driver processes IO requests in interrupt/softirq context. When Crypto API backlogs a crypto request, dm-crypt uses wait_for_completion to avoid sending further requests to an already overloaded crypto driver. However, if the code is executing in softirq context, we might get the following stacktrace: [ 210.235213][ C0] BUG: scheduling while atomic: fio/2602/0x00000102 [ 210.236701][ C0] Modules linked in: [ 210.237566][ C0] CPU: 0 PID: 2602 Comm: fio Tainted: G W 5.10.0+ #50 [ 210.239292][ C0] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 0.0.0 02/06/2015 [ 210.241233][ C0] Call Trace: [ 210.241946][ C0] <IRQ> [ 210.242561][ C0] dump_stack+0x7d/0xa3 [ 210.243466][ C0] __schedule_bug.cold+0xb3/0xc2 [ 210.244539][ C0] __schedule+0x156f/0x20d0 [ 210.245518][ C0] ? io_schedule_timeout+0x140/0x140 [ 210.246660][ C0] schedule+0xd0/0x270 [ 210.247541][ C0] schedule_timeout+0x1fb/0x280 [ 210.248586][ C0] ? usleep_range+0x150/0x150 [ 210.249624][ C0] ? unpoison_range+0x3a/0x60 [ 210.250632][ C0] ? ____kasan_kmalloc.constprop.0+0x82/0xa0 [ 210.251949][ C0] ? unpoison_range+0x3a/0x60 [ 210.252958][ C0] ? __prepare_to_swait+0xa7/0x190 [ 210.254067][ C0] do_wait_for_common+0x2ab/0x370 [ 210.255158][ C0] ? usleep_range+0x150/0x150 [ 210.256192][ C0] ? bit_wait_io_timeout+0x160/0x160 [ 210.257358][ C0] ? blk_update_request+0x757/0x1150 [ 210.258582][ C0] ? _raw_spin_lock_irq+0x82/0xd0 [ 210.259674][ C0] ? _raw_read_unlock_irqrestore+0x30/0x30 [ 210.260917][ C0] wait_for_completion+0x4c/0x90 [ 210.261971][ C0] crypt_convert+0x19a6/0x4c00 [ 210.263033][ C0] ? _raw_spin_lock_irqsave+0x87/0xe0 [ 210.264193][ C0] ? kasan_set_track+0x1c/0x30 [ 210.265191][ C0] ? crypt_iv_tcw_ctr+0x4a0/0x4a0 [ 210.266283][ C0] ? kmem_cache_free+0x104/0x470 [ 210.267363][ C0] ? crypt_endio+0x91/0x180 [ 210.268327][ C0] kcryptd_crypt_read_convert+0x30e/0x420 [ 210.269565][ C0] blk_update_request+0x757/0x1150 [ 210.270563][ C0] blk_mq_end_request+0x4b/0x480 [ 210.271680][ C0] blk_done_softirq+0x21d/0x340 [ 210.272775][ C0] ? _raw_spin_lock+0x81/0xd0 [ 210.273847][ C0] ? blk_mq_stop_hw_queue+0x30/0x30 [ 210.275031][ C0] ? _raw_read_lock_irq+0x40/0x40 [ 210.276182][ C0] __do_softirq+0x190/0x611 [ 210.277203][ C0] ? handle_edge_irq+0x221/0xb60 [ 210.278340][ C0] asm_call_irq_on_stack+0x12/0x20 [ 210.279514][ C0] </IRQ> [ 210.280164][ C0] do_softirq_own_stack+0x37/0x40 [ 210.281281][ C0] irq_exit_rcu+0x110/0x1b0 [ 210.282286][ C0] common_interrupt+0x74/0x120 [ 210.283376][ C0] asm_common_interrupt+0x1e/0x40 [ 210.284496][ C0] RIP: 0010:_aesni_enc1+0x65/0xb0 Fix this by making crypt_convert function reentrant from the point of a single bio and make dm-crypt defer further bio processing to a workqueue, if Crypto API backlogs a request in interrupt context. Fixes: 39d42fa96b ("dm crypt: add flags to optionally bypass kcryptd workqueues") Cc: stable@vger.kernel.org # v5.9+ Signed-off-by: Ignat Korchagin <ignat@cloudflare.com> Acked-by: Mikulas Patocka <mpatocka@redhat.com> Signed-off-by: Mike Snitzer <snitzer@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2021-01-19 18:27:22 +01:00
..
bcache	bcache: set bcache device into read-only mode for BCH_FEATURE_INCOMPAT_OBSO_LARGE_BUCKET	2021-01-17 14:17:01 +01:00
persistent-data	dm thin metadata: Remove unused local variable when create thin and snap	2020-09-29 16:33:11 -04:00
dm-bio-prison-v1.c
dm-bio-prison-v1.h
dm-bio-prison-v2.c
dm-bio-prison-v2.h
dm-bio-record.h	dm bio record: save/restore bi_end_io and bi_integrity	2020-03-03 10:02:46 -05:00
dm-bufio.c	dm integrity: fix flush with external metadata device	2021-01-19 18:27:22 +01:00
dm-builtin.c
dm-cache-background-tracker.c
dm-cache-background-tracker.h
dm-cache-block-types.h
dm-cache-metadata.c	dm cache metadata: Avoid returning cmd->bm wild pointer on error	2020-09-02 13:38:24 -04:00
dm-cache-metadata.h
dm-cache-policy-internal.h
dm-cache-policy-smq.c
dm-cache-policy.c
dm-cache-policy.h
dm-cache-target.c	Revert "dm cache: fix arm link errors with inline"	2020-12-01 15:43:36 -05:00
dm-clone-metadata.c	dm clone metadata: Fix return type of dm_clone_nr_of_hydrated_regions()	2020-03-27 14:42:51 -04:00
dm-clone-metadata.h	dm clone metadata: Fix return type of dm_clone_nr_of_hydrated_regions()	2020-03-27 14:42:51 -04:00
dm-clone-target.c	writeback: remove bdi->congested_fn	2020-07-08 17:20:46 -06:00
dm-core.h	dm table: make 'struct dm_table' definition accessible to all of DM core	2020-09-29 16:33:07 -04:00
dm-crypt.c	dm crypt: do not wait for backlogged crypto request completion in softirq	2021-01-19 18:27:22 +01:00
dm-delay.c	block: rename generic_make_request to submit_bio_noacct	2020-07-01 07:27:24 -06:00
dm-dust.c	dm dust: add interface to list all badblocks	2020-07-20 11:17:41 -04:00
dm-ebs-target.c	dm ebs: Fix incorrect checking for REQ_OP_FLUSH	2020-08-04 16:01:40 -04:00
dm-era-target.c	writeback: remove bdi->congested_fn	2020-07-08 17:20:46 -06:00
dm-exception-store.c
dm-exception-store.h
dm-flakey.c
dm-historical-service-time.c	dm mpath: add Historical Service Time Path Selector	2020-05-15 10:29:36 -04:00
dm-init.c	dm init: Set file local variable static	2020-08-04 15:51:28 -04:00
dm-integrity.c	dm integrity: fix the maximum number of arguments	2021-01-19 18:27:22 +01:00
dm-io.c	treewide: Remove uninitialized_var() usage	2020-07-16 12:35:15 -07:00
dm-ioctl.c	dm ioctl: fix error return code in target_message	2020-12-30 11:53:36 +01:00
dm-kcopyd.c
dm-linear.c	dm: add support for REQ_NOWAIT and enable it for linear target	2020-09-25 08:20:03 -06:00
dm-log-userspace-base.c
dm-log-userspace-transfer.c
dm-log-userspace-transfer.h
dm-log-writes.c	dm: replace zero-length array with flexible-array	2020-05-20 17:09:44 -04:00
dm-log.c
dm-mpath.c	dm: use dm_table_get_device_name() where appropriate in targets	2020-09-29 16:33:08 -04:00
dm-mpath.h
dm-path-selector.c
dm-path-selector.h	dm mpath: pass IO start time to path selector	2020-05-15 10:29:36 -04:00
dm-queue-length.c	dm mpath: pass IO start time to path selector	2020-05-15 10:29:36 -04:00
dm-raid1.c	block: rename generic_make_request to submit_bio_noacct	2020-07-01 07:27:24 -06:00
dm-raid.c	dm raid: fix discard limits for raid1	2021-01-19 18:27:21 +01:00
dm-region-hash.c
dm-round-robin.c
dm-rq.c	dm table: make 'struct dm_table' definition accessible to all of DM core	2020-09-29 16:33:07 -04:00
dm-rq.h
dm-service-time.c	dm mpath: pass IO start time to path selector	2020-05-15 10:29:36 -04:00
dm-snap-persistent.c	dm snap persistent: simplify area_io()	2020-09-29 16:33:12 -04:00
dm-snap-transient.c
dm-snap.c	dm snapshot: flush merged data before committing metadata	2021-01-19 18:27:21 +01:00
dm-stats.c	dm: replace zero-length array with flexible-array	2020-05-20 17:09:44 -04:00
dm-stats.h
dm-stripe.c	dm: replace zero-length array with flexible-array	2020-05-20 17:09:44 -04:00
dm-switch.c	dm: replace zero-length array with flexible-array	2020-05-20 17:09:44 -04:00
dm-sysfs.c
dm-table.c	dm: fix IO splitting	2020-12-04 14:53:15 -05:00
dm-target.c
dm-thin-metadata.c	dm thin metadata: Remove unused local variable when create thin and snap	2020-09-29 16:33:11 -04:00
dm-thin-metadata.h
dm-thin.c	writeback: remove bdi->congested_fn	2020-07-08 17:20:46 -06:00
dm-uevent.c
dm-uevent.h
dm-unstripe.c
dm-verity-fec.c	dm verity fec: fix hash block number in verity_fec_decode	2020-04-16 16:16:38 -04:00
dm-verity-fec.h
dm-verity-target.c	dm verity: skip verity work if I/O error when system is shutting down	2021-01-06 14:56:56 +01:00
dm-verity-verify-sig.c
dm-verity-verify-sig.h	dm verity: Fix compilation warning	2020-08-04 15:48:13 -04:00
dm-verity.h	dm verity: add "panic_on_corruption" error handling mode	2020-07-13 11:47:33 -04:00
dm-writecache.c	dm writecache: remove BUG() and fail gracefully instead	2020-12-01 15:43:39 -05:00
dm-zero.c
dm-zoned-metadata.c	dm zoned: Fix zone reclaim trigger	2020-07-08 12:21:53 -04:00
dm-zoned-reclaim.c	dm zoned: Fix zone reclaim trigger	2020-07-08 12:21:53 -04:00
dm-zoned-target.c	for-5.9/block-20200802	2020-08-03 11:57:03 -07:00
dm-zoned.h	dm zoned: select reclaim zone based on device index	2020-06-05 14:59:53 -04:00
dm.c	dm: remove invalid sparse __acquires and __releases annotations	2020-12-04 15:25:18 -05:00
dm.h	dm table: make 'struct dm_table' definition accessible to all of DM core	2020-09-29 16:33:07 -04:00
Kconfig	Replace HTTP links with HTTPS ones: LVM	2020-07-05 14:28:27 -06:00
Makefile	md: move the early init autodetect code to drivers/md/	2020-07-16 15:34:47 +02:00
md-autodetect.c	treewide: Use fallthrough pseudo-keyword	2020-08-23 17:36:59 -05:00
md-bitmap.c	md/bitmap: fix memory leak of temporary bitmap	2020-10-08 22:37:39 -07:00
md-bitmap.h
md-cluster.c	md/cluster: fix deadlock when node is doing resync job	2020-12-30 11:54:25 +01:00
md-cluster.h
md-faulty.c	block: rename generic_make_request to submit_bio_noacct	2020-07-01 07:27:24 -06:00
md-linear.c	block: add a new revalidate_disk_size helper	2020-09-02 08:00:07 -06:00
md-linear.h	md/raid1: Replace zero-length array with flexible-array	2020-05-13 12:02:23 -07:00
md-multipath.c	writeback: remove bdi->congested_fn	2020-07-08 17:20:46 -06:00
md-multipath.h
md.c	md/cluster: fix deadlock when node is doing resync job	2020-12-30 11:54:25 +01:00
md.h	Revert "md: change mddev 'chunk_sectors' from int to unsigned"	2020-12-14 19:33:01 +01:00
raid0.c	Revert "md: add md_submit_discard_bio() for submitting discard bio"	2020-12-09 20:46:01 -08:00
raid0.h
raid1-10.c
raid1.c	writeback: remove bdi->congested_fn	2020-07-08 17:20:46 -06:00
raid1.h	md/raid1: Replace zero-length array with flexible-array	2020-05-13 12:02:23 -07:00
raid5-cache.c	raid5-cache: hold spinlock instead of mutex in r5c_journal_mode_show	2020-08-02 23:03:52 -07:00
raid5-log.h
raid5-ppl.c	md/raid456: convert macro STRIPE_* to RAID5_STRIPE_*	2020-07-21 17:18:12 -07:00
raid5.c	md/raid5: fix oops during stripe resizing	2020-10-08 22:38:10 -07:00
raid5.h	md/raid5: let multiple devices of stripe_head share page	2020-09-24 16:44:44 -07:00
raid10.c	md/raid10: initialize r10_bio->read_slot before use.	2021-01-06 14:56:49 +01:00
raid10.h	Revert "md/raid10: improve discard request for far layout"	2020-12-09 20:46:00 -08:00