mirror of
https://github.com/AuxXxilium/linux_dsm_epyc7002.git
synced 2024-12-28 11:18:45 +07:00
16ee20619f
The vma->exec_list is still the only means we have for both reserving an object in execbuf, and for constructing the eviction list. So during the construction of the eviction list, we must treat anything already on the exec_list as being pinned. Yes, this sharing of two semantically different lists will be fixed! But in the meantime, we have the issue that this is tripping up CI since we started using i915_gem_gtt_reserve_node() + i915_gem_evict_for_node() from the regular execbuf reservation path in commit606fec956c
("drm/i915: Prefer random replacement before eviction search"): [ 108.424063] kernel BUG at drivers/gpu/drm/i915/i915_vma.h:254! [ 108.424072] invalid opcode: 0000 [#1] PREEMPT SMP [ 108.424079] Modules linked in: snd_hda_intel i915 intel_powerclamp coretemp crct10dif_pclmul crc32_pclmul ghash_clmulni_intel snd_hda_codec_hdmi snd_hda_codec_generic snd_hda_codec snd_hwdep snd_hda_core mei_me snd_pcm lpc_ich mei sdhci_pci sdhci mmc_core e1000e ptp pps_core [last unloaded: i915] [ 108.424132] CPU: 1 PID: 6865 Comm: gem_cs_tlb Tainted: G U 4.10.0-rc3-CI-CI_DRM_2049+ #1 [ 108.424143] Hardware name: Hewlett-Packard HP EliteBook 8440p/172A, BIOS 68CCU Ver. F.24 09/13/2013 [ 108.424154] task: ffff88012ae22600 task.stack: ffffc90000a14000 [ 108.424220] RIP: 0010:i915_gem_evict_for_node+0x237/0x410 [i915] [ 108.424229] RSP: 0018:ffffc90000a17a58 EFLAGS: 00010202 [ 108.424237] RAX: 0000000000005871 RBX: ffff88012d1ad778 RCX: 0000000000000000 [ 108.424246] RDX: 000000007ffff000 RSI: ffffc90000a17a68 RDI: ffff880127e694d8 [ 108.424255] RBP: ffffc90000a17aa0 R08: ffffc90000a17a68 R09: 0000000000000000 [ 108.424264] R10: 0000000000000001 R11: 0000000000000000 R12: 0000000080000000 [ 108.424273] R13: ffffc90000a17a68 R14: ffff880127e694d8 R15: ffffffffa0387330 [ 108.424283] FS: 00007f8236e3d8c0(0000) GS:ffff880137c40000(0000) knlGS:0000000000000000 [ 108.424293] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 108.424305] CR2: 00007f82347a2000 CR3: 000000012c866000 CR4: 00000000000006e0 [ 108.424317] Call Trace: [ 108.424368] i915_gem_gtt_reserve+0x67/0x80 [i915] [ 108.424424] __i915_vma_do_pin+0x248/0x620 [i915] [ 108.424487] ? __i915_vma_do_pin+0x162/0x620 [i915] [ 108.424540] i915_gem_execbuffer_reserve_vma.isra.8+0x153/0x1f0 [i915] [ 108.424591] i915_gem_execbuffer_reserve.isra.9+0x40e/0x440 [i915] [ 108.424643] i915_gem_do_execbuffer.isra.15+0x6d9/0x1b20 [i915] [ 108.424696] i915_gem_execbuffer2+0xc0/0x250 [i915] [ 108.424712] drm_ioctl+0x200/0x450 [ 108.424760] ? i915_gem_execbuffer+0x330/0x330 [i915] [ 108.424776] do_vfs_ioctl+0x90/0x6e0 [ 108.424789] ? up_read+0x1a/0x40 [ 108.424800] ? trace_hardirqs_on_caller+0x122/0x1b0 [ 108.424813] SyS_ioctl+0x3c/0x70 [ 108.424828] entry_SYSCALL_64_fastpath+0x1c/0xb1 [ 108.424839] RIP: 0033:0x7f8235867357 [ 108.424848] RSP: 002b:00007ffdc14504c8 EFLAGS: 00000246 ORIG_RAX: 0000000000000010 [ 108.424866] RAX: ffffffffffffffda RBX: 00007ffdc1450600 RCX: 00007f8235867357 [ 108.424878] RDX: 00007ffdc14505a0 RSI: 0000000040406469 RDI: 0000000000000003 [ 108.424890] RBP: 0000000000000000 R08: 0000000000000000 R09: 0000000000000022 [ 108.424903] R10: 0000000000000007 R11: 0000000000000246 R12: 0000000000000002 [ 108.424915] R13: 0000000000419101 R14: 00007ffdc1450600 R15: 00007ffdc14505f0 [ 108.424928] Code: 45 b8 8b 4d c0 4c 89 f2 48 89 de ff d0 49 8b 07 4c 8b 45 b8 48 85 c0 75 dd 65 ff 0d d4 a1 c8 5f 0f 84 47 01 00 00 e9 0d fe ff ff <0f> 0b 45 31 f6 4c 8b 65 c8 49 8b 04 24 4d 39 ec 49 8d 9c 24 28 [ 108.425055] RIP: i915_gem_evict_for_node+0x237/0x410 [i915] RSP: ffffc90000a17a58 Fixes:172ae5b4c8
("drm/i915: Fix i915_gem_evict_for_vma (soft-pinning)") Fixes:606fec956c
("drm/i915: Prefer random replacement before eviction search") Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> Link: http://patchwork.freedesktop.org/patch/msgid/20170111182132.19174-1-chris@chris-wilson.co.uk Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
385 lines
11 KiB
C
385 lines
11 KiB
C
/*
|
|
* Copyright © 2008-2010 Intel Corporation
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person obtaining a
|
|
* copy of this software and associated documentation files (the "Software"),
|
|
* to deal in the Software without restriction, including without limitation
|
|
* the rights to use, copy, modify, merge, publish, distribute, sublicense,
|
|
* and/or sell copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following conditions:
|
|
*
|
|
* The above copyright notice and this permission notice (including the next
|
|
* paragraph) shall be included in all copies or substantial portions of the
|
|
* Software.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
|
|
* IN THE SOFTWARE.
|
|
*
|
|
* Authors:
|
|
* Eric Anholt <eric@anholt.net>
|
|
* Chris Wilson <chris@chris-wilson.co.uuk>
|
|
*
|
|
*/
|
|
|
|
#include <drm/drmP.h>
|
|
#include <drm/i915_drm.h>
|
|
|
|
#include "i915_drv.h"
|
|
#include "intel_drv.h"
|
|
#include "i915_trace.h"
|
|
|
|
static bool ggtt_is_idle(struct drm_i915_private *dev_priv)
|
|
{
|
|
struct i915_ggtt *ggtt = &dev_priv->ggtt;
|
|
struct intel_engine_cs *engine;
|
|
enum intel_engine_id id;
|
|
|
|
for_each_engine(engine, dev_priv, id) {
|
|
struct intel_timeline *tl;
|
|
|
|
tl = &ggtt->base.timeline.engine[engine->id];
|
|
if (i915_gem_active_isset(&tl->last_request))
|
|
return false;
|
|
}
|
|
|
|
return true;
|
|
}
|
|
|
|
static bool
|
|
mark_free(struct drm_mm_scan *scan,
|
|
struct i915_vma *vma,
|
|
unsigned int flags,
|
|
struct list_head *unwind)
|
|
{
|
|
if (i915_vma_is_pinned(vma))
|
|
return false;
|
|
|
|
if (WARN_ON(!list_empty(&vma->exec_list)))
|
|
return false;
|
|
|
|
if (flags & PIN_NONFAULT && !list_empty(&vma->obj->userfault_link))
|
|
return false;
|
|
|
|
list_add(&vma->exec_list, unwind);
|
|
return drm_mm_scan_add_block(scan, &vma->node);
|
|
}
|
|
|
|
/**
|
|
* i915_gem_evict_something - Evict vmas to make room for binding a new one
|
|
* @vm: address space to evict from
|
|
* @min_size: size of the desired free space
|
|
* @alignment: alignment constraint of the desired free space
|
|
* @cache_level: cache_level for the desired space
|
|
* @start: start (inclusive) of the range from which to evict objects
|
|
* @end: end (exclusive) of the range from which to evict objects
|
|
* @flags: additional flags to control the eviction algorithm
|
|
*
|
|
* This function will try to evict vmas until a free space satisfying the
|
|
* requirements is found. Callers must check first whether any such hole exists
|
|
* already before calling this function.
|
|
*
|
|
* This function is used by the object/vma binding code.
|
|
*
|
|
* Since this function is only used to free up virtual address space it only
|
|
* ignores pinned vmas, and not object where the backing storage itself is
|
|
* pinned. Hence obj->pages_pin_count does not protect against eviction.
|
|
*
|
|
* To clarify: This is for freeing up virtual address space, not for freeing
|
|
* memory in e.g. the shrinker.
|
|
*/
|
|
int
|
|
i915_gem_evict_something(struct i915_address_space *vm,
|
|
u64 min_size, u64 alignment,
|
|
unsigned cache_level,
|
|
u64 start, u64 end,
|
|
unsigned flags)
|
|
{
|
|
struct drm_i915_private *dev_priv = vm->i915;
|
|
struct drm_mm_scan scan;
|
|
struct list_head eviction_list;
|
|
struct list_head *phases[] = {
|
|
&vm->inactive_list,
|
|
&vm->active_list,
|
|
NULL,
|
|
}, **phase;
|
|
struct i915_vma *vma, *next;
|
|
struct drm_mm_node *node;
|
|
int ret;
|
|
|
|
lockdep_assert_held(&vm->i915->drm.struct_mutex);
|
|
trace_i915_gem_evict(vm, min_size, alignment, flags);
|
|
|
|
/*
|
|
* The goal is to evict objects and amalgamate space in LRU order.
|
|
* The oldest idle objects reside on the inactive list, which is in
|
|
* retirement order. The next objects to retire are those in flight,
|
|
* on the active list, again in retirement order.
|
|
*
|
|
* The retirement sequence is thus:
|
|
* 1. Inactive objects (already retired)
|
|
* 2. Active objects (will stall on unbinding)
|
|
*
|
|
* On each list, the oldest objects lie at the HEAD with the freshest
|
|
* object on the TAIL.
|
|
*/
|
|
drm_mm_scan_init_with_range(&scan, &vm->mm,
|
|
min_size, alignment, cache_level,
|
|
start, end,
|
|
flags & PIN_HIGH ? DRM_MM_CREATE_TOP : 0);
|
|
|
|
/* Retire before we search the active list. Although we have
|
|
* reasonable accuracy in our retirement lists, we may have
|
|
* a stray pin (preventing eviction) that can only be resolved by
|
|
* retiring.
|
|
*/
|
|
if (!(flags & PIN_NONBLOCK))
|
|
i915_gem_retire_requests(dev_priv);
|
|
else
|
|
phases[1] = NULL;
|
|
|
|
search_again:
|
|
INIT_LIST_HEAD(&eviction_list);
|
|
phase = phases;
|
|
do {
|
|
list_for_each_entry(vma, *phase, vm_link)
|
|
if (mark_free(&scan, vma, flags, &eviction_list))
|
|
goto found;
|
|
} while (*++phase);
|
|
|
|
/* Nothing found, clean up and bail out! */
|
|
list_for_each_entry_safe(vma, next, &eviction_list, exec_list) {
|
|
ret = drm_mm_scan_remove_block(&scan, &vma->node);
|
|
BUG_ON(ret);
|
|
|
|
INIT_LIST_HEAD(&vma->exec_list);
|
|
}
|
|
|
|
/* Can we unpin some objects such as idle hw contents,
|
|
* or pending flips? But since only the GGTT has global entries
|
|
* such as scanouts, rinbuffers and contexts, we can skip the
|
|
* purge when inspecting per-process local address spaces.
|
|
*/
|
|
if (!i915_is_ggtt(vm) || flags & PIN_NONBLOCK)
|
|
return -ENOSPC;
|
|
|
|
if (ggtt_is_idle(dev_priv)) {
|
|
/* If we still have pending pageflip completions, drop
|
|
* back to userspace to give our workqueues time to
|
|
* acquire our locks and unpin the old scanouts.
|
|
*/
|
|
return intel_has_pending_fb_unpin(dev_priv) ? -EAGAIN : -ENOSPC;
|
|
}
|
|
|
|
/* Not everything in the GGTT is tracked via vma (otherwise we
|
|
* could evict as required with minimal stalling) so we are forced
|
|
* to idle the GPU and explicitly retire outstanding requests in
|
|
* the hopes that we can then remove contexts and the like only
|
|
* bound by their active reference.
|
|
*/
|
|
ret = i915_gem_switch_to_kernel_context(dev_priv);
|
|
if (ret)
|
|
return ret;
|
|
|
|
ret = i915_gem_wait_for_idle(dev_priv,
|
|
I915_WAIT_INTERRUPTIBLE |
|
|
I915_WAIT_LOCKED);
|
|
if (ret)
|
|
return ret;
|
|
|
|
i915_gem_retire_requests(dev_priv);
|
|
goto search_again;
|
|
|
|
found:
|
|
/* drm_mm doesn't allow any other other operations while
|
|
* scanning, therefore store to-be-evicted objects on a
|
|
* temporary list and take a reference for all before
|
|
* calling unbind (which may remove the active reference
|
|
* of any of our objects, thus corrupting the list).
|
|
*/
|
|
list_for_each_entry_safe(vma, next, &eviction_list, exec_list) {
|
|
if (drm_mm_scan_remove_block(&scan, &vma->node))
|
|
__i915_vma_pin(vma);
|
|
else
|
|
list_del_init(&vma->exec_list);
|
|
}
|
|
|
|
/* Unbinding will emit any required flushes */
|
|
ret = 0;
|
|
while (!list_empty(&eviction_list)) {
|
|
vma = list_first_entry(&eviction_list,
|
|
struct i915_vma,
|
|
exec_list);
|
|
|
|
list_del_init(&vma->exec_list);
|
|
__i915_vma_unpin(vma);
|
|
if (ret == 0)
|
|
ret = i915_vma_unbind(vma);
|
|
}
|
|
|
|
while (ret == 0 && (node = drm_mm_scan_color_evict(&scan))) {
|
|
vma = container_of(node, struct i915_vma, node);
|
|
ret = i915_vma_unbind(vma);
|
|
}
|
|
|
|
return ret;
|
|
}
|
|
|
|
/**
|
|
* i915_gem_evict_for_vma - Evict vmas to make room for binding a new one
|
|
* @vm: address space to evict from
|
|
* @target: range (and color) to evict for
|
|
* @flags: additional flags to control the eviction algorithm
|
|
*
|
|
* This function will try to evict vmas that overlap the target node.
|
|
*
|
|
* To clarify: This is for freeing up virtual address space, not for freeing
|
|
* memory in e.g. the shrinker.
|
|
*/
|
|
int i915_gem_evict_for_node(struct i915_address_space *vm,
|
|
struct drm_mm_node *target,
|
|
unsigned int flags)
|
|
{
|
|
LIST_HEAD(eviction_list);
|
|
struct drm_mm_node *node;
|
|
u64 start = target->start;
|
|
u64 end = start + target->size;
|
|
struct i915_vma *vma, *next;
|
|
bool check_color;
|
|
int ret = 0;
|
|
|
|
lockdep_assert_held(&vm->i915->drm.struct_mutex);
|
|
trace_i915_gem_evict_node(vm, target, flags);
|
|
|
|
/* Retire before we search the active list. Although we have
|
|
* reasonable accuracy in our retirement lists, we may have
|
|
* a stray pin (preventing eviction) that can only be resolved by
|
|
* retiring.
|
|
*/
|
|
if (!(flags & PIN_NONBLOCK))
|
|
i915_gem_retire_requests(vm->i915);
|
|
|
|
check_color = vm->mm.color_adjust;
|
|
if (check_color) {
|
|
/* Expand search to cover neighbouring guard pages (or lack!) */
|
|
if (start > vm->start)
|
|
start -= I915_GTT_PAGE_SIZE;
|
|
if (end < vm->start + vm->total)
|
|
end += I915_GTT_PAGE_SIZE;
|
|
}
|
|
|
|
drm_mm_for_each_node_in_range(node, &vm->mm, start, end) {
|
|
/* If we find any non-objects (!vma), we cannot evict them */
|
|
if (node->color == I915_COLOR_UNEVICTABLE) {
|
|
ret = -ENOSPC;
|
|
break;
|
|
}
|
|
|
|
vma = container_of(node, typeof(*vma), node);
|
|
|
|
/* If we are using coloring to insert guard pages between
|
|
* different cache domains within the address space, we have
|
|
* to check whether the objects on either side of our range
|
|
* abutt and conflict. If they are in conflict, then we evict
|
|
* those as well to make room for our guard pages.
|
|
*/
|
|
if (check_color) {
|
|
if (vma->node.start + vma->node.size == node->start) {
|
|
if (vma->node.color == node->color)
|
|
continue;
|
|
}
|
|
if (vma->node.start == node->start + node->size) {
|
|
if (vma->node.color == node->color)
|
|
continue;
|
|
}
|
|
}
|
|
|
|
if (flags & PIN_NONBLOCK &&
|
|
(i915_vma_is_pinned(vma) || i915_vma_is_active(vma))) {
|
|
ret = -ENOSPC;
|
|
break;
|
|
}
|
|
|
|
/* Overlap of objects in the same batch? */
|
|
if (i915_vma_is_pinned(vma) || !list_empty(&vma->exec_list)) {
|
|
ret = -ENOSPC;
|
|
if (vma->exec_entry &&
|
|
vma->exec_entry->flags & EXEC_OBJECT_PINNED)
|
|
ret = -EINVAL;
|
|
break;
|
|
}
|
|
|
|
/* Never show fear in the face of dragons!
|
|
*
|
|
* We cannot directly remove this node from within this
|
|
* iterator and as with i915_gem_evict_something() we employ
|
|
* the vma pin_count in order to prevent the action of
|
|
* unbinding one vma from freeing (by dropping its active
|
|
* reference) another in our eviction list.
|
|
*/
|
|
__i915_vma_pin(vma);
|
|
list_add(&vma->exec_list, &eviction_list);
|
|
}
|
|
|
|
list_for_each_entry_safe(vma, next, &eviction_list, exec_list) {
|
|
list_del_init(&vma->exec_list);
|
|
__i915_vma_unpin(vma);
|
|
if (ret == 0)
|
|
ret = i915_vma_unbind(vma);
|
|
}
|
|
|
|
return ret;
|
|
}
|
|
|
|
/**
|
|
* i915_gem_evict_vm - Evict all idle vmas from a vm
|
|
* @vm: Address space to cleanse
|
|
* @do_idle: Boolean directing whether to idle first.
|
|
*
|
|
* This function evicts all idles vmas from a vm. If all unpinned vmas should be
|
|
* evicted the @do_idle needs to be set to true.
|
|
*
|
|
* This is used by the execbuf code as a last-ditch effort to defragment the
|
|
* address space.
|
|
*
|
|
* To clarify: This is for freeing up virtual address space, not for freeing
|
|
* memory in e.g. the shrinker.
|
|
*/
|
|
int i915_gem_evict_vm(struct i915_address_space *vm, bool do_idle)
|
|
{
|
|
struct i915_vma *vma, *next;
|
|
int ret;
|
|
|
|
lockdep_assert_held(&vm->i915->drm.struct_mutex);
|
|
trace_i915_gem_evict_vm(vm);
|
|
|
|
if (do_idle) {
|
|
struct drm_i915_private *dev_priv = vm->i915;
|
|
|
|
if (i915_is_ggtt(vm)) {
|
|
ret = i915_gem_switch_to_kernel_context(dev_priv);
|
|
if (ret)
|
|
return ret;
|
|
}
|
|
|
|
ret = i915_gem_wait_for_idle(dev_priv,
|
|
I915_WAIT_INTERRUPTIBLE |
|
|
I915_WAIT_LOCKED);
|
|
if (ret)
|
|
return ret;
|
|
|
|
i915_gem_retire_requests(dev_priv);
|
|
WARN_ON(!list_empty(&vm->active_list));
|
|
}
|
|
|
|
list_for_each_entry_safe(vma, next, &vm->inactive_list, vm_link)
|
|
if (!i915_vma_is_pinned(vma))
|
|
WARN_ON(i915_vma_unbind(vma));
|
|
|
|
return 0;
|
|
}
|