linux_dsm_epyc7002/fs/f2fs
Eric Biggers 80f2388afa f2fs: fix race conditions in ->d_compare() and ->d_hash()
Since ->d_compare() and ->d_hash() can be called in RCU-walk mode,
->d_parent and ->d_inode can be concurrently modified, and in
particular, ->d_inode may be changed to NULL.  For f2fs_d_hash() this
resulted in a reproducible NULL dereference if a lookup is done in a
directory being deleted, e.g. with:

	int main()
	{
		if (fork()) {
			for (;;) {
				mkdir("subdir", 0700);
				rmdir("subdir");
			}
		} else {
			for (;;)
				access("subdir/file", 0);
		}
	}

... or by running the 't_encrypted_d_revalidate' program from xfstests.
Both repros work in any directory on a filesystem with the encoding
feature, even if the directory doesn't actually have the casefold flag.

I couldn't reproduce a crash in f2fs_d_compare(), but it appears that a
similar crash is possible there.

Fix these bugs by reading ->d_parent and ->d_inode using READ_ONCE() and
falling back to the case sensitive behavior if the inode is NULL.

Reported-by: Al Viro <viro@zeniv.linux.org.uk>
Fixes: 2c2eb7a300 ("f2fs: Support case-insensitive file name lookups")
Cc: <stable@vger.kernel.org> # v5.4+
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
2020-01-24 10:04:09 -08:00
..
acl.c f2fs: Replace spaces with tab 2019-05-08 21:23:11 -07:00
acl.h f2fs: add SPDX license identifiers 2018-09-12 13:07:10 -07:00
checkpoint.c f2fs: don't keep META_MAPPING pages used for moving verity file blocks 2020-01-15 13:43:48 -08:00
compress.c f2fs: support data compression 2020-01-17 16:48:07 -08:00
data.c f2fs: fix deadlock allocating bio_post_read_ctx from mempool 2020-01-17 16:48:43 -08:00
debug.c f2fs: Add f2fs stats to sysfs 2020-01-23 09:24:25 -08:00
dir.c f2fs: fix race conditions in ->d_compare() and ->d_hash() 2020-01-24 10:04:09 -08:00
extent_cache.c f2fs: introduce f2fs_<level> macros to wrap f2fs_printk() 2019-07-02 15:40:40 -07:00
f2fs.h f2fs: Add f2fs stats to sysfs 2020-01-23 09:24:25 -08:00
file.c f2fs: change to use rwsem for gc_mutex 2020-01-17 16:48:44 -08:00
gc.c f2fs: Add f2fs stats to sysfs 2020-01-23 09:24:25 -08:00
gc.h f2fs: add SPDX license identifiers 2018-09-12 13:07:10 -07:00
hash.c f2fs: Support case-insensitive file name lookups 2019-08-23 07:57:13 -07:00
inline.c f2fs: convert inline_dir early before starting rename 2020-01-17 16:48:42 -08:00
inode.c f2fs: support data compression 2020-01-17 16:48:07 -08:00
Kconfig f2fs: Add f2fs stats to sysfs 2020-01-23 09:24:25 -08:00
Makefile f2fs: support data compression 2020-01-17 16:48:07 -08:00
namei.c f2fs: convert inline_dir early before starting rename 2020-01-17 16:48:42 -08:00
node.c f2fs: show f2fs instance in printk_ratelimited 2019-11-19 14:41:21 -08:00
node.h f2fs: check PageWriteback flag for ordered case 2018-12-26 15:16:56 -08:00
recovery.c f2fs: Check write pointer consistency of open zones 2020-01-15 13:42:14 -08:00
segment.c f2fs: change to use rwsem for gc_mutex 2020-01-17 16:48:44 -08:00
segment.h f2fs: update f2fs document regarding to fsync_mode 2020-01-17 16:48:44 -08:00
shrinker.c f2fs: fix sbi->extent_list corruption issue 2018-12-26 15:16:54 -08:00
super.c f2fs: change to use rwsem for gc_mutex 2020-01-17 16:48:44 -08:00
sysfs.c f2fs: Add f2fs stats to sysfs 2020-01-23 09:24:25 -08:00
trace.c f2fs: do not use mutex lock in atomic context 2019-03-05 19:58:06 -08:00
trace.h f2fs: add SPDX license identifiers 2018-09-12 13:07:10 -07:00
verity.c f2fs: add fs-verity support 2019-08-12 19:33:51 -07:00
xattr.c f2fs: fix to avoid memory leakage in f2fs_listxattr 2019-10-22 10:32:42 -07:00
xattr.h f2fs: add fs-verity support 2019-08-12 19:33:51 -07:00