Coly Li 20621fedb2 bcache: Revert "bcache: use sysfs_match_string() instead of __sysfs_match_string()" ... This reverts commit 89e0341af0. In drivers/md/bcache/sysfs.c:bch_snprint_string_list(), NULL pointer at the end of list is necessary. Remove the NULL from last element of each lists will cause the following panic, [ 4340.455652] bcache: register_cache() registered cache device nvme0n1 [ 4340.464603] bcache: register_bdev() registered backing device sdk [ 4421.587335] bcache: bch_cached_dev_run() cached dev sdk is running already [ 4421.587348] bcache: bch_cached_dev_attach() Caching sdk as bcache0 on set 354e1d46-d99f-4d8b-870b-078b80dc88a6 [ 5139.247950] general protection fault: 0000 [#1] SMP NOPTI [ 5139.247970] CPU: 9 PID: 5896 Comm: cat Not tainted 4.12.14-95.29-default #1 SLE12-SP4 [ 5139.247988] Hardware name: HPE ProLiant DL380 Gen10/ProLiant DL380 Gen10, BIOS U30 04/18/2019 [ 5139.248006] task: ffff888fb25c0b00 task.stack: ffff9bbacc704000 [ 5139.248021] RIP: 0010:string+0x21/0x70 [ 5139.248030] RSP: 0018:ffff9bbacc707bf0 EFLAGS: 00010286 [ 5139.248043] RAX: ffffffffa7e432e3 RBX: ffff8881c20da02a RCX: ffff0a00ffffff04 [ 5139.248058] RDX: 3f00656863616362 RSI: ffff8881c20db000 RDI: ffffffffffffffff [ 5139.248075] RBP: ffff8881c20db000 R08: 0000000000000000 R09: ffff8881c20da02a [ 5139.248090] R10: 0000000000000004 R11: 0000000000000000 R12: ffff9bbacc707c48 [ 5139.248104] R13: 0000000000000fd6 R14: ffffffffc0665855 R15: ffffffffc0665855 [ 5139.248119] FS: 00007faf253b8700(0000) GS:ffff88903f840000(0000) knlGS:0000000000000000 [ 5139.248137] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 5139.248149] CR2: 00007faf25395008 CR3: 0000000f72150006 CR4: 00000000007606e0 [ 5139.248164] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 5139.248179] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 [ 5139.248193] PKRU: 55555554 [ 5139.248200] Call Trace: [ 5139.248210] vsnprintf+0x1fb/0x510 [ 5139.248221] snprintf+0x39/0x40 [ 5139.248238] bch_snprint_string_list.constprop.15+0x5b/0x90 [bcache] [ 5139.248256] __bch_cached_dev_show+0x44d/0x5f0 [bcache] [ 5139.248270] ? __alloc_pages_nodemask+0xb2/0x210 [ 5139.248284] bch_cached_dev_show+0x2c/0x50 [bcache] [ 5139.248297] sysfs_kf_seq_show+0xbb/0x190 [ 5139.248308] seq_read+0xfc/0x3c0 [ 5139.248317] __vfs_read+0x26/0x140 [ 5139.248327] vfs_read+0x87/0x130 [ 5139.248336] SyS_read+0x42/0x90 [ 5139.248346] do_syscall_64+0x74/0x160 [ 5139.248358] entry_SYSCALL_64_after_hwframe+0x3d/0xa2 [ 5139.248370] RIP: 0033:0x7faf24eea370 [ 5139.248379] RSP: 002b:00007fff82d03f38 EFLAGS: 00000246 ORIG_RAX: 0000000000000000 [ 5139.248395] RAX: ffffffffffffffda RBX: 0000000000020000 RCX: 00007faf24eea370 [ 5139.248411] RDX: 0000000000020000 RSI: 00007faf25396000 RDI: 0000000000000003 [ 5139.248426] RBP: 00007faf25396000 R08: 00000000ffffffff R09: 0000000000000000 [ 5139.248441] R10: 000000007c9d4d41 R11: 0000000000000246 R12: 00007faf25396000 [ 5139.248456] R13: 0000000000000003 R14: 0000000000000000 R15: 0000000000000fff [ 5139.248892] Code: ff ff ff 0f 1f 80 00 00 00 00 49 89 f9 48 89 cf 48 c7 c0 e3 32 e4 a7 48 c1 ff 30 48 81 fa ff 0f 00 00 48 0f 46 d0 48 85 ff 74 45 <44> 0f b6 02 48 8d 42 01 45 84 c0 74 38 48 01 fa 4c 89 cf eb 0e The simplest way to fix is to revert commit 89e0341af0 ("bcache: use sysfs_match_string() instead of __sysfs_match_string()"). This bug was introduced in Linux v5.2, so this fix only applies to Linux v5.2 is enough for stable tree maintainer. Fixes: 89e0341af0 ("bcache: use sysfs_match_string() instead of __sysfs_match_string()") Cc: stable@vger.kernel.org Cc: Alexandru Ardelean <alexandru.ardelean@analog.com> Reported-by: Peifeng Lin <pflin@suse.com> Acked-by: Alexandru Ardelean <alexandru.ardelean@analog.com> Signed-off-by: Coly Li <colyli@suse.de> Signed-off-by: Jens Axboe <axboe@kernel.dk>		2019-08-09 07:37:33 -06:00
..
alloc.c	bcache: check CACHE_SET_IO_DISABLE in allocator code	2019-06-28 07:39:15 -06:00
bcache.h	bcache: add reclaimed_journal_buckets to struct cache_set	2019-06-28 07:39:18 -06:00
bset.c	bcache: make bset_search_tree() be more understandable	2019-06-28 07:39:15 -06:00
bset.h	bcache: fix stack corruption by PRECEDING_KEY()	2019-06-13 03:09:14 -06:00
btree.c	bcache: fix race in btree_flush_write()	2019-06-28 07:39:18 -06:00
btree.h	bcache: fix race in btree_flush_write()	2019-06-28 07:39:18 -06:00
closure.c	bcache: add missing SPDX header	2018-08-11 15:46:42 -06:00
closure.h	bcache: fix typo in code comments of closure_return_with_destructor()	2018-10-08 08:19:43 -06:00
debug.c	bcache: do not check if debug dentry is ERR or NULL explicitly on remove	2018-12-13 08:15:54 -07:00
debug.h	bcache: add identifier names to arguments of function definitions	2018-08-11 15:46:41 -06:00
extents.c	bcache: treat stale && dirty keys as bad keys	2019-02-09 07:18:31 -07:00
extents.h	bcache: add identifier names to arguments of function definitions	2018-08-11 15:46:41 -06:00
io.c	bcache: ignore read-ahead request failure on backing device	2019-06-28 07:39:14 -06:00
journal.c	bcache: add reclaimed_journal_buckets to struct cache_set	2019-06-28 07:39:18 -06:00
journal.h	bcache: performance improvement for btree_flush_write()	2019-06-28 07:39:18 -06:00
Kconfig	treewide: Add SPDX license identifier - Makefile/Kconfig	2019-05-21 10:50:46 +02:00
Makefile	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
movinggc.c	bcache: style fix to add a blank line after declarations	2018-08-11 15:46:41 -06:00
request.c	bcache: Clean up bch_get_congested()	2019-04-24 10:56:27 -06:00
request.h	bcache: Clean up bch_get_congested()	2019-04-24 10:56:27 -06:00
stats.c	bcache: not use hard coded memset size in bch_cache_accounting_clear()	2019-02-09 07:18:31 -07:00
stats.h	bcache: add identifier names to arguments of function definitions	2018-08-11 15:46:41 -06:00
super.c	bcache: fix possible memory leak in bch_cached_dev_run()	2019-07-22 08:15:17 -06:00
sysfs.c	bcache: Revert "bcache: use sysfs_match_string() instead of __sysfs_match_string()"	2019-08-09 07:37:33 -06:00
sysfs.h	bcache: add sysfs_strtoul_bool() for setting bit-field variables	2019-02-09 07:18:32 -07:00
trace.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
util.c	bcache: avoid to use bio_for_each_segment_all() in bch_bio_alloc_pages()	2019-02-15 08:40:11 -07:00
util.h	bcache: Revert "bcache: fix high CPU occupancy during journal"	2019-06-28 07:39:17 -06:00
writeback.c	bcache: fix potential deadlock in cached_def_free()	2019-06-28 07:39:16 -06:00
writeback.h	bcache: never writeback a discard operation	2019-02-09 07:18:31 -07:00