mirror of
https://github.com/AuxXxilium/linux_dsm_epyc7002.git
synced 2024-12-23 19:13:15 +07:00
464e86b4ab
It seems at least Clang is able to throw away writes it knows are
destined for read-only memory, which makes things like the WRITE_RO test
fail, as the write gets elided. Instead, force the variable to be
volatile, and make similar changes through-out other tests in an effort
to avoid needing to repeat fixing these kinds of problems. Also includes
pr_err() calls in failure paths so that kernel logs are more clear in
the failure case.
Reported-by: Prasad Sodagudi <psodagud@codeaurora.org>
Suggested-by: Sami Tolvanen <samitolvanen@google.com>
Fixes: 9ae113ce5f
("lkdtm: add tests for additional page permissions")
Signed-off-by: Kees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/r/20200625203704.317097-2-keescook@chromium.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
230 lines
5.4 KiB
C
230 lines
5.4 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
/*
|
|
* This is for all the tests related to validating kernel memory
|
|
* permissions: non-executable regions, non-writable regions, and
|
|
* even non-readable regions.
|
|
*/
|
|
#include "lkdtm.h"
|
|
#include <linux/slab.h>
|
|
#include <linux/vmalloc.h>
|
|
#include <linux/mman.h>
|
|
#include <linux/uaccess.h>
|
|
#include <asm/cacheflush.h>
|
|
|
|
/* Whether or not to fill the target memory area with do_nothing(). */
|
|
#define CODE_WRITE true
|
|
#define CODE_AS_IS false
|
|
|
|
/* How many bytes to copy to be sure we've copied enough of do_nothing(). */
|
|
#define EXEC_SIZE 64
|
|
|
|
/* This is non-const, so it will end up in the .data section. */
|
|
static u8 data_area[EXEC_SIZE];
|
|
|
|
/* This is cost, so it will end up in the .rodata section. */
|
|
static const unsigned long rodata = 0xAA55AA55;
|
|
|
|
/* This is marked __ro_after_init, so it should ultimately be .rodata. */
|
|
static unsigned long ro_after_init __ro_after_init = 0x55AA5500;
|
|
|
|
/*
|
|
* This just returns to the caller. It is designed to be copied into
|
|
* non-executable memory regions.
|
|
*/
|
|
static void do_nothing(void)
|
|
{
|
|
return;
|
|
}
|
|
|
|
/* Must immediately follow do_nothing for size calculuations to work out. */
|
|
static void do_overwritten(void)
|
|
{
|
|
pr_info("do_overwritten wasn't overwritten!\n");
|
|
return;
|
|
}
|
|
|
|
static noinline void execute_location(void *dst, bool write)
|
|
{
|
|
void (*func)(void) = dst;
|
|
|
|
pr_info("attempting ok execution at %px\n", do_nothing);
|
|
do_nothing();
|
|
|
|
if (write == CODE_WRITE) {
|
|
memcpy(dst, do_nothing, EXEC_SIZE);
|
|
flush_icache_range((unsigned long)dst,
|
|
(unsigned long)dst + EXEC_SIZE);
|
|
}
|
|
pr_info("attempting bad execution at %px\n", func);
|
|
func();
|
|
pr_err("FAIL: func returned\n");
|
|
}
|
|
|
|
static void execute_user_location(void *dst)
|
|
{
|
|
int copied;
|
|
|
|
/* Intentionally crossing kernel/user memory boundary. */
|
|
void (*func)(void) = dst;
|
|
|
|
pr_info("attempting ok execution at %px\n", do_nothing);
|
|
do_nothing();
|
|
|
|
copied = access_process_vm(current, (unsigned long)dst, do_nothing,
|
|
EXEC_SIZE, FOLL_WRITE);
|
|
if (copied < EXEC_SIZE)
|
|
return;
|
|
pr_info("attempting bad execution at %px\n", func);
|
|
func();
|
|
pr_err("FAIL: func returned\n");
|
|
}
|
|
|
|
void lkdtm_WRITE_RO(void)
|
|
{
|
|
/* Explicitly cast away "const" for the test and make volatile. */
|
|
volatile unsigned long *ptr = (unsigned long *)&rodata;
|
|
|
|
pr_info("attempting bad rodata write at %px\n", ptr);
|
|
*ptr ^= 0xabcd1234;
|
|
pr_err("FAIL: survived bad write\n");
|
|
}
|
|
|
|
void lkdtm_WRITE_RO_AFTER_INIT(void)
|
|
{
|
|
volatile unsigned long *ptr = &ro_after_init;
|
|
|
|
/*
|
|
* Verify we were written to during init. Since an Oops
|
|
* is considered a "success", a failure is to just skip the
|
|
* real test.
|
|
*/
|
|
if ((*ptr & 0xAA) != 0xAA) {
|
|
pr_info("%p was NOT written during init!?\n", ptr);
|
|
return;
|
|
}
|
|
|
|
pr_info("attempting bad ro_after_init write at %px\n", ptr);
|
|
*ptr ^= 0xabcd1234;
|
|
pr_err("FAIL: survived bad write\n");
|
|
}
|
|
|
|
void lkdtm_WRITE_KERN(void)
|
|
{
|
|
size_t size;
|
|
volatile unsigned char *ptr;
|
|
|
|
size = (unsigned long)do_overwritten - (unsigned long)do_nothing;
|
|
ptr = (unsigned char *)do_overwritten;
|
|
|
|
pr_info("attempting bad %zu byte write at %px\n", size, ptr);
|
|
memcpy((void *)ptr, (unsigned char *)do_nothing, size);
|
|
flush_icache_range((unsigned long)ptr, (unsigned long)(ptr + size));
|
|
pr_err("FAIL: survived bad write\n");
|
|
|
|
do_overwritten();
|
|
}
|
|
|
|
void lkdtm_EXEC_DATA(void)
|
|
{
|
|
execute_location(data_area, CODE_WRITE);
|
|
}
|
|
|
|
void lkdtm_EXEC_STACK(void)
|
|
{
|
|
u8 stack_area[EXEC_SIZE];
|
|
execute_location(stack_area, CODE_WRITE);
|
|
}
|
|
|
|
void lkdtm_EXEC_KMALLOC(void)
|
|
{
|
|
u32 *kmalloc_area = kmalloc(EXEC_SIZE, GFP_KERNEL);
|
|
execute_location(kmalloc_area, CODE_WRITE);
|
|
kfree(kmalloc_area);
|
|
}
|
|
|
|
void lkdtm_EXEC_VMALLOC(void)
|
|
{
|
|
u32 *vmalloc_area = vmalloc(EXEC_SIZE);
|
|
execute_location(vmalloc_area, CODE_WRITE);
|
|
vfree(vmalloc_area);
|
|
}
|
|
|
|
void lkdtm_EXEC_RODATA(void)
|
|
{
|
|
execute_location(lkdtm_rodata_do_nothing, CODE_AS_IS);
|
|
}
|
|
|
|
void lkdtm_EXEC_USERSPACE(void)
|
|
{
|
|
unsigned long user_addr;
|
|
|
|
user_addr = vm_mmap(NULL, 0, PAGE_SIZE,
|
|
PROT_READ | PROT_WRITE | PROT_EXEC,
|
|
MAP_ANONYMOUS | MAP_PRIVATE, 0);
|
|
if (user_addr >= TASK_SIZE) {
|
|
pr_warn("Failed to allocate user memory\n");
|
|
return;
|
|
}
|
|
execute_user_location((void *)user_addr);
|
|
vm_munmap(user_addr, PAGE_SIZE);
|
|
}
|
|
|
|
void lkdtm_EXEC_NULL(void)
|
|
{
|
|
execute_location(NULL, CODE_AS_IS);
|
|
}
|
|
|
|
void lkdtm_ACCESS_USERSPACE(void)
|
|
{
|
|
unsigned long user_addr, tmp = 0;
|
|
unsigned long *ptr;
|
|
|
|
user_addr = vm_mmap(NULL, 0, PAGE_SIZE,
|
|
PROT_READ | PROT_WRITE | PROT_EXEC,
|
|
MAP_ANONYMOUS | MAP_PRIVATE, 0);
|
|
if (user_addr >= TASK_SIZE) {
|
|
pr_warn("Failed to allocate user memory\n");
|
|
return;
|
|
}
|
|
|
|
if (copy_to_user((void __user *)user_addr, &tmp, sizeof(tmp))) {
|
|
pr_warn("copy_to_user failed\n");
|
|
vm_munmap(user_addr, PAGE_SIZE);
|
|
return;
|
|
}
|
|
|
|
ptr = (unsigned long *)user_addr;
|
|
|
|
pr_info("attempting bad read at %px\n", ptr);
|
|
tmp = *ptr;
|
|
tmp += 0xc0dec0de;
|
|
pr_err("FAIL: survived bad read\n");
|
|
|
|
pr_info("attempting bad write at %px\n", ptr);
|
|
*ptr = tmp;
|
|
pr_err("FAIL: survived bad write\n");
|
|
|
|
vm_munmap(user_addr, PAGE_SIZE);
|
|
}
|
|
|
|
void lkdtm_ACCESS_NULL(void)
|
|
{
|
|
unsigned long tmp;
|
|
volatile unsigned long *ptr = (unsigned long *)NULL;
|
|
|
|
pr_info("attempting bad read at %px\n", ptr);
|
|
tmp = *ptr;
|
|
tmp += 0xc0dec0de;
|
|
pr_err("FAIL: survived bad read\n");
|
|
|
|
pr_info("attempting bad write at %px\n", ptr);
|
|
*ptr = tmp;
|
|
pr_err("FAIL: survived bad write\n");
|
|
}
|
|
|
|
void __init lkdtm_perms_init(void)
|
|
{
|
|
/* Make sure we can write to __ro_after_init values during __init */
|
|
ro_after_init |= 0xAA;
|
|
}
|