Tony Makkiel 7cfe749fad leds: core: Fix brightness setting upon hardware blinking enabled ... Commit 76931edd54 ("leds: fix brightness changing when software blinking is active") changed the semantics of led_set_brightness() which according to the documentation should disable blinking upon any brightness setting. Moreover it made it different for soft blink case, where it was possible to change blink brightness, and for hardware blink case, where setting any brightness greater than 0 was ignored. While the change itself is against the documentation claims, it was driven also by the fact that timer trigger remained active after turning blinking off. Fixing that would have required major refactoring in the led-core, led-class, and led-triggers because of cyclic dependencies. Finally, it has been decided that allowing for brightness change during blinking is beneficial as it can be accomplished without disturbing blink rhythm. The change in brightness setting semantics will not affect existing LED class drivers that implement blink_set op thanks to the LED_BLINK_SW flag introduced by this patch. The flag state will be from now on checked in led_set_brightness() which will allow to distinguish between software and hardware blink mode. In the latter case the control will be passed directly to the drivers which apply their semantics on brightness set, which is disable the blinking in case of most such drivers. New drivers will apply new semantics and just change the brightness while hardware blinking is on, if possible. The issue was smuggled by subsequent LED core improvements, which modified the code that originally introduced the problem. Fixes: f1e80c0741 ("leds: core: Add two new LED_BLINK_ flags") Signed-off-by: Tony Makkiel <tony.makkiel@daqri.com> Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>		2016-06-08 11:47:06 +02:00
..
acpi	Merge branches 'acpica-fixes', 'acpi-video' and 'acpi-processor'	2016-06-03 22:35:05 +02:00
asm-generic	Merge branch 'sched-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2016-05-25 17:11:43 -07:00
clocksource
crypto	Merge branch 'next' of git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security	2016-05-19 09:21:36 -07:00
drm	Merge tag 'drm-intel-next-fixes-2016-05-25' of git://anongit.freedesktop.org/drm-intel into drm-next	2016-05-27 16:08:38 +10:00
dt-bindings	Merge branch 'next' of git://git.kernel.org/pub/scm/linux/kernel/git/rzhang/linux	2016-05-26 09:23:43 -07:00
keys
kvm	KVM: arm/arm64: vgic-new: implement mapped IRQ handling	2016-05-20 15:40:09 +02:00
linux	leds: core: Fix brightness setting upon hardware blinking enabled	2016-06-08 11:47:06 +02:00
math-emu
media
memory
misc
net	ipv6: hide ip6_encap_hlen/ip6_tnl_encap definitions	2016-05-29 22:24:21 -07:00
pcmcia
ras
rdma	IB/core: Make device counter infrastructure dynamic	2016-05-26 12:52:51 -04:00
rxrpc
scsi
soc	ARC updates for 4.7-rc1	2016-05-19 09:46:18 -07:00
sound
target	Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending	2016-05-28 12:04:17 -07:00
trace	- move kvm_stat tool from QEMU repo into tools/kvm/kvm_stat	2016-05-27 13:41:54 -07:00
uapi	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2016-05-31 22:28:28 -07:00
video	imx-drm probing fix	2016-05-25 12:36:20 +10:00
xen
Kbuild