mirror of
https://github.com/AuxXxilium/linux_dsm_epyc7002.git
synced 2024-12-28 11:18:45 +07:00
94f2026bd8
The current codebase makes use of one-element arrays in the following
form:
struct something {
int length;
u8 data[1];
};
struct something *instance;
instance = kmalloc(sizeof(*instance) + size, GFP_KERNEL);
instance->length = size;
memcpy(instance->data, source, size);
but the preferred mechanism to declare variable-length types such as
these ones is a flexible array member[1][2], introduced in C99:
struct foo {
int stuff;
struct boo array[];
};
By making use of the mechanism above, we will get a compiler warning
in case the flexible array does not occur last in the structure, which
will help us prevent some kind of undefined behavior bugs from being
inadvertently introduced[3] to the codebase from now on. So, replace
the one-element array with a flexible-array member.
Also, make use of the new struct_size() helper to properly calculate the
size of struct smu10_voltage_dependency_table.
This issue was found with the help of Coccinelle and, audited and fixed
_manually_.
[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit
|
||
|---|---|---|
| .. | ||
| hwmgr | ||
| inc | ||
| smumgr | ||
| amd_powerplay.c | ||
| amdgpu_smu.c | ||
| arcturus_ppt.c | ||
| arcturus_ppt.h | ||
| Makefile | ||
| navi10_ppt.c | ||
| navi10_ppt.h | ||
| renoir_ppt.c | ||
| renoir_ppt.h | ||
| smu_internal.h | ||
| smu_v11_0.c | ||
| smu_v12_0.c | ||
| vega20_ppt.c | ||
| vega20_ppt.h | ||