Lukas Wunner 009f8c90f5 ALSA: hda - Fix runtime PM ... Before commit 3b5b899ca6 ("ALSA: hda: Make use of core codec functions to sync power state"), hda_set_power_state() returned the response to the Get Power State verb, a 32-bit unsigned integer whose expected value is 0x233 after transitioning a codec to D3, and 0x0 after transitioning it to D0. The response value is significant because hda_codec_runtime_suspend() does not clear the codec's bit in the codec_powered bitmask unless the AC_PWRST_CLK_STOP_OK bit (0x200) is set in the response value. That in turn prevents the HDA controller from runtime suspending because azx_runtime_idle() checks that the codec_powered bitmask is zero. Since commit 3b5b899ca6, hda_set_power_state() only returns 0x0 or 0x1, thereby breaking runtime PM for any HDA controller. That's because an inline function introduced by the commit returns a bool instead of a 32-bit unsigned int. The change was likely erroneous and resulted from copying and pasting snd_hda_check_power_state(), which is immediately preceding the newly introduced inline function. Fix it. Link: https://bugs.freedesktop.org/show_bug.cgi?id=106597 Fixes: 3b5b899ca6 ("ALSA: hda: Make use of core codec functions to sync power state") Cc: Alex Deucher <alexander.deucher@amd.com> Cc: Abhijeet Kumar <abhijeet.kumar@intel.com> Reported-and-tested-by: Gunnar Krüger <taijian@posteo.de> Signed-off-by: Lukas Wunner <lukas@wunner.de> Acked-by: Alex Deucher <alexander.deucher@amd.com> Signed-off-by: Takashi Iwai <tiwai@suse.de>		2018-05-24 20:16:47 +02:00
..
ac97	ALSA: ac97: kconfig: Remove select of undefined symbol AC97	2018-02-12 08:16:39 +01:00
aoa
arm
atmel
core	ALSA: timer: Fix pause event notification	2018-05-18 08:43:59 +02:00
drivers	ALSA: aloop: Add missing cable lock to ctl API callbacks	2018-04-30 10:06:48 +02:00
firewire	ALSA: dice: fix kernel NULL pointer dereference due to invalid calculation for array index	2018-04-29 09:06:39 +02:00
hda	ALSA: hda: Copying sync power state helper to core	2018-02-12 13:59:39 +01:00
i2c
isa
mips
oss	vfs: do bulk POLL* -> EPOLL* replacement	2018-02-11 14:34:03 -08:00
parisc
pci	ALSA: hda - Fix runtime PM	2018-05-24 20:16:47 +02:00
pcmcia
ppc
sh
soc	ASoC: Fixes for v4.17	2018-04-25 12:22:20 +02:00
sparc
spi
synth
usb	ALSA: usb-audio: Use Class Specific EP for UAC3 devices.	2018-05-15 07:29:10 +02:00
x86	ALSA: x86: Fix potential crash at error path	2018-02-28 08:46:00 +01:00
ac97_bus.c
Kconfig
last.c
Makefile
sound_core.c