mirror of
https://github.com/AuxXxilium/linux_dsm_epyc7002.git
synced 2024-12-24 23:34:40 +07:00
2055da9738
So I've noticed a number of instances where it was not obvious from the
code whether ->task_list was for a wait-queue head or a wait-queue entry.
Furthermore, there's a number of wait-queue users where the lists are
not for 'tasks' but other entities (poll tables, etc.), in which case
the 'task_list' name is actively confusing.
To clear this all up, name the wait-queue head and entry list structure
fields unambiguously:
struct wait_queue_head::task_list => ::head
struct wait_queue_entry::task_list => ::entry
For example, this code:
rqw->wait.task_list.next != &wait->task_list
... is was pretty unclear (to me) what it's doing, while now it's written this way:
rqw->wait.head.next != &wait->entry
... which makes it pretty clear that we are iterating a list until we see the head.
Other examples are:
list_for_each_entry_safe(pos, next, &x->task_list, task_list) {
list_for_each_entry(wq, &fence->wait.task_list, task_list) {
... where it's unclear (to me) what we are iterating, and during review it's
hard to tell whether it's trying to walk a wait-queue entry (which would be
a bug), while now it's written as:
list_for_each_entry_safe(pos, next, &x->head, entry) {
list_for_each_entry(wq, &fence->wait.head, entry) {
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
|
||
|---|---|---|
| .. | ||
| class.c | ||
| hctosys.c | ||
| interface.c | ||
| Kconfig | ||
| Makefile | ||
| rtc-88pm80x.c | ||
| rtc-88pm860x.c | ||
| rtc-ab3100.c | ||
| rtc-ab8500.c | ||
| rtc-ab-b5ze-s3.c | ||
| rtc-abx80x.c | ||
| rtc-ac100.c | ||
| rtc-armada38x.c | ||
| rtc-as3722.c | ||
| rtc-asm9260.c | ||
| rtc-at32ap700x.c | ||
| rtc-at91rm9200.c | ||
| rtc-at91rm9200.h | ||
| rtc-at91sam9.c | ||
| rtc-au1xxx.c | ||
| rtc-bfin.c | ||
| rtc-bq32k.c | ||
| rtc-bq4802.c | ||
| rtc-cmos.c | ||
| rtc-coh901331.c | ||
| rtc-core.h | ||
| rtc-cpcap.c | ||
| rtc-da9052.c | ||
| rtc-da9055.c | ||
| rtc-da9063.c | ||
| rtc-davinci.c | ||
| rtc-dev.c | ||
| rtc-digicolor.c | ||
| rtc-dm355evm.c | ||
| rtc-ds1216.c | ||
| rtc-ds1286.c | ||
| rtc-ds1302.c | ||
| rtc-ds1305.c | ||
| rtc-ds1307.c | ||
| rtc-ds1343.c | ||
| rtc-ds1347.c | ||
| rtc-ds1374.c | ||
| rtc-ds1390.c | ||
| rtc-ds1511.c | ||
| rtc-ds1553.c | ||
| rtc-ds1672.c | ||
| rtc-ds1685.c | ||
| rtc-ds1742.c | ||
| rtc-ds2404.c | ||
| rtc-ds3232.c | ||
| rtc-efi-platform.c | ||
| rtc-efi.c | ||
| rtc-em3027.c | ||
| rtc-ep93xx.c | ||
| rtc-fm3130.c | ||
| rtc-gemini.c | ||
| rtc-generic.c | ||
| rtc-hid-sensor-time.c | ||
| rtc-hym8563.c | ||
| rtc-imxdi.c | ||
| rtc-isl1208.c | ||
| rtc-isl12022.c | ||
| rtc-jz4740.c | ||
| rtc-lib.c | ||
| rtc-lp8788.c | ||
| rtc-lpc24xx.c | ||
| rtc-lpc32xx.c | ||
| rtc-ls1x.c | ||
| rtc-m41t80.c | ||
| rtc-m41t93.c | ||
| rtc-m41t94.c | ||
| rtc-m48t35.c | ||
| rtc-m48t59.c | ||
| rtc-m48t86.c | ||
| rtc-max6900.c | ||
| rtc-max6902.c | ||
| rtc-max6916.c | ||
| rtc-max8907.c | ||
| rtc-max8925.c | ||
| rtc-max8997.c | ||
| rtc-max8998.c | ||
| rtc-max77686.c | ||
| rtc-mc13xxx.c | ||
| rtc-mc146818-lib.c | ||
| rtc-mcp795.c | ||
| rtc-moxart.c | ||
| rtc-mpc5121.c | ||
| rtc-mrst.c | ||
| rtc-msm6242.c | ||
| rtc-mt6397.c | ||
| rtc-mv.c | ||
| rtc-mxc.c | ||
| rtc-nuc900.c | ||
| rtc-omap.c | ||
| rtc-opal.c | ||
| rtc-palmas.c | ||
| rtc-pcap.c | ||
| rtc-pcf2123.c | ||
| rtc-pcf2127.c | ||
| rtc-pcf8523.c | ||
| rtc-pcf8563.c | ||
| rtc-pcf8583.c | ||
| rtc-pcf50633.c | ||
| rtc-pcf85063.c | ||
| rtc-pic32.c | ||
| rtc-pl030.c | ||
| rtc-pl031.c | ||
| rtc-pm8xxx.c | ||
| rtc-proc.c | ||
| rtc-ps3.c | ||
| rtc-puv3.c | ||
| rtc-pxa.c | ||
| rtc-r7301.c | ||
| rtc-r9701.c | ||
| rtc-rc5t583.c | ||
| rtc-rk808.c | ||
| rtc-rp5c01.c | ||
| rtc-rs5c313.c | ||
| rtc-rs5c348.c | ||
| rtc-rs5c372.c | ||
| rtc-rv3029c2.c | ||
| rtc-rv8803.c | ||
| rtc-rx4581.c | ||
| rtc-rx6110.c | ||
| rtc-rx8010.c | ||
| rtc-rx8025.c | ||
| rtc-rx8581.c | ||
| rtc-s3c.c | ||
| rtc-s3c.h | ||
| rtc-s5m.c | ||
| rtc-s35390a.c | ||
| rtc-sa1100.c | ||
| rtc-sa1100.h | ||
| rtc-sh.c | ||
| rtc-sirfsoc.c | ||
| rtc-snvs.c | ||
| rtc-spear.c | ||
| rtc-st-lpc.c | ||
| rtc-starfire.c | ||
| rtc-stk17ta8.c | ||
| rtc-stm32.c | ||
| rtc-stmp3xxx.c | ||
| rtc-sun4v.c | ||
| rtc-sun6i.c | ||
| rtc-sunxi.c | ||
| rtc-sysfs.c | ||
| rtc-tegra.c | ||
| rtc-test.c | ||
| rtc-tile.c | ||
| rtc-tps6586x.c | ||
| rtc-tps65910.c | ||
| rtc-tps80031.c | ||
| rtc-twl.c | ||
| rtc-tx4939.c | ||
| rtc-v3020.c | ||
| rtc-vr41xx.c | ||
| rtc-vt8500.c | ||
| rtc-wm831x.c | ||
| rtc-wm8350.c | ||
| rtc-x1205.c | ||
| rtc-xgene.c | ||
| rtc-zynqmp.c | ||
| systohc.c | ||