Lyude Paul 39b50c6038 drm/atomic_helper: Stop modesets on unregistered connectors harder ... Unfortunately, it appears our fix in: commit b5d29843d8 ("drm/atomic_helper: Allow DPMS On<->Off changes for unregistered connectors") Which attempted to work around the problems introduced by: commit 4d80273976 ("drm/atomic_helper: Disallow new modesets on unregistered connectors") Is still not the right solution, as modesets can still be triggered outside of drm_atomic_set_crtc_for_connector(). So in order to fix this, while still being careful that we don't break modesets that a driver may perform before being registered with userspace, we replace connector->registered with a tristate member, connector->registration_state. This allows us to keep track of whether or not a connector is still initializing and hasn't been exposed to userspace, is currently registered and exposed to userspace, or has been legitimately removed from the system after having once been present. Using this info, we can prevent userspace from performing new modesets on unregistered connectors while still allowing the driver to perform modesets on unregistered connectors before the driver has finished being registered. Changes since v1: - Fix WARN_ON() in drm_connector_cleanup() that CI caught with this patchset in igt@drv_module_reload@basic-reload-inject and igt@drv_module_reload@basic-reload by checking if the connector is registered instead of unregistered, as calling drm_connector_cleanup() on a connector that hasn't been registered with userspace yet should stay valid. - Remove unregistered_connector_check(), and just go back to what we were doing before in commit 4d80273976 ("drm/atomic_helper: Disallow new modesets on unregistered connectors") except replacing READ_ONCE(connector->registered) with drm_connector_is_unregistered(). This gets rid of the behavior of allowing DPMS On<->Off, but that should be fine as it's more consistent with the UAPI we had before - danvet - s/drm_connector_unregistered/drm_connector_is_unregistered/ - danvet - Update documentation, fix some typos. Fixes: b5d29843d8 ("drm/atomic_helper: Allow DPMS On<->Off changes for unregistered connectors") Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Cc: Daniel Vetter <daniel.vetter@ffwll.ch> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> Cc: stable@vger.kernel.org Cc: David Airlie <airlied@linux.ie> Signed-off-by: Lyude Paul <lyude@redhat.com> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> Link: https://patchwork.freedesktop.org/patch/msgid/20181016203946.9601-1-lyude@redhat.com		2018-10-17 13:50:14 -04:00
..
acpi	ACPICA: Update version to 20180810	2018-08-14 23:49:13 +02:00
asm-generic	Kbuild updates for v4.19 (2nd)	2018-08-25 13:40:38 -07:00
clocksource
crypto	crypto: scatterwalk - remove scatterwalk_samebuf()	2018-08-03 18:06:04 +08:00
drm	drm/atomic_helper: Stop modesets on unregistered connectors harder	2018-10-17 13:50:14 -04:00
dt-bindings	ARM: SoC: late updates	2018-08-25 14:12:36 -07:00
keys
kvm	KVM: arm/arm64: vgic-v3: Add core support for Group0 SGIs	2018-08-12 12:06:34 +01:00
linux	drm: shmobile: convert to SPDX identifiers	2018-09-14 13:54:02 +03:00
math-emu
media	- New Drivers	2018-08-20 15:38:44 -07:00
memory
misc
net	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2018-08-27 11:59:39 -07:00
pcmcia	pcmcia: remove long deprecated pcmcia_request_exclusive_irq() function	2018-08-18 12:30:42 -07:00
ras
rdma	Second merge window update	2018-08-23 15:34:48 -07:00
scsi	SCSI misc on 20180815	2018-08-15 22:06:26 -07:00
soc
sound	ASoC: Updates for v4.19	2018-08-13 12:12:31 +02:00
target
trace	Merge branch 'for-4.19' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup	2018-08-24 13:19:27 -07:00
uapi	drm/i915: Remove i915.enable_ppgtt override	2018-09-27 12:05:31 +01:00
video	fbdev changes for v4.19:	2018-08-23 15:44:58 -07:00
xen	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input	2018-08-18 16:48:07 -07:00