mirror of
https://github.com/AuxXxilium/linux_dsm_epyc7002.git
synced 2024-12-28 09:55:29 +07:00
614b1868a1
We just changed the code so we apply bias disable on the correct
register but forgot to align the register calculation. The result
is that we apply the change on the correct register, but possibly
at the incorrect offset/bit
This went undetected because offsets tends to be the same between
REG_PULL and REG_PULLEN for a given pin the EE controller. This
is not true for the AO controller.
Fixes: e39f9dd820
("pinctrl: meson: fix pinconf bias disable")
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
Acked-by: Neil Armstrong <narmstrong@baylibre.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
544 lines
14 KiB
C
544 lines
14 KiB
C
/*
|
|
* Pin controller and GPIO driver for Amlogic Meson SoCs
|
|
*
|
|
* Copyright (C) 2014 Beniamino Galvani <b.galvani@gmail.com>
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public License
|
|
* version 2 as published by the Free Software Foundation.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
/*
|
|
* The available pins are organized in banks (A,B,C,D,E,X,Y,Z,AO,
|
|
* BOOT,CARD for meson6, X,Y,DV,H,Z,AO,BOOT,CARD for meson8 and
|
|
* X,Y,DV,H,AO,BOOT,CARD,DIF for meson8b) and each bank has a
|
|
* variable number of pins.
|
|
*
|
|
* The AO bank is special because it belongs to the Always-On power
|
|
* domain which can't be powered off; the bank also uses a set of
|
|
* registers different from the other banks.
|
|
*
|
|
* For each pin controller there are 4 different register ranges that
|
|
* control the following properties of the pins:
|
|
* 1) pin muxing
|
|
* 2) pull enable/disable
|
|
* 3) pull up/down
|
|
* 4) GPIO direction, output value, input value
|
|
*
|
|
* In some cases the register ranges for pull enable and pull
|
|
* direction are the same and thus there are only 3 register ranges.
|
|
*
|
|
* For the pull and GPIO configuration every bank uses a contiguous
|
|
* set of bits in the register sets described above; the same register
|
|
* can be shared by more banks with different offsets.
|
|
*
|
|
* In addition to this there are some registers shared between all
|
|
* banks that control the IRQ functionality. This feature is not
|
|
* supported at the moment by the driver.
|
|
*/
|
|
|
|
#include <linux/device.h>
|
|
#include <linux/gpio/driver.h>
|
|
#include <linux/init.h>
|
|
#include <linux/io.h>
|
|
#include <linux/of.h>
|
|
#include <linux/of_address.h>
|
|
#include <linux/of_device.h>
|
|
#include <linux/pinctrl/pinconf-generic.h>
|
|
#include <linux/pinctrl/pinconf.h>
|
|
#include <linux/pinctrl/pinctrl.h>
|
|
#include <linux/pinctrl/pinmux.h>
|
|
#include <linux/platform_device.h>
|
|
#include <linux/regmap.h>
|
|
#include <linux/seq_file.h>
|
|
|
|
#include "../core.h"
|
|
#include "../pinctrl-utils.h"
|
|
#include "pinctrl-meson.h"
|
|
|
|
/**
|
|
* meson_get_bank() - find the bank containing a given pin
|
|
*
|
|
* @pc: the pinctrl instance
|
|
* @pin: the pin number
|
|
* @bank: the found bank
|
|
*
|
|
* Return: 0 on success, a negative value on error
|
|
*/
|
|
static int meson_get_bank(struct meson_pinctrl *pc, unsigned int pin,
|
|
struct meson_bank **bank)
|
|
{
|
|
int i;
|
|
|
|
for (i = 0; i < pc->data->num_banks; i++) {
|
|
if (pin >= pc->data->banks[i].first &&
|
|
pin <= pc->data->banks[i].last) {
|
|
*bank = &pc->data->banks[i];
|
|
return 0;
|
|
}
|
|
}
|
|
|
|
return -EINVAL;
|
|
}
|
|
|
|
/**
|
|
* meson_calc_reg_and_bit() - calculate register and bit for a pin
|
|
*
|
|
* @bank: the bank containing the pin
|
|
* @pin: the pin number
|
|
* @reg_type: the type of register needed (pull-enable, pull, etc...)
|
|
* @reg: the computed register offset
|
|
* @bit: the computed bit
|
|
*/
|
|
static void meson_calc_reg_and_bit(struct meson_bank *bank, unsigned int pin,
|
|
enum meson_reg_type reg_type,
|
|
unsigned int *reg, unsigned int *bit)
|
|
{
|
|
struct meson_reg_desc *desc = &bank->regs[reg_type];
|
|
|
|
*reg = desc->reg * 4;
|
|
*bit = desc->bit + pin - bank->first;
|
|
}
|
|
|
|
static int meson_get_groups_count(struct pinctrl_dev *pcdev)
|
|
{
|
|
struct meson_pinctrl *pc = pinctrl_dev_get_drvdata(pcdev);
|
|
|
|
return pc->data->num_groups;
|
|
}
|
|
|
|
static const char *meson_get_group_name(struct pinctrl_dev *pcdev,
|
|
unsigned selector)
|
|
{
|
|
struct meson_pinctrl *pc = pinctrl_dev_get_drvdata(pcdev);
|
|
|
|
return pc->data->groups[selector].name;
|
|
}
|
|
|
|
static int meson_get_group_pins(struct pinctrl_dev *pcdev, unsigned selector,
|
|
const unsigned **pins, unsigned *num_pins)
|
|
{
|
|
struct meson_pinctrl *pc = pinctrl_dev_get_drvdata(pcdev);
|
|
|
|
*pins = pc->data->groups[selector].pins;
|
|
*num_pins = pc->data->groups[selector].num_pins;
|
|
|
|
return 0;
|
|
}
|
|
|
|
static void meson_pin_dbg_show(struct pinctrl_dev *pcdev, struct seq_file *s,
|
|
unsigned offset)
|
|
{
|
|
seq_printf(s, " %s", dev_name(pcdev->dev));
|
|
}
|
|
|
|
static const struct pinctrl_ops meson_pctrl_ops = {
|
|
.get_groups_count = meson_get_groups_count,
|
|
.get_group_name = meson_get_group_name,
|
|
.get_group_pins = meson_get_group_pins,
|
|
.dt_node_to_map = pinconf_generic_dt_node_to_map_all,
|
|
.dt_free_map = pinctrl_utils_free_map,
|
|
.pin_dbg_show = meson_pin_dbg_show,
|
|
};
|
|
|
|
int meson_pmx_get_funcs_count(struct pinctrl_dev *pcdev)
|
|
{
|
|
struct meson_pinctrl *pc = pinctrl_dev_get_drvdata(pcdev);
|
|
|
|
return pc->data->num_funcs;
|
|
}
|
|
|
|
const char *meson_pmx_get_func_name(struct pinctrl_dev *pcdev,
|
|
unsigned selector)
|
|
{
|
|
struct meson_pinctrl *pc = pinctrl_dev_get_drvdata(pcdev);
|
|
|
|
return pc->data->funcs[selector].name;
|
|
}
|
|
|
|
int meson_pmx_get_groups(struct pinctrl_dev *pcdev, unsigned selector,
|
|
const char * const **groups,
|
|
unsigned * const num_groups)
|
|
{
|
|
struct meson_pinctrl *pc = pinctrl_dev_get_drvdata(pcdev);
|
|
|
|
*groups = pc->data->funcs[selector].groups;
|
|
*num_groups = pc->data->funcs[selector].num_groups;
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int meson_pinconf_set(struct pinctrl_dev *pcdev, unsigned int pin,
|
|
unsigned long *configs, unsigned num_configs)
|
|
{
|
|
struct meson_pinctrl *pc = pinctrl_dev_get_drvdata(pcdev);
|
|
struct meson_bank *bank;
|
|
enum pin_config_param param;
|
|
unsigned int reg, bit;
|
|
int i, ret;
|
|
|
|
ret = meson_get_bank(pc, pin, &bank);
|
|
if (ret)
|
|
return ret;
|
|
|
|
for (i = 0; i < num_configs; i++) {
|
|
param = pinconf_to_config_param(configs[i]);
|
|
|
|
switch (param) {
|
|
case PIN_CONFIG_BIAS_DISABLE:
|
|
dev_dbg(pc->dev, "pin %u: disable bias\n", pin);
|
|
|
|
meson_calc_reg_and_bit(bank, pin, REG_PULLEN, ®,
|
|
&bit);
|
|
ret = regmap_update_bits(pc->reg_pullen, reg,
|
|
BIT(bit), 0);
|
|
if (ret)
|
|
return ret;
|
|
break;
|
|
case PIN_CONFIG_BIAS_PULL_UP:
|
|
dev_dbg(pc->dev, "pin %u: enable pull-up\n", pin);
|
|
|
|
meson_calc_reg_and_bit(bank, pin, REG_PULLEN,
|
|
®, &bit);
|
|
ret = regmap_update_bits(pc->reg_pullen, reg,
|
|
BIT(bit), BIT(bit));
|
|
if (ret)
|
|
return ret;
|
|
|
|
meson_calc_reg_and_bit(bank, pin, REG_PULL, ®, &bit);
|
|
ret = regmap_update_bits(pc->reg_pull, reg,
|
|
BIT(bit), BIT(bit));
|
|
if (ret)
|
|
return ret;
|
|
break;
|
|
case PIN_CONFIG_BIAS_PULL_DOWN:
|
|
dev_dbg(pc->dev, "pin %u: enable pull-down\n", pin);
|
|
|
|
meson_calc_reg_and_bit(bank, pin, REG_PULLEN,
|
|
®, &bit);
|
|
ret = regmap_update_bits(pc->reg_pullen, reg,
|
|
BIT(bit), BIT(bit));
|
|
if (ret)
|
|
return ret;
|
|
|
|
meson_calc_reg_and_bit(bank, pin, REG_PULL, ®, &bit);
|
|
ret = regmap_update_bits(pc->reg_pull, reg,
|
|
BIT(bit), 0);
|
|
if (ret)
|
|
return ret;
|
|
break;
|
|
default:
|
|
return -ENOTSUPP;
|
|
}
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int meson_pinconf_get_pull(struct meson_pinctrl *pc, unsigned int pin)
|
|
{
|
|
struct meson_bank *bank;
|
|
unsigned int reg, bit, val;
|
|
int ret, conf;
|
|
|
|
ret = meson_get_bank(pc, pin, &bank);
|
|
if (ret)
|
|
return ret;
|
|
|
|
meson_calc_reg_and_bit(bank, pin, REG_PULLEN, ®, &bit);
|
|
|
|
ret = regmap_read(pc->reg_pullen, reg, &val);
|
|
if (ret)
|
|
return ret;
|
|
|
|
if (!(val & BIT(bit))) {
|
|
conf = PIN_CONFIG_BIAS_DISABLE;
|
|
} else {
|
|
meson_calc_reg_and_bit(bank, pin, REG_PULL, ®, &bit);
|
|
|
|
ret = regmap_read(pc->reg_pull, reg, &val);
|
|
if (ret)
|
|
return ret;
|
|
|
|
if (val & BIT(bit))
|
|
conf = PIN_CONFIG_BIAS_PULL_UP;
|
|
else
|
|
conf = PIN_CONFIG_BIAS_PULL_DOWN;
|
|
}
|
|
|
|
return conf;
|
|
}
|
|
|
|
static int meson_pinconf_get(struct pinctrl_dev *pcdev, unsigned int pin,
|
|
unsigned long *config)
|
|
{
|
|
struct meson_pinctrl *pc = pinctrl_dev_get_drvdata(pcdev);
|
|
enum pin_config_param param = pinconf_to_config_param(*config);
|
|
u16 arg;
|
|
|
|
switch (param) {
|
|
case PIN_CONFIG_BIAS_DISABLE:
|
|
case PIN_CONFIG_BIAS_PULL_DOWN:
|
|
case PIN_CONFIG_BIAS_PULL_UP:
|
|
if (meson_pinconf_get_pull(pc, pin) == param)
|
|
arg = 1;
|
|
else
|
|
return -EINVAL;
|
|
break;
|
|
default:
|
|
return -ENOTSUPP;
|
|
}
|
|
|
|
*config = pinconf_to_config_packed(param, arg);
|
|
dev_dbg(pc->dev, "pinconf for pin %u is %lu\n", pin, *config);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int meson_pinconf_group_set(struct pinctrl_dev *pcdev,
|
|
unsigned int num_group,
|
|
unsigned long *configs, unsigned num_configs)
|
|
{
|
|
struct meson_pinctrl *pc = pinctrl_dev_get_drvdata(pcdev);
|
|
struct meson_pmx_group *group = &pc->data->groups[num_group];
|
|
int i;
|
|
|
|
dev_dbg(pc->dev, "set pinconf for group %s\n", group->name);
|
|
|
|
for (i = 0; i < group->num_pins; i++) {
|
|
meson_pinconf_set(pcdev, group->pins[i], configs,
|
|
num_configs);
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int meson_pinconf_group_get(struct pinctrl_dev *pcdev,
|
|
unsigned int group, unsigned long *config)
|
|
{
|
|
return -ENOTSUPP;
|
|
}
|
|
|
|
static const struct pinconf_ops meson_pinconf_ops = {
|
|
.pin_config_get = meson_pinconf_get,
|
|
.pin_config_set = meson_pinconf_set,
|
|
.pin_config_group_get = meson_pinconf_group_get,
|
|
.pin_config_group_set = meson_pinconf_group_set,
|
|
.is_generic = true,
|
|
};
|
|
|
|
static int meson_gpio_direction_input(struct gpio_chip *chip, unsigned gpio)
|
|
{
|
|
struct meson_pinctrl *pc = gpiochip_get_data(chip);
|
|
unsigned int reg, bit;
|
|
struct meson_bank *bank;
|
|
int ret;
|
|
|
|
ret = meson_get_bank(pc, gpio, &bank);
|
|
if (ret)
|
|
return ret;
|
|
|
|
meson_calc_reg_and_bit(bank, gpio, REG_DIR, ®, &bit);
|
|
|
|
return regmap_update_bits(pc->reg_gpio, reg, BIT(bit), BIT(bit));
|
|
}
|
|
|
|
static int meson_gpio_direction_output(struct gpio_chip *chip, unsigned gpio,
|
|
int value)
|
|
{
|
|
struct meson_pinctrl *pc = gpiochip_get_data(chip);
|
|
unsigned int reg, bit;
|
|
struct meson_bank *bank;
|
|
int ret;
|
|
|
|
ret = meson_get_bank(pc, gpio, &bank);
|
|
if (ret)
|
|
return ret;
|
|
|
|
meson_calc_reg_and_bit(bank, gpio, REG_DIR, ®, &bit);
|
|
ret = regmap_update_bits(pc->reg_gpio, reg, BIT(bit), 0);
|
|
if (ret)
|
|
return ret;
|
|
|
|
meson_calc_reg_and_bit(bank, gpio, REG_OUT, ®, &bit);
|
|
return regmap_update_bits(pc->reg_gpio, reg, BIT(bit),
|
|
value ? BIT(bit) : 0);
|
|
}
|
|
|
|
static void meson_gpio_set(struct gpio_chip *chip, unsigned gpio, int value)
|
|
{
|
|
struct meson_pinctrl *pc = gpiochip_get_data(chip);
|
|
unsigned int reg, bit;
|
|
struct meson_bank *bank;
|
|
int ret;
|
|
|
|
ret = meson_get_bank(pc, gpio, &bank);
|
|
if (ret)
|
|
return;
|
|
|
|
meson_calc_reg_and_bit(bank, gpio, REG_OUT, ®, &bit);
|
|
regmap_update_bits(pc->reg_gpio, reg, BIT(bit),
|
|
value ? BIT(bit) : 0);
|
|
}
|
|
|
|
static int meson_gpio_get(struct gpio_chip *chip, unsigned gpio)
|
|
{
|
|
struct meson_pinctrl *pc = gpiochip_get_data(chip);
|
|
unsigned int reg, bit, val;
|
|
struct meson_bank *bank;
|
|
int ret;
|
|
|
|
ret = meson_get_bank(pc, gpio, &bank);
|
|
if (ret)
|
|
return ret;
|
|
|
|
meson_calc_reg_and_bit(bank, gpio, REG_IN, ®, &bit);
|
|
regmap_read(pc->reg_gpio, reg, &val);
|
|
|
|
return !!(val & BIT(bit));
|
|
}
|
|
|
|
static int meson_gpiolib_register(struct meson_pinctrl *pc)
|
|
{
|
|
int ret;
|
|
|
|
pc->chip.label = pc->data->name;
|
|
pc->chip.parent = pc->dev;
|
|
pc->chip.request = gpiochip_generic_request;
|
|
pc->chip.free = gpiochip_generic_free;
|
|
pc->chip.direction_input = meson_gpio_direction_input;
|
|
pc->chip.direction_output = meson_gpio_direction_output;
|
|
pc->chip.get = meson_gpio_get;
|
|
pc->chip.set = meson_gpio_set;
|
|
pc->chip.base = -1;
|
|
pc->chip.ngpio = pc->data->num_pins;
|
|
pc->chip.can_sleep = false;
|
|
pc->chip.of_node = pc->of_node;
|
|
pc->chip.of_gpio_n_cells = 2;
|
|
|
|
ret = gpiochip_add_data(&pc->chip, pc);
|
|
if (ret) {
|
|
dev_err(pc->dev, "can't add gpio chip %s\n",
|
|
pc->data->name);
|
|
return ret;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static struct regmap_config meson_regmap_config = {
|
|
.reg_bits = 32,
|
|
.val_bits = 32,
|
|
.reg_stride = 4,
|
|
};
|
|
|
|
static struct regmap *meson_map_resource(struct meson_pinctrl *pc,
|
|
struct device_node *node, char *name)
|
|
{
|
|
struct resource res;
|
|
void __iomem *base;
|
|
int i;
|
|
|
|
i = of_property_match_string(node, "reg-names", name);
|
|
if (of_address_to_resource(node, i, &res))
|
|
return ERR_PTR(-ENOENT);
|
|
|
|
base = devm_ioremap_resource(pc->dev, &res);
|
|
if (IS_ERR(base))
|
|
return ERR_CAST(base);
|
|
|
|
meson_regmap_config.max_register = resource_size(&res) - 4;
|
|
meson_regmap_config.name = devm_kasprintf(pc->dev, GFP_KERNEL,
|
|
"%pOFn-%s", node,
|
|
name);
|
|
if (!meson_regmap_config.name)
|
|
return ERR_PTR(-ENOMEM);
|
|
|
|
return devm_regmap_init_mmio(pc->dev, base, &meson_regmap_config);
|
|
}
|
|
|
|
static int meson_pinctrl_parse_dt(struct meson_pinctrl *pc,
|
|
struct device_node *node)
|
|
{
|
|
struct device_node *np, *gpio_np = NULL;
|
|
|
|
for_each_child_of_node(node, np) {
|
|
if (!of_find_property(np, "gpio-controller", NULL))
|
|
continue;
|
|
if (gpio_np) {
|
|
dev_err(pc->dev, "multiple gpio nodes\n");
|
|
return -EINVAL;
|
|
}
|
|
gpio_np = np;
|
|
}
|
|
|
|
if (!gpio_np) {
|
|
dev_err(pc->dev, "no gpio node found\n");
|
|
return -EINVAL;
|
|
}
|
|
|
|
pc->of_node = gpio_np;
|
|
|
|
pc->reg_mux = meson_map_resource(pc, gpio_np, "mux");
|
|
if (IS_ERR(pc->reg_mux)) {
|
|
dev_err(pc->dev, "mux registers not found\n");
|
|
return PTR_ERR(pc->reg_mux);
|
|
}
|
|
|
|
pc->reg_pull = meson_map_resource(pc, gpio_np, "pull");
|
|
if (IS_ERR(pc->reg_pull)) {
|
|
dev_err(pc->dev, "pull registers not found\n");
|
|
return PTR_ERR(pc->reg_pull);
|
|
}
|
|
|
|
pc->reg_pullen = meson_map_resource(pc, gpio_np, "pull-enable");
|
|
/* Use pull region if pull-enable one is not present */
|
|
if (IS_ERR(pc->reg_pullen))
|
|
pc->reg_pullen = pc->reg_pull;
|
|
|
|
pc->reg_gpio = meson_map_resource(pc, gpio_np, "gpio");
|
|
if (IS_ERR(pc->reg_gpio)) {
|
|
dev_err(pc->dev, "gpio registers not found\n");
|
|
return PTR_ERR(pc->reg_gpio);
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
int meson_pinctrl_probe(struct platform_device *pdev)
|
|
{
|
|
struct device *dev = &pdev->dev;
|
|
struct meson_pinctrl *pc;
|
|
int ret;
|
|
|
|
pc = devm_kzalloc(dev, sizeof(struct meson_pinctrl), GFP_KERNEL);
|
|
if (!pc)
|
|
return -ENOMEM;
|
|
|
|
pc->dev = dev;
|
|
pc->data = (struct meson_pinctrl_data *) of_device_get_match_data(dev);
|
|
|
|
ret = meson_pinctrl_parse_dt(pc, dev->of_node);
|
|
if (ret)
|
|
return ret;
|
|
|
|
pc->desc.name = "pinctrl-meson";
|
|
pc->desc.owner = THIS_MODULE;
|
|
pc->desc.pctlops = &meson_pctrl_ops;
|
|
pc->desc.pmxops = pc->data->pmx_ops;
|
|
pc->desc.confops = &meson_pinconf_ops;
|
|
pc->desc.pins = pc->data->pins;
|
|
pc->desc.npins = pc->data->num_pins;
|
|
|
|
pc->pcdev = devm_pinctrl_register(pc->dev, &pc->desc, pc);
|
|
if (IS_ERR(pc->pcdev)) {
|
|
dev_err(pc->dev, "can't register pinctrl device");
|
|
return PTR_ERR(pc->pcdev);
|
|
}
|
|
|
|
return meson_gpiolib_register(pc);
|
|
}
|