Mike Snitzer 6ffeb1c3f8 md: change mddev 'chunk_sectors' from int to unsigned ... Commit e2782f560c ("Revert "dm raid: remove unnecessary discard limits for raid10"") exposed compiler warnings introduced by commit e0910c8e4f ("dm raid: fix discard limits for raid1 and raid10"): In file included from ./include/linux/kernel.h:14, from ./include/asm-generic/bug.h:20, from ./arch/x86/include/asm/bug.h:93, from ./include/linux/bug.h:5, from ./include/linux/mmdebug.h:5, from ./include/linux/gfp.h:5, from ./include/linux/slab.h:15, from drivers/md/dm-raid.c:8: drivers/md/dm-raid.c: In function ‘raid_io_hints’: ./include/linux/minmax.h:18:28: warning: comparison of distinct pointer types lacks a cast (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1))) ^~ ./include/linux/minmax.h:32:4: note: in expansion of macro ‘__typecheck’ (__typecheck(x, y) && __no_side_effects(x, y)) ^~~~~~~~~~~ ./include/linux/minmax.h:42:24: note: in expansion of macro ‘__safe_cmp’ __builtin_choose_expr(__safe_cmp(x, y), \ ^~~~~~~~~~ ./include/linux/minmax.h:51:19: note: in expansion of macro ‘__careful_cmp’ #define min(x, y) __careful_cmp(x, y, <) ^~~~~~~~~~~~~ ./include/linux/minmax.h:84:39: note: in expansion of macro ‘min’ __x == 0 ? __y : ((__y == 0) ? __x : min(__x, __y)); }) ^~~ drivers/md/dm-raid.c:3739:33: note: in expansion of macro ‘min_not_zero’ limits->max_discard_sectors = min_not_zero(rs->md.chunk_sectors, ^~~~~~~~~~~~ Fix this by changing the chunk_sectors member of 'struct mddev' from int to 'unsigned int' to match the type used for the 'chunk_sectors' member of 'struct queue_limits'. Various MD code still uses 'int' but none of it appears to ever make use of signed int; and storing positive signed int in unsigned is perfectly safe. Reported-by: Song Liu <songliubraving@fb.com> Fixes: e2782f560c ("Revert "dm raid: remove unnecessary discard limits for raid10"") Fixes: e0910c8e4f ("dm raid: fix discard limits for raid1 and raid10") Cc: stable@vger,kernel.org # e0910c8e4f was marked for stable@ Signed-off-by: Mike Snitzer <snitzer@redhat.com> Reviewed-by: Song Liu <song@kernel.org> Signed-off-by: Jens Axboe <axboe@kernel.dk>		2020-12-12 10:07:50 -07:00
..
bcache	bcache: remove embedded struct cache_sb from struct cache_set	2020-10-02 14:25:30 -06:00
persistent-data	dm thin metadata: Remove unused local variable when create thin and snap	2020-09-29 16:33:11 -04:00
dm-bio-prison-v1.c
dm-bio-prison-v1.h
dm-bio-prison-v2.c
dm-bio-prison-v2.h
dm-bio-record.h
dm-bufio.c
dm-builtin.c
dm-cache-background-tracker.c
dm-cache-background-tracker.h
dm-cache-block-types.h
dm-cache-metadata.c	dm cache metadata: Avoid returning cmd->bm wild pointer on error	2020-09-02 13:38:24 -04:00
dm-cache-metadata.h
dm-cache-policy-internal.h
dm-cache-policy-smq.c
dm-cache-policy.c
dm-cache-policy.h
dm-cache-target.c	dm: use dm_table_get_device_name() where appropriate in targets	2020-09-29 16:33:08 -04:00
dm-clone-metadata.c
dm-clone-metadata.h
dm-clone-target.c
dm-core.h	dm table: make 'struct dm_table' definition accessible to all of DM core	2020-09-29 16:33:07 -04:00
dm-crypt.c	dm crypt: don't use drivers that have CRYPTO_ALG_ALLOCATES_MEMORY	2020-09-29 16:33:08 -04:00
dm-delay.c
dm-dust.c
dm-ebs-target.c
dm-era-target.c
dm-exception-store.c
dm-exception-store.h
dm-flakey.c
dm-historical-service-time.c
dm-init.c
dm-integrity.c	dm integrity: fix error reporting in bitmap mode after creation	2020-09-01 16:41:57 -04:00
dm-io.c
dm-ioctl.c	dm: export dm_copy_name_and_uuid	2020-10-01 15:03:40 -04:00
dm-kcopyd.c
dm-linear.c	dm: add support for REQ_NOWAIT and enable it for linear target	2020-09-25 08:20:03 -06:00
dm-log-userspace-base.c
dm-log-userspace-transfer.c
dm-log-userspace-transfer.h
dm-log-writes.c
dm-log.c
dm-mpath.c	dm: use dm_table_get_device_name() where appropriate in targets	2020-09-29 16:33:08 -04:00
dm-mpath.h
dm-path-selector.c
dm-path-selector.h
dm-queue-length.c
dm-raid1.c
dm-raid.c	Revert "dm raid: remove unnecessary discard limits for raid10"	2020-12-09 20:43:48 -08:00
dm-region-hash.c
dm-round-robin.c
dm-rq.c	dm table: make 'struct dm_table' definition accessible to all of DM core	2020-09-29 16:33:07 -04:00
dm-rq.h
dm-service-time.c
dm-snap-persistent.c	dm snap persistent: simplify area_io()	2020-09-29 16:33:12 -04:00
dm-snap-transient.c
dm-snap.c
dm-stats.c
dm-stats.h
dm-stripe.c
dm-switch.c
dm-sysfs.c
dm-table.c	block-5.10-2020-10-12	2020-10-13 12:12:44 -07:00
dm-target.c
dm-thin-metadata.c	dm thin metadata: Remove unused local variable when create thin and snap	2020-09-29 16:33:11 -04:00
dm-thin-metadata.h
dm-thin.c
dm-uevent.c
dm-uevent.h
dm-unstripe.c
dm-verity-fec.c
dm-verity-fec.h
dm-verity-target.c	- DM multipath locking fixes around m->flags tests and improvements to	2020-08-07 13:08:09 -07:00
dm-verity-verify-sig.c
dm-verity-verify-sig.h
dm-verity.h
dm-writecache.c	* Extend the recovery from MCE in kernel space also to processes which	2020-10-12 10:14:38 -07:00
dm-zero.c
dm-zoned-metadata.c
dm-zoned-reclaim.c
dm-zoned-target.c
dm-zoned.h
dm.c	- Improve DM core's bio splitting to use blk_max_size_offset(). Also	2020-10-14 15:05:38 -07:00
dm.h	dm table: make 'struct dm_table' definition accessible to all of DM core	2020-09-29 16:33:07 -04:00
Kconfig
Makefile
md-autodetect.c	treewide: Use fallthrough pseudo-keyword	2020-08-23 17:36:59 -05:00
md-bitmap.c	md/bitmap: fix memory leak of temporary bitmap	2020-10-08 22:37:39 -07:00
md-bitmap.h
md-cluster.c	md/bitmap: fix memory leak of temporary bitmap	2020-10-08 22:37:39 -07:00
md-cluster.h
md-faulty.c
md-linear.c	block: add a new revalidate_disk_size helper	2020-09-02 08:00:07 -06:00
md-linear.h
md-multipath.c
md-multipath.h
md.c	Revert "md: add md_submit_discard_bio() for submitting discard bio"	2020-12-09 20:46:01 -08:00
md.h	md: change mddev 'chunk_sectors' from int to unsigned	2020-12-12 10:07:50 -07:00
raid0.c	Revert "md: add md_submit_discard_bio() for submitting discard bio"	2020-12-09 20:46:01 -08:00
raid0.h
raid1-10.c
raid1.c
raid1.h
raid5-cache.c
raid5-log.h
raid5-ppl.c
raid5.c	md/raid5: fix oops during stripe resizing	2020-10-08 22:38:10 -07:00
raid5.h	md/raid5: let multiple devices of stripe_head share page	2020-09-24 16:44:44 -07:00
raid10.c	Revert "md/raid10: extend r10bio devs to raid disks"	2020-12-09 20:46:01 -08:00
raid10.h	Revert "md/raid10: improve discard request for far layout"	2020-12-09 20:46:00 -08:00