Arnd Bergmann 53dcd70eb7 media: cxd2880-spi: avoid out-of-bounds access warning ... The -Warray-bounds warning in gcc-8 triggers for a newly added file: drivers/media/spi/cxd2880-spi.c: In function 'cxd2880_write_reg': drivers/media/spi/cxd2880-spi.c:111:3: error: 'memcpy' forming offset [133, 258] is out of the bounds [0, 132] of object 'send_data' with type 'u8[132]' {aka 'unsigned char[132]'} [-Werror=array-bounds] The problem appears to be that we have two range checks in this function, first comparing against BURST_WRITE_MAX (128) and then comparing against a literal '255'. The logic checking the buffer size looks at the second one and decides that this might be the actual maximum data length. This is understandable behavior from the compiler, but the code is actually safe. Since the first check is already shorter, we can remove the loop and only leave that. To be on the safe side in case BURST_WRITE_MAX might be increased, I'm leaving the check against U8_MAX. Fixes: bd24fcddf6 ("media: cxd2880-spi: Add support for CXD2880 SPI interface") Cc: Martin Sebor <msebor@gmail.com> Signed-off-by: Arnd Bergmann <arnd@arndb.de> Reviewed-by: Yasunari Takiguchi <Yasunari.Takiguchi@sony.com> Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>		2018-05-04 11:27:00 -04:00
..
cxd2880-spi.c	media: cxd2880-spi: avoid out-of-bounds access warning	2018-05-04 11:27:00 -04:00
gs1662.c	[media] gs1662: drop kfree for memory allocated with devm_kzalloc	2016-10-24 17:59:08 -02:00
Kconfig	media: cxd2880: Add all Makefile, Kconfig files and Update MAINTAINERS file for the driver	2018-03-07 05:02:57 -05:00
Makefile	media: cxd2880: Add all Makefile, Kconfig files and Update MAINTAINERS file for the driver	2018-03-07 05:02:57 -05:00